Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042665Openbravo ERP09. Financial managementpublic2019-12-31 11:392020-03-10 16:48
Reportercberner 
Assigned ToAtulOpenbravo 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042665: Deprecated properties usage should be removed in ERP modules
DescriptionSome columns have been deprecated in AD and their usage should be removed from EPR modules.

There's a spreadsheet with modules that should be reviewed: https://docs.google.com/spreadsheets/d/1u90ALVtT3vLhhuq-Xqu5LLbunPjOexG3Ryt1FoN0OiQ/edit?usp=sharing [^]
Steps To ReproduceIn openbravo.properties add at the end:
hb.generate.deprecated.properties=true

- Execute ant smartbuild and it should show some warnings regarding the use of deprecated methods/properties
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0043391 closed AtulOpenbravo Openbravo ERP API Change: Remove deprecated properties 
related to defect 0042666 closed cberner Retail Modules Deprecated properties usage should be removed in retail modules 
related to defect 0042664 closed cberner Openbravo ERP Deprecated properties usage should be removed in platform modules 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-31 11:39cbernerNew Issue
2019-12-31 11:39cbernerAssigned To => Triage Finance
2019-12-31 11:39cbernerModules => Core
2019-12-31 11:39cbernerTriggers an Emergency Pack => No
2019-12-31 11:50cbernerRelationship addedrelated to 0042666
2019-12-31 11:50cbernerRelationship addedrelated to 0042664
2020-01-02 10:29AtulOpenbravoAssigned ToTriage Finance => AtulOpenbravo
2020-01-02 10:29AtulOpenbravoStatusnew => scheduled
2020-02-13 13:20hgbotCheckin
2020-02-13 13:20hgbotNote Added: 0117734
2020-02-13 13:20hgbotCheckin
2020-02-13 13:20hgbotNote Added: 0117735
2020-02-13 13:20hgbotCheckin
2020-02-13 13:20hgbotNote Added: 0117736
2020-02-13 13:39hgbotCheckin
2020-02-13 13:39hgbotNote Added: 0117737
2020-02-13 13:39hgbotCheckin
2020-02-13 13:39hgbotNote Added: 0117738
2020-02-13 13:39hgbotCheckin
2020-02-13 13:39hgbotNote Added: 0117739
2020-02-13 16:03hgbotCheckin
2020-02-13 16:03hgbotNote Added: 0117743
2020-02-13 16:03hgbotCheckin
2020-02-13 16:03hgbotNote Added: 0117744
2020-02-13 16:03hgbotCheckin
2020-02-13 16:03hgbotNote Added: 0117745
2020-02-13 16:45hgbotCheckin
2020-02-13 16:45hgbotNote Added: 0117747
2020-02-13 16:45hgbotCheckin
2020-02-13 16:45hgbotNote Added: 0117748
2020-02-13 16:45hgbotCheckin
2020-02-13 16:45hgbotNote Added: 0117749
2020-02-13 17:36hgbotCheckin
2020-02-13 17:36hgbotNote Added: 0117752
2020-02-13 17:36hgbotCheckin
2020-02-13 17:36hgbotNote Added: 0117753
2020-02-13 17:36hgbotCheckin
2020-02-13 17:36hgbotNote Added: 0117754
2020-02-13 17:36hgbotCheckin
2020-02-13 17:36hgbotNote Added: 0117755
2020-02-13 17:36hgbotCheckin
2020-02-13 17:36hgbotNote Added: 0117756
2020-03-02 18:12AtulOpenbravoRelationship addeddepends on 0043391
2020-03-05 18:43AtulOpenbravoIssue cloned0043435
2020-03-05 18:43AtulOpenbravoRelationship addedrelated to 0043435
2020-03-05 18:44AtulOpenbravoIssue cloned0043436
2020-03-05 18:44AtulOpenbravoRelationship addedrelated to 0043436
2020-03-05 18:46AtulOpenbravoIssue cloned0043437
2020-03-05 18:46AtulOpenbravoRelationship addedrelated to 0043437
2020-03-05 18:48AtulOpenbravoIssue cloned0043438
2020-03-05 18:48AtulOpenbravoRelationship addedrelated to 0043438
2020-03-05 18:50AtulOpenbravoIssue cloned0043439
2020-03-05 18:50AtulOpenbravoRelationship addedrelated to 0043439
2020-03-10 09:29hgbotCheckin
2020-03-10 09:29hgbotNote Added: 0118447
2020-03-10 16:44dmiguelezRelationship deletedrelated to 0043435
2020-03-10 16:45dmiguelezRelationship deletedrelated to 0043436
2020-03-10 16:45dmiguelezRelationship deletedrelated to 0043437
2020-03-10 16:45dmiguelezRelationship deletedrelated to 0043438
2020-03-10 16:45dmiguelezRelationship deletedrelated to 0043439
2020-03-10 16:48dmiguelezNote Added: 0118480
2020-03-10 16:48dmiguelezStatusscheduled => resolved
2020-03-10 16:48dmiguelezFixed in Version => 3.0PR20Q2
2020-03-10 16:48dmiguelezFixed in SCM revision => https://code.openbravo.com/erp/devel/pi/rev/a29dff27157934eb007408524b29f245d8337977 [^]
2020-03-10 16:48dmiguelezResolutionopen => fixed
2020-03-10 16:48dmiguelezReview Assigned To => dmiguelez
2020-03-10 16:48dmiguelezStatusresolved => closed

Notes
(0117734)
hgbot   
2020-02-13 13:20   
Repository: erp/pmods/org.openbravo.authorize.net
Changeset: 3fb717402dd3d312ef9e1fd0148da884afa21167
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 23:10:51 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/3fb717402dd3d312ef9e1fd0148da884afa21167 [^]

Related To ISSUE-42665:Apply Java Formatting

---
M src/org/openbravo/authorize/net/process/cim/util/CIMUtility.java
M src/org/openbravo/authorize/net/process/transactiondetails/TransactionStatus.java
---
(0117735)
hgbot   
2020-02-13 13:20   
Repository: erp/pmods/org.openbravo.authorize.net
Changeset: c414ffa48a5a3a20d7ae1b2552dac5774ce9ad34
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 23:15:54 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/c414ffa48a5a3a20d7ae1b2552dac5774ce9ad34 [^]

Related To ISSUE-42665:Deprecated properties usage should
be removed in ERP modules

**Use getPaymentPlanInvoice() method instead of method
getInvoicePaymentPlan() of FIN_PaymentDetailV
in BusinessPartnerItemsHelper, CIMUtility and
TransactionStatus class.

---
M src/org/openbravo/authorize/net/process/cim/model/BusinessPartnerItemsHelper.java
M src/org/openbravo/authorize/net/process/cim/util/CIMUtility.java
M src/org/openbravo/authorize/net/process/transactiondetails/TransactionStatus.java
---
(0117736)
hgbot   
2020-02-13 13:20   
Repository: erp/pmods/org.openbravo.authorize.net
Changeset: 3134623ba8b8fd9ff4f3c21358aa2f104e0774bc
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 13:18:53 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.authorize.net/rev/3134623ba8b8fd9ff4f3c21358aa2f104e0774bc [^]

Related to ISSUE-42665: Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0117737)
hgbot   
2020-02-13 13:39   
Repository: erp/mods/org.openbravo.obtvb
Changeset: f6865ab39da7269be189cbcc1a52716f97f67569
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 14:22:50 2020 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.obtvb/rev/f6865ab39da7269be189cbcc1a52716f97f67569 [^]

Related to ISSUE-42665:Apply Java formatting

---
M src/org/openbravo/obtvb/process/DocFINAccTransactionVatPosting.java
M src/org/openbravo/obtvb/process/DocFINPaymentVatPosting.java
M src/org/openbravo/obtvb/process/DocFINReconciliationVatPosting.java
---
(0117738)
hgbot   
2020-02-13 13:39   
Repository: erp/mods/org.openbravo.obtvb
Changeset: 3f33e4c332101bd1033cd1808d59ee526e2bc197
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 14:24:42 2020 +0530
URL: http://code.openbravo.com/erp/mods/org.openbravo.obtvb/rev/3f33e4c332101bd1033cd1808d59ee526e2bc197 [^]

Related To ISSUE-42665:Deprecated properties usage should be removed
in ERP modules

**Used method getPaymentPlanInvoice() instead of deprecated
method getInvoicePaymentPlan() from FIN_Payment_Detail_V view

---
M src/org/openbravo/obtvb/process/DocFINAccTransactionVatPosting.java
M src/org/openbravo/obtvb/process/DocFINPaymentVatPosting.java
M src/org/openbravo/obtvb/process/DocFINReconciliationVatPosting.java
---
(0117739)
hgbot   
2020-02-13 13:39   
Repository: erp/mods/org.openbravo.obtvb
Changeset: 80a67c725f48205d944541196673c6dc4435db61
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 13:38:23 2020 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.obtvb/rev/80a67c725f48205d944541196673c6dc4435db61 [^]

Related To ISSUE-42665: Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0117743)
hgbot   
2020-02-13 16:03   
Repository: erp/pmods/org.openbravo.document.massinvoicing
Changeset: 3256a32039443184df63e09920b8517677c05935
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 23:01:49 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/3256a32039443184df63e09920b8517677c05935 [^]

Related To ISSUE-42665:Apply java formatting

---
M src/org/openbravo/document/massinvoicing/InvoicePropertySetter.java
---
(0117744)
hgbot   
2020-02-13 16:03   
Repository: erp/pmods/org.openbravo.document.massinvoicing
Changeset: 8b31b03568d8118ffaac482a788255f3728c5a22
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 23:05:23 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/8b31b03568d8118ffaac482a788255f3728c5a22 [^]

Related To ISSUE-42665:Deprecated properties usage should be
removed in ERP modules

**Remove usage of deprecated methods getFormOfPayment()
and setFormOfPayment() from InvoicePropertySetter and
MassInvoicing class

---
M src/org/openbravo/document/massinvoicing/InvoicePropertySetter.java
M src/org/openbravo/document/massinvoicing/MassInvoicing.java
---
(0117745)
hgbot   
2020-02-13 16:03   
Repository: erp/pmods/org.openbravo.document.massinvoicing
Changeset: db6c5105a26e53e3b967e3f71c164d24f762fa02
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 16:01:35 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.document.massinvoicing/rev/db6c5105a26e53e3b967e3f71c164d24f762fa02 [^]

Related To ISSUE-42665: Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0117747)
hgbot   
2020-02-13 16:45   
Repository: erp/pmods/org.openbravo.idl
Changeset: 0d8bd1c9dddf0d751d44169af6a9538947679c49
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 22:46:29 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.idl/rev/0d8bd1c9dddf0d751d44169af6a9538947679c49 [^]

Related to ISSUE-42665:Apply java formatting

---
M src/org/openbravo/idl/proc/JournalEntriesProcess.java
---
(0117748)
hgbot   
2020-02-13 16:45   
Repository: erp/pmods/org.openbravo.idl
Changeset: 2df7c74307b7ee7b809e6d36a8d8ef2046105839
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Wed Feb 12 22:50:54 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.idl/rev/2df7c74307b7ee7b809e6d36a8d8ef2046105839 [^]

Related to ISSUE-42665:Deprecated properties usage should be
removed in ERP modules

** Remove usage of deprecated methods bankAccount.setShowGeneric,
bankAccount.setShowIBAN, bankAccount.isShowIBAN and
glJournalLine.setAccountingDate from BusinessPartnerProcess &
Journal Entries Process class

---
M src/org/openbravo/idl/proc/BusinessPartnersProcess.java
M src/org/openbravo/idl/proc/JournalEntriesProcess.java
---
(0117749)
hgbot   
2020-02-13 16:45   
Repository: erp/pmods/org.openbravo.idl
Changeset: fa26626e6b5100b4857ee600c94ba33848e77f9c
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 16:44:28 2020 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.idl/rev/fa26626e6b5100b4857ee600c94ba33848e77f9c [^]

Related to ISSUE-42665: Updated module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0117752)
hgbot   
2020-02-13 17:36   
Repository: erp/devel/pi
Changeset: 75886a1ea16b1055c96a4f61af31be1cc235657a
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 17:13:28 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/75886a1ea16b1055c96a4f61af31be1cc235657a [^]

Related to ISSUE-42665:Deprecated properties usage should be
removed in ERP modules

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/ProcessInvoice.java
---
(0117753)
hgbot   
2020-02-13 17:36   
Repository: erp/devel/pi
Changeset: 3d0c55ed70a5c46e651724068fc5228bf1d28586
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 17:19:14 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3d0c55ed70a5c46e651724068fc5228bf1d28586 [^]

Related to ISSUE-42665:Deprecated properties usage should be
removed in ERP modules

---
M src/org/openbravo/common/actionhandler/createlinesfromprocess/UpdateTax.java
---
(0117754)
hgbot   
2020-02-13 17:36   
Repository: erp/devel/pi
Changeset: ce683ddb3fa14798b4354518095660b4445d61f4
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 17:27:11 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ce683ddb3fa14798b4354518095660b4445d61f4 [^]

Related to ISSUE-42665:Deprecated properties usage should be
removed in ERP modules

---
M src-test/src/org/openbravo/test/costing/utils/TestCostingUtils.java
---
(0117755)
hgbot   
2020-02-13 17:36   
Repository: erp/devel/pi
Changeset: edf4115b336c0fc6bd7f2138ea529254af9a14cd
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 17:29:39 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/edf4115b336c0fc6bd7f2138ea529254af9a14cd [^]

Related to ISSUE-42665:Deprecated properties usage should be
removed in ERP modules. In this case the Java code is generated by the system because
is defined as is parent property. By changing that definition the code
is not generated using deprecated API

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0117756)
hgbot   
2020-02-13 17:36   
Repository: erp/devel/pi
Changeset: fd8d390bbf8bab3dceb371347e2622706f2d06a2
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Feb 13 17:33:29 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fd8d390bbf8bab3dceb371347e2622706f2d06a2 [^]

Related to ISSUE-42665:Deprecated method that uses deprecated API.
To be removed in the future.

---
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
---
(0118447)
hgbot   
2020-03-10 09:29   
Repository: erp/devel/pi
Changeset: a29dff27157934eb007408524b29f245d8337977
Author: Atul Gaware <atul.gaware <at> openbravo.com>
Date: Mon Mar 02 11:43:39 2020 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a29dff27157934eb007408524b29f245d8337977 [^]

Related To BUG-42665:Deprecated properties usage
should be removed in ERP modules.

**In this case the Java code is generated by the
system because is defined as is parent property.
By changing that definition the code is not
generated using deprecated API

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0118480)
dmiguelez   
2020-03-10 16:48   
Code Review + Testing Ok