Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042664Openbravo ERPA. Platformpublic2019-12-31 11:312020-10-20 11:40
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR20Q3 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042664: Deprecated properties usage should be removed in platform modules
DescriptionSome columns have been deprecated in AD and their usage should be removed from platform modules.

There's a spreadsheet with modules that should be reviewed: https://docs.google.com/spreadsheets/d/1u90ALVtT3vLhhuq-Xqu5LLbunPjOexG3Ryt1FoN0OiQ/edit?usp=sharing [^]
Steps To ReproduceIn openbravo.properties add at the end:
hb.generate.deprecated.properties=true

- Execute ant smartbuild and it should show some warnings regarding the use of deprecated methods/properties.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042665 closed AtulOpenbravo Openbravo ERP Deprecated properties usage should be removed in ERP modules 
related to defect 0042666 closed cberner Retail Modules Deprecated properties usage should be removed in retail modules 
related to design defect 0044325 new Triage Platform Base Openbravo ERP Remove columns of deprecated properties and its usage in XSQL/PL 
related to defect 0045029 closed cberner Openbravo ERP Generate deprecated tags for deprecated properties by default 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-31 11:31cbernerNew Issue
2019-12-31 11:31cbernerAssigned To => platform
2019-12-31 11:31cbernerModules => Core
2019-12-31 11:31cbernerTriggers an Emergency Pack => No
2019-12-31 11:50cbernerRelationship addedrelated to 0042666
2019-12-31 11:50cbernerRelationship addedrelated to 0042665
2020-02-17 18:36cbernerAssigned Toplatform => cberner
2020-02-17 18:37cbernerStatusnew => scheduled
2020-02-17 18:37cbernerNote Added: 0117881
2020-06-09 17:57cbernerRelationship addedrelated to 0044325
2020-06-12 10:30hgbotCheckin
2020-06-12 10:30hgbotNote Added: 0120821
2020-06-12 10:30hgbotStatusscheduled => resolved
2020-06-12 10:30hgbotResolutionopen => fixed
2020-06-12 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3ca41f8257dd4fc6fe8851ca67759167bce841b8 [^]
2020-06-12 11:29alostaleReview Assigned To => alostale
2020-06-12 11:29alostaleStatusresolved => closed
2020-06-12 11:29alostaleFixed in Version => 3.0PR20Q3
2020-06-15 13:40alostaleNote Added: 0120849
2020-06-15 13:41alostaleNote Edited: 0120849bug_revision_view_page.php?bugnote_id=0120849#r21189
2020-06-24 14:19hgbotCheckin
2020-06-24 14:19hgbotNote Added: 0121034
2020-06-24 14:59hgbotCheckin
2020-06-24 14:59hgbotNote Added: 0121036
2020-09-10 16:08cbernerRelationship addedrelated to 0045029
2020-10-20 11:40hgbotNote Added: 0123804
2020-10-20 11:40hgbotNote Added: 0123807

Notes
(0117881)
cberner   
2020-02-17 18:37   
Currently tracked in this MR: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/45 [^]
(0120821)
hgbot   
2020-06-12 10:30   
Repository: erp/devel/pi
Changeset: 3ca41f8257dd4fc6fe8851ca67759167bce841b8
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Tue Feb 25 11:01:08 2020 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3ca41f8257dd4fc6fe8851ca67759167bce841b8 [^]

Fixes ISSUE-42664: Remove usage of deprecated properties in platform modules

Usage of deprecated properties is removed from core with some other
methods that were only strictly used by those deprecated methods or
properties.
Property deprecation is not set as default, so some SupressWarnings
will be added in future to address the remaining deprecation eclipse warnings.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/AttachImplementationManager.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/attachment/DefaultsAttachmentActionHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
M src-db/database/sourcedata/AD_COLUMN.xml
M src-test/src/org/openbravo/test/model/ClassLoaderTest.java
M src/org/openbravo/erpCommon/security/SessionLogin.java
---
(0120849)
alostale   
2020-06-15 13:40   
(edited on: 2020-06-15 13:41)
The following commit has is linked with an incorrect issue, it should be related to this one:

Repository: erp/devel/pi
Changeset: 62bb2d63402defd531020093f5e2e6d8a0dee4c5
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jun 15 13:28:58 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/62bb2d63402defd531020093f5e2e6d8a0dee4c5 [^] [^]

related to ISSUE-44249: reverted part of the original commit

Reverting restriction in ClassLoaderTest querying for ad_model_object.
Although the original patch was correct, it made to fail some test in an
obsolte module.

Reverting this part now unitl the failing module gets fixed so that the
change can be re-applied again.

---
M src-test/src/org/openbravo/test/model/ClassLoaderTest.java
---
(0121034)
hgbot   
2020-06-24 14:19   
Repository: erp/mods/org.openbravo.obbo
Changeset: 833f854b2d42b6dee2b441cbd085818151c1bb37
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Jun 18 18:31:54 2020 +0200
URL: http://code.openbravo.com/erp/mods/org.openbravo.obbo/rev/833f854b2d42b6dee2b441cbd085818151c1bb37 [^]

Related to ISSUE-42664: Remove Model Implementations without java class

ClassLoaderTest had recently removed the usage of deprecated Tab
property, as a side effect, some AD_MODEL_OBJECT have been found
in this module without a java class implementation.

Those records have been removed from AD_MODEL_OBJECT as they are not
useful nor implemented.

---
M src-db/database/sourcedata/AD_MODEL_OBJECT.xml
M src-db/database/sourcedata/AD_MODEL_OBJECT_MAPPING.xml
---
(0121036)
hgbot   
2020-06-24 14:59   
Repository: erp/devel/pi
Changeset: fef95dbc12f82f3a5493f13ef8c8a885c75c55c1
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Wed Jun 24 14:57:29 2020 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/fef95dbc12f82f3a5493f13ef8c8a885c75c55c1 [^]

Related to ISSUE-42664: Recover backed out ClassLoaderTest change

This removes usage of Deprecated property
"ModelImplementation.PROPERTY_TAB" in ClassLoaderTest class, it was
backed out because of a module test failing, this was fixed, so it is
reintroduced

---
M src-test/src/org/openbravo/test/model/ClassLoaderTest.java
---
(0123804)
hgbot   
2020-10-20 11:40   
Repository: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.client.analytics [^]
Changeset: 395c5e4072e9885d0cd53d445366b0c84c0e7a0f
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 2020-10-20T09:27:08+02:00
URL: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.client.analytics/-/commit/395c5e4072e9885d0cd53d445366b0c84c0e7a0f [^]

Related to ISSUE-42664: Suppress warning of deprecation on old properties

---
M src/org/openbravo/client/analytics/mondrian/Mondrian4SchemaGenerator.java
---
(0123807)
hgbot   
2020-10-20 11:40   
Merge request merged: https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.client.analytics/-/merge_requests/2 [^]