Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042622Retail ModulesDiscounts and Promotionspublic2019-12-20 11:022019-12-23 12:35
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4.1Fixed in VersionRR19Q4.1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042622: OBPOS_PreApplyAutomaticDiscount not being executed
DescriptionOBPOS_PreApplyAutomaticDiscount not being executed with the new discounts engine
Steps To Reproduce- Put a breakpoint in OBPOS_PreApplyAutomaticDiscount
- Add GPS Handeld product (has an automatic discount)

You will see it is not being executed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0042617 closed jorge-garcia OBPOS_PreApplyAutomaticDiscount not being executed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-20 13:53jorge-garciaTypedefect => backport
2019-12-20 13:53jorge-garciaTarget Version => RR19Q4.1
2019-12-23 10:15hgbotCheckin
2019-12-23 10:15hgbotNote Added: 0116478
2019-12-23 10:15hgbotStatusscheduled => resolved
2019-12-23 10:15hgbotResolutionopen => fixed
2019-12-23 10:15hgbotFixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR19Q4.1/org.openbravo.retail.posterminal/rev/0b75af61acfe8e4e51b4b30dc094ba47abb80812 [^]
2019-12-23 10:16jorge-garciaNote Added: 0116479
2019-12-23 12:35guilleaerReview Assigned To => guilleaer
2019-12-23 12:35guilleaerStatusresolved => closed
2019-12-23 12:35guilleaerFixed in Version => RR19Q4.1

Notes
(0116478)
hgbot   
2019-12-23 10:15   
Repository: retail/backports/3.0RR19Q4.1/org.openbravo.retail.posterminal
Changeset: 0b75af61acfe8e4e51b4b30dc094ba47abb80812
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Dec 23 10:15:09 2019 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4.1/org.openbravo.retail.posterminal/rev/0b75af61acfe8e4e51b4b30dc094ba47abb80812 [^]

Fixed issue 42622: A new hook OBPOS_PreApplyNewDiscountEngine has been defined
to be able to change rule list.

This new hook CANNOT be asynchronous and should not affect to receipt argument.

Old OBPOS_PreApplyAutomaticDiscount register hook should be adapted and use
OBPOS_PreApplyNewDiscountEngine instead.

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
---
(0116479)
jorge-garcia   
2019-12-23 10:16   
Register new hook in wiki

http://wiki.openbravo.com/wiki/List_of_Hooks_in_Web_POS#Hooks_in_Posterminal_and_Mobile_Core [^]