Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042617Retail ModulesDiscounts and Promotionspublic2019-12-20 11:022019-12-23 09:38
Reporterguillermogil 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerGold
Support ticket
Regression levelPre packaging ( pi )
Regression date
Regression introduced in releaseRR19Q4
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042617: OBPOS_PreApplyAutomaticDiscount not being executed
DescriptionOBPOS_PreApplyAutomaticDiscount not being executed with the new discounts engine
Steps To Reproduce- Put a breakpoint in OBPOS_PreApplyAutomaticDiscount
- Add GPS Handeld product (has an automatic discount)

You will see it is not being executed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0042622RR19Q4.1 closed jorge-garcia OBPOS_PreApplyAutomaticDiscount not being executed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-20 11:02guillermogilNew Issue
2019-12-20 11:02guillermogilAssigned To => Retail
2019-12-20 11:02guillermogilOBNetwork customer => Gold
2019-12-20 11:02guillermogilRegression level => Pre packaging ( pi )
2019-12-20 11:02guillermogilTriggers an Emergency Pack => No
2019-12-20 11:14jorge-garciaAssigned ToRetail => jorge-garcia
2019-12-20 11:21jorge-garciaStatusnew => scheduled
2019-12-20 12:38marvintmResolution time => 1578610800
2019-12-20 13:53jorge-garciaNote Added: 0116469
2019-12-20 13:53jorge-garciaStatusscheduled => acknowledged
2019-12-20 13:53jorge-garciaStatusacknowledged => scheduled
2019-12-23 08:34hgbotCheckin
2019-12-23 08:34hgbotNote Added: 0116476
2019-12-23 08:34hgbotStatusscheduled => resolved
2019-12-23 08:34hgbotResolutionopen => fixed
2019-12-23 08:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99e208da461d45674df9426e6bc04e4651bd3de5 [^]
2019-12-23 08:53jorge-garciaNote Added: 0116477
2019-12-23 09:18guilleaerReview Assigned To => guilleaer
2019-12-23 09:18guilleaerStatusresolved => closed
2019-12-23 09:18guilleaerFixed in Version => RR20Q1
2019-12-23 09:38guilleaerRegression introduced in release => RR19Q4

Notes
(0116469)
jorge-garcia   
2019-12-20 13:53   
Reopen to create backports
(0116476)
hgbot   
2019-12-23 08:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 99e208da461d45674df9426e6bc04e4651bd3de5
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Dec 20 13:41:51 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/99e208da461d45674df9426e6bc04e4651bd3de5 [^]

Fixed issue 42617: A new hook OBPOS_PreApplyNewDiscountEngine has been defined
to be able to change rule list.

This new hook CANNOT be asynchronous and should not affect to receipt argument.

Old OBPOS_PreApplyAutomaticDiscount register hook should be adapted and use
OBPOS_PreApplyNewDiscountEngine instead.

---
M web/org.openbravo.retail.posterminal/js/discountsengine/pos/pos-discounts.js
---
(0116477)
jorge-garcia   
2019-12-23 08:53   
New hook defined in documentation:

http://wiki.openbravo.com/wiki/List_of_Hooks_in_Web_POS#Hooks_in_Posterminal_and_Mobile_Core [^]