Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042614Openbravo ERP02. Master data managementpublic2019-11-28 10:202019-12-23 16:41
Reportermaite 
Assigned Toalostale 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR19Q4.1Fixed in Version3.0PR19Q4.1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket13259
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042614: Record is added in Organization tab in an Inactive Discounts and Promotion record, but it is lost when refreshing window
DescriptionWeird behaviour found in Discounts and Promotions window: in case of having an Inactive Discounts and Promotions record user will be able to add new data in Organization tab. But when refreshing the tab the data will be removed from inactive discount and will be added to another active discount
Steps To Reproduce1. Access Discounts and Promotions window, create new record named "first discount" with any valid date and
2. Create another record named "second discount" with any valid date and set it as INACTIVE
3. Go to Organization tab of this "second discount" and create new record, set "F&B España, S.A" organization and save
4. Refresh the Organization tab and realize that record has been removed
5. Go to "first discount" and verify that "F&B España, S.A" has been added to its Organization tab
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0042429 closed alostale Record is added in Organization tab in an Inactive Discounts and Promotion record, but it is lost when refreshing window 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-20 08:55alostaleTypedefect => backport
2019-12-20 08:55alostaleTarget Version => 3.0PR19Q4.1
2019-12-20 09:13hgbotCheckin
2019-12-20 09:13hgbotNote Added: 0116454
2019-12-20 09:13hgbotStatusscheduled => resolved
2019-12-20 09:13hgbotResolutionopen => fixed
2019-12-20 09:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/e8bc37990836742d002f7f70bdad65bbaaeffa1a [^] => http://code.openbravo.com/erp/backports/3.0PR19Q4.1/rev/7a648e0c57d338e75275c830d3f793ddd1b963b8 [^]
2019-12-20 09:14alostaleSeveritymajor => critical
2019-12-23 16:41caristuNote Added: 0116486
2019-12-23 16:41caristuStatusresolved => closed
2019-12-23 16:41caristuFixed in Version => 3.0PR19Q4.1

Notes
(0116454)
hgbot   
2019-12-20 09:13   
Repository: erp/backports/3.0PR19Q4.1
Changeset: 7a648e0c57d338e75275c830d3f793ddd1b963b8
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Dec 04 16:04:05 2019 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR19Q4.1/rev/7a648e0c57d338e75275c830d3f793ddd1b963b8 [^]

fixed BUG-42614: Discount Organization can add rows to incorrect header

  If parent Discount header is inactive, when adding rows to Organization tab,
  they were added to the first active Discount instead of to the proper parent.

  This was caused because M_Offer_Organization.AD_Org_ID column is used to store
  the organization the discount is applicable for instead of just row's organization.

  AD_Org columns have an special treatment, when they are changed, a
  virtual callout is executed to refresh all combos. Mandatory combos
  take the first available value in case their default is not available,
  which is the case if it is inactive. As M_Offer_ID column had a
  TableDir reference, it was treated as a combo, if its parent was
  inactive, first active record was taken in place.

  A proper solution would be not to use AD_Org_ID column to store the
  actual value but to use instead a new column. This change would be
  much more aggressive being an API change that would require of
  updating existing data. That's why, the problem has been fixed by
  replaciing TableDir reference with Search without selector, in this
  way FK reltionship is preserved, but only the value is used in UI
  instead of creating a combo.

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0116486)
caristu   
2019-12-23 16:41   
Reviewed