Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042611Retail ModulesWeb POSpublic2019-12-19 13:102020-02-24 09:59
Reportersanti_lozano 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q2 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042611: Web POS receipt not scrolling down after adding a product in some situations
DescriptionIn Web POS when you add a new product to the receipt, it is the selected one and you can see all its details on the screen as the scroll-down bar has completely gone to the last part of the receipt. But given some situations it is not like that, it doesn’t do a complete scroll-down. In livebuilds you can easily see it as explained on steps to reproduce, when the taxes part of the screen has some taxes and it is bigger (see livebuilds.png image here attached). Customer reports it on a 19Q3.2, it happens with products that have automatic discounts (normal discounts that make the line of the product be bigger, see customer.png image).

Issue reproducible only in old discounts engine
Steps To Reproduce* Go to Openbravo livebuilds, section Retail with translations for example and click on webpos link (enter with credentials vallblanca / openbravo)
* add 4 products to the ticket, with normal tax (Entregas IVA 21%) (Example: Avalanche Transceiver, Balaclava Cap, Hiking Boots, Baby Carrier)
* add Car Seat to the ticket (it adds a new tax, exempt)
* add Mountain Pack to the ticket (it adds more taxes and you can see the problem reproduced as in the image)
Proposed Solution
Additional Information
Tagsscroll
Relationships
related to defect 0037416RR18Q1.1 closed gorka_gil Performance of scrollable table is not good 
related to defect 0047635 closed ranjith_qualiantech_com The focus is not placed on the added line when there are many products on the receipt 
Attached Filespng livebuilds.png (272,310) 2019-12-19 13:13
https://issues.openbravo.com/file_download.php?file_id=13698&type=bug
png customer.png (69,782) 2019-12-19 13:13
https://issues.openbravo.com/file_download.php?file_id=13699&type=bug
png

patch issue 42611 19Q3.2 source posterminal.patch (794) 2020-01-06 07:12
https://issues.openbravo.com/file_download.php?file_id=13754&type=bug
patch issue 42611 source posterminal.patch (782) 2020-01-06 07:23
https://issues.openbravo.com/file_download.php?file_id=13755&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-12-19 13:10santi_lozanoNew Issue
2019-12-19 13:10santi_lozanoAssigned To => Retail
2019-12-19 13:10santi_lozanoFile Added: livebuilds.png
2019-12-19 13:10santi_lozanoResolution time => 1578524400
2019-12-19 13:10santi_lozanoTriggers an Emergency Pack => No
2019-12-19 13:13santi_lozanoFile Deleted: livebuilds.png
2019-12-19 13:13santi_lozanoFile Added: livebuilds.png
2019-12-19 13:13santi_lozanoFile Added: customer.png
2019-12-19 13:16santi_lozanoNote Added: 0116430
2019-12-19 13:16santi_lozanoTag Attached: scroll
2019-12-19 13:20santi_lozanoDescription Updatedbug_revision_view_page.php?rev_id=19944#r19944
2019-12-19 13:23PracticsIssue Monitored: Practics
2019-12-26 15:03ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-12-27 06:40ranjith_qualiantech_comStatusnew => scheduled
2020-01-06 07:12ranjith_qualiantech_comFile Added: issue 42611 19Q3.2 source posterminal.patch
2020-01-06 07:23ranjith_qualiantech_comFile Added: issue 42611 source posterminal.patch
2020-01-07 15:12hgbotCheckin
2020-01-07 15:12hgbotNote Added: 0116670
2020-01-07 15:12hgbotStatusscheduled => resolved
2020-01-07 15:12hgbotResolutionopen => fixed
2020-01-07 15:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e66f9402a17c0ba8219a271ab43c4ca49e9b813a [^]
2020-01-14 17:55marvintmReview Assigned To => marvintm
2020-01-14 17:55marvintmStatusresolved => closed
2020-01-14 17:55marvintmFixed in Version => RR20Q2
2020-01-27 07:18ranjith_qualiantech_comNote Added: 0117246
2020-01-27 07:18ranjith_qualiantech_comStatusclosed => new
2020-01-27 07:18ranjith_qualiantech_comResolutionfixed => open
2020-01-27 07:18ranjith_qualiantech_comFixed in VersionRR20Q2 =>
2020-01-27 07:18ranjith_qualiantech_comStatusnew => scheduled
2020-01-27 07:32hgbotCheckin
2020-01-27 07:32hgbotNote Added: 0117247
2020-01-27 07:32hgbotStatusscheduled => resolved
2020-01-27 07:32hgbotResolutionopen => fixed
2020-01-27 07:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e66f9402a17c0ba8219a271ab43c4ca49e9b813a [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c531255e4b5d3a154652a3cd3bab984251df1889 [^]
2020-01-27 09:15guilleaerReview Assigned Tomarvintm => guilleaer
2020-01-27 09:15guilleaerStatusresolved => closed
2020-01-27 09:15guilleaerFixed in Version => RR20Q2
2020-01-31 13:47ranjith_qualiantech_comDescription Updatedbug_revision_view_page.php?rev_id=20270#r20270
2020-01-31 13:47ranjith_qualiantech_comNote Edited: 0117246bug_revision_view_page.php?bugnote_id=0117246#r20272
2020-02-18 14:34ranjith_qualiantech_comRelationship addedrelated to 0037416
2020-02-18 14:39ranjith_qualiantech_comNote Added: 0117916
2020-02-18 14:39ranjith_qualiantech_comStatusclosed => new
2020-02-18 14:39ranjith_qualiantech_comResolutionfixed => open
2020-02-18 14:39ranjith_qualiantech_comFixed in VersionRR20Q2 =>
2020-02-18 15:02ranjith_qualiantech_comStatusnew => scheduled
2020-02-20 11:31hgbotCheckin
2020-02-20 11:31hgbotNote Added: 0117965
2020-02-20 11:31hgbotCheckin
2020-02-20 11:31hgbotNote Added: 0117966
2020-02-20 11:31hgbotStatusscheduled => resolved
2020-02-20 11:31hgbotResolutionopen => fixed
2020-02-20 11:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c531255e4b5d3a154652a3cd3bab984251df1889 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/366dd30fd6647ddc7de62cc6a36ae5a5292bc8c5 [^]
2020-02-24 09:59guilleaerStatusresolved => closed
2020-02-24 09:59guilleaerFixed in Version => RR20Q2
2021-09-07 11:24ranjith_qualiantech_comRelationship addedrelated to 0047635

Notes
(0116430)
santi_lozano   
2019-12-19 13:16   
I add here that there are 2 issues from 2018 (38586 and 38796) related with scroll which I think are the same and that they are not happening in latest versions of Openbravo (you could close them, their status is scheduled and new respectively)
(0116670)
hgbot   
2020-01-07 15:12   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e66f9402a17c0ba8219a271ab43c4ca49e9b813a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 07 19:42:41 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e66f9402a17c0ba8219a271ab43c4ca49e9b813a [^]

Fixed issue 42611 : Receipt lines table scroll should be updated after receipt taxes is added

---
M web/org.openbravo.retail.posterminal/js/components/order.js
---
(0117246)
ranjith_qualiantech_com   
2020-01-27 07:18   
(edited on: 2020-01-31 13:47)
Issue is still reproducible in following case
1) Add Any 7 products (without automatic discounts)
2) Apply manual discount for 6th product
3) Increase 7th Product by "+" button

Scroll position is not updated for the 7th product
Issue reproducible only in old discounts engine
(0117247)
hgbot   
2020-01-27 07:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c531255e4b5d3a154652a3cd3bab984251df1889
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Jan 27 12:02:35 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c531255e4b5d3a154652a3cd3bab984251df1889 [^]

Fixed issue 42611 : Receipt line promotion should be reset when calculating receipt

* When discount calculation started, receipt line promotions should be reset with silent
  because line change will trigger the re-render of the line which cause the scroll position alignment

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---
(0117916)
ranjith_qualiantech_com   
2020-02-18 14:39   
Issue is still reproducible
In POS
1) Add all products from Best Sellers Category
2) Add "Bottle 1 L" with 2 qty
3) Apply Manual Discount "-- disc_5_ var_perc - 5 %" for all lines
4) Click on Last Receipt Line ("Bottle 1 L")
5) Click on '+' button in keyboard
Scroll position is not updated.
Expected Result: Scroll position should be placed bottom
(0117965)
hgbot   
2020-02-20 11:31   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: ffee5f4d0d91d088e4cbfa5edbaf4ec9884d9395
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 20 16:01:12 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/ffee5f4d0d91d088e4cbfa5edbaf4ec9884d9395 [^]

Related to issue 42611 : Added updatedView to ScrollableTable when render completes

---
M web/org.openbravo.mobile.core/source/component/ob-scrollabletable.js
---
(0117966)
hgbot   
2020-02-20 11:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 366dd30fd6647ddc7de62cc6a36ae5a5292bc8c5
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Feb 20 16:01:19 2020 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/366dd30fd6647ddc7de62cc6a36ae5a5292bc8c5 [^]

Fixed issue 42611 : Receipt lines table scroll should be updated when render finished

* Backed out changeset: e66f9402a17c
* Backed out changeset: c531255e4b5d

---
M web/org.openbravo.retail.posterminal/js/components/order.js
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---