0042603: If a payment is modified in OBPOS_postAddPayment and the POS is refreshed (F5) that change is lost

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042603

Retail Modules

Web POS

public

2019-12-18 18:54

2019-12-20 09:32

Reporter

ngarcia

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR20Q1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Gold

Support ticket

13588

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042603: If a payment is modified in OBPOS_postAddPayment and the POS is refreshed (F5) that change is lost

Description

If a payment is modified in OBPOS_postAddPayment and the POS is refreshed (F5) that change is lost

Steps To Reproduce

In the POS:
   Open the developers tools of the browser
   Add the following code in the console:
      OB.UTIL.HookManager.registerHook('OBPOS_postAddPayment', function(args, callbacks) {
    args.paymentAdded.set('newproperty', true);
    OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});
   Create a new receipt
   Add a payment to it
   Check the 'newproperty' is present in the payment by
      OB.MobileApp.model.receipt.attributes.payments.models[0].attributes
   Push F5
   Check the 'newproperty' is not present in the payment by
      OB.MobileApp.model.receipt.attributes.payments.models[0].attributes
   Complete the receipt and check the JSON is sent without newproperty

Proposed Solution

Change the logic of saving the ticket after the hook:

if (saveChanges && !payment.get('changePayment')) {
   order.adjustPayment();
   order.trigger('displayTotal');
   order.save();
   order.trigger('saveCurrent');
}

Additional Information