Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042556Openbravo ERPA. Platformpublic2019-12-13 14:042019-12-20 09:34
Reporterjarmendariz 
Assigned Tojarmendariz 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042556: Logs older than 30 days are not removed during log rotation
DescriptionUsing the default Openbravo log4j configuration, during rollover log files are limited to max 30 files, but this limitation applies only during a single day. Logs from previous days are not removed and the number of log files can grow indefinitely.
Steps To ReproduceUsing an Openbravo instance with the default log4j configuration that generates log files for more than 30 days, check that there are more than 30 files and older logs are not removed when creating new log files.
Proposed SolutionAdd a <Delete/> rule in log4j-web.xml that determines that files older than 30 days ago should be removed.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0039504 closed jarmendariz Upgrade Log4j to version 2 
depends on backport 00425773.0PR19Q4.1 closed jarmendariz Logs older than 30 days are not removed during log rotation 
depends on backport 00425783.0PR19Q3.3 closed jarmendariz Logs older than 30 days are not removed during log rotation 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-13 14:04jarmendarizNew Issue
2019-12-13 14:04jarmendarizAssigned To => jarmendariz
2019-12-13 14:04jarmendarizModules => Core
2019-12-13 14:04jarmendarizTriggers an Emergency Pack => No
2019-12-16 10:50jarmendarizRelationship addedrelated to 0039504
2019-12-16 17:07jarmendarizReview Assigned To => alostale
2019-12-17 08:46alostaleReview Assigned Toalostale => AugustoMauch
2019-12-17 08:47alostaleStatusnew => scheduled
2019-12-17 09:11alostaleNote Added: 0116368
2019-12-18 12:27hgbotCheckin
2019-12-18 12:27hgbotNote Added: 0116405
2019-12-18 12:27hgbotStatusscheduled => resolved
2019-12-18 12:27hgbotResolutionopen => fixed
2019-12-18 12:27hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ba35b5274a4a1999a7c160e3dccd5a21f00f6d2d [^]
2019-12-19 13:29AugustoMauchNote Added: 0116434
2019-12-19 13:29AugustoMauchStatusresolved => closed
2019-12-20 09:34alostaleSeveritymajor => critical

Notes
(0116368)
alostale   
2019-12-17 09:11   
https://gitlab.com/openbravo/product/openbravo/merge_requests/27 [^]
(0116405)
hgbot   
2019-12-18 12:27   
Repository: erp/devel/pi
Changeset: ba35b5274a4a1999a7c160e3dccd5a21f00f6d2d
Author: Javi Armendáriz <katanagari <at> gmail.com>
Date: Fri Dec 13 14:48:25 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ba35b5274a4a1999a7c160e3dccd5a21f00f6d2d [^]

Fixed BUG-42556: Adding remove log archive policy to prevent indefinite growth.

Using current log4j config, only files under the same period of time are limited
(i.e. when logfile is bigger than 100MB, there can be max 30 log archives for the
same day).

The new rule added applies to log archives with the format openbravo-*.log.gz and
will remove the oldest archive until there are max 30 files. This process will be
performed every time a log rollover occurs.

This commit also adds a build validation step that overrides the current config
with the updated one _only_ if its a exact copy of the previous default config.

---
M config/log4j2-web.xml.template
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CopyLog4jConfigurationFromTemplates.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/CopyLog4jConfigurationFromTemplates.java
---
(0116434)
AugustoMauch   
2019-12-19 13:29   
Code reviewed and verified