Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042510Retail ModulesOffline Modepublic2019-12-11 09:292019-12-24 11:50
Reportermalsasua 
Assigned Tomigueldejuana 
PriorityurgentSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket13619
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042510: with inestable network, the login offline is not working
Descriptionwhen the network is not stable and some requests are responding but other requests are not responding the login offline is not working
Steps To Reproduce1. open console developers tools
2. add a breakpoint in function attemptToLoginOffline
3. switch off the network
4. do login -> code is stopped in breakpoint 2
5. swith on the network
6. continue the execution of code
-> the login offline is done but few seconds later a new popup is displayed:
Online

The connection was restored. However, in the meantime, your session timed out. You must login again now to ensure proper synchronization. Your pending tickets will be saved.
7. login window is displayed again
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0042571RR19Q4.1 closed migueldejuana with inestable network, the login offline is not working 
depends on backport 0042572RR19Q3.2 closed migueldejuana with inestable network, the login offline is not working 
Attached Filesdiff keepWorking18Q1.diff (8,603) 2019-12-24 11:50
https://issues.openbravo.com/file_download.php?file_id=13721&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-12-11 09:29malsasuaNew Issue
2019-12-11 09:29malsasuaAssigned To => Retail
2019-12-11 09:29malsasuaOBNetwork customer => Gold
2019-12-11 09:29malsasuaTriggers an Emergency Pack => No
2019-12-11 09:33malsasuaSupport ticket => 13619
2019-12-11 09:33malsasuaResolution time => 1577919600
2019-12-12 10:34malsasuaResolution time1577919600 => 1576450800
2019-12-12 10:34malsasuaPrioritynormal => urgent
2019-12-12 10:34malsasuaSeveritymajor => critical
2019-12-12 10:34malsasuaReproducibilityhave not tried => always
2019-12-16 15:24marvintmAssigned ToRetail => migueldejuana
2019-12-16 15:24marvintmStatusnew => scheduled
2019-12-16 16:43migueldejuanaFile Added: issue42510.diff
2019-12-18 07:02hgbotCheckin
2019-12-18 07:02hgbotNote Added: 0116387
2019-12-18 07:02hgbotStatusscheduled => resolved
2019-12-18 07:02hgbotResolutionopen => fixed
2019-12-18 07:02hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d5f72bed6f9261be3e7c1ed6ed35f17dcfdcadbd [^]
2019-12-18 07:03hgbotCheckin
2019-12-18 07:03hgbotNote Added: 0116388
2019-12-18 07:03hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d5f72bed6f9261be3e7c1ed6ed35f17dcfdcadbd [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/ee088b3e5cdb5ed95586a0f341cab7e6405cfbab [^]
2019-12-18 07:03hgbotCheckin
2019-12-18 07:03hgbotNote Added: 0116389
2019-12-18 07:03hgbotFixed in SCM revisionhttp://code.openbravo.com/tools/automation/pi-mobile/rev/ee088b3e5cdb5ed95586a0f341cab7e6405cfbab [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/2891c6f22f9a02a92b54c72d56d191c138649542 [^]
2019-12-18 13:10egoitzIssue Monitored: egoitz
2019-12-19 14:27maiteIssue Monitored: networkb
2019-12-19 14:49LeyreIssue Monitored: Leyre
2019-12-20 09:53marvintmReview Assigned To => marvintm
2019-12-20 09:53marvintmStatusresolved => closed
2019-12-20 09:53marvintmFixed in Version => RR20Q1
2019-12-24 11:50migueldejuanaFile Deleted: issue42510.diff
2019-12-24 11:50migueldejuanaFile Added: keepWorking18Q1.diff

Notes
(0116387)
hgbot   
2019-12-18 07:02   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d5f72bed6f9261be3e7c1ed6ed35f17dcfdcadbd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Mon Dec 16 16:40:33 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d5f72bed6f9261be3e7c1ed6ed35f17dcfdcadbd [^]

Fixed issue 0042510: with inestable network, the login offline is not working

- Centralize Modal of backend session lost in OB.UI.ModalOnline component
- When backend session is lost:
  * Show a message a bit more clear
  * Add a button to be able to Keep Working
- After pressing Keep Working, show lost session popup only after final reconnect cycle or after fast 5 seconds reconnect

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.mobile.core/source/component/dialog/ob-modalonline.js
M web/org.openbravo.mobile.core/source/component/legacy/ob-legacy.js
M web/org.openbravo.mobile.core/source/component/ob-terminal-component.js
M web/org.openbravo.mobile.core/source/data/ob-requestrouter.js
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0116388)
hgbot   
2019-12-18 07:03   
Repository: tools/automation/pi-mobile
Changeset: ee088b3e5cdb5ed95586a0f341cab7e6405cfbab
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Dec 17 13:50:44 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ee088b3e5cdb5ed95586a0f341cab7e6405cfbab [^]

Fixed issue 0042510: with inestable network, the login offline is not working

- Adapt tests to new popup

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/selenium/TestIdCore.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/terminals/WebPOSTerminalHelper.java
---
(0116389)
hgbot   
2019-12-18 07:03   
Repository: tools/automation/pi-mobile
Changeset: 2891c6f22f9a02a92b54c72d56d191c138649542
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Dec 17 19:29:02 2019 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2891c6f22f9a02a92b54c72d56d191c138649542 [^]

Fixed issue 0042510: with inestable network, the login offline is not working

- Adapt tests to new popup

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/LoginOfflineCashmanagement.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/LoginOfflineCashmanagementWaitNoForce.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/LoginOfflineCashup.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/LoginOfflineCreateBP.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/LoginOfflineSimplesale.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/VerifyCustomerSearchKeySequenceOffline.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/VerifyOfflineModeNoForce.java
---