0042490: Discount and Promtions with Coupon doesn't show a message is you apply a coupon out of date range

Openbravo Issue Tracking System - Retail Modules
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0042490	Retail Modules	Discounts and Promotions	public	2019-12-09 13:40	2020-09-04 07:23

Reporter	francisco
Assigned To	ranjith_qualiantech_com
Priority	normal	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0042490: Discount and Promtions with Coupon doesn't show a message is you apply a coupon out of date range
Description	If you apply a coupon out of date range the POs does not show any message, it should warn about the coupon is not valid
Steps To Reproduce	Tested in retail_modules-psql_pi: In backoffice go to Discount and promotions and select the promo 'Coupon 10' and set an expired date Starting date= 01/01/2014, Ending Date=31/12/2014 Go to POS Go to menu Coupon code enter 'Coupon10' Insert the product 'AVALANCHE TRANSCEIVER' The promo is not applied but it should show a message warning us that the dates for the coupon has expired
Proposed Solution	It is difficult to fix the underlying problem in general, because only by executing the discounts engine we will know for sure if a discount can be applied or not. However, we can at least add a basic filter in the remote request done to load a Coupon information, so that if the discount associated with it has an expiration date that doesn't comply with the current date, it can be immediately rejected at that point. As part of this issue we will only fix this case. Other more complex cases (like discounts associated with specific customers or products) should be considered a feature request.
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2019-12-09 13:40	francisco	New Issue
2019-12-09 13:40	francisco	Assigned To	=> Retail
2019-12-09 13:40	francisco	Triggers an Emergency Pack	=> No
2020-08-24 13:58	marvintm	Proposed Solution updated
2020-08-24 13:58	marvintm	Type	feature request => defect
2020-08-24 13:58	marvintm	Proposed Solution updated
2020-09-02 07:10	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2020-09-03 04:47	ranjith_qualiantech_com	Status	new => scheduled
2020-09-04 04:51	hgbot	Note Added: 0122623
2020-09-04 07:23	hgbot	Note Added: 0122630
2020-09-04 07:23	hgbot	Resolution	open => fixed
2020-09-04 07:23	hgbot	Status	scheduled => closed
2020-09-04 07:23	hgbot	Note Added: 0122631

Notes