0042475: Openbravo JS minimizer does not work well with template literals

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042475

Openbravo ERP

A. Platform

public

2019-12-04 14:34

2020-01-10 08:14

Reporter

adrianromero

Assigned To

alostale

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0PR20Q2

Merge Request Status

Review Assigned To

caristu

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042475: Openbravo JS minimizer does not work well with template literals

Description

Template literals are incorrectly minimized. For example:

      const body = `<?xml version="1.0" encoding="utf-8" ?>
      <s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"> [^]
      <s:Body>
      <printerFiscalReport>
      <printXReport/>
      </printerFiscalReport>
      </s:Body>
      </s:Envelope>`;

Is transformed into

const body = `<?xml version="1.0"encoding="utf-8"?><s:Envelope xmlns:s="http://schemas.xmlsoap.org/soap/envelope/"><s:Body><printerFiscalReport><printXReport/></printerFiscalReport></s:Body></s:Envelope> [^]`;

Note returns are removed and the most important the space between version="1.0" encoding="utf-8" is removed too and this raises an error in the XML parser.

Steps To Reproduce

In description

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0041093		closed	jarmendariz	JS static resources are not correctly minimized
causes	defect	0048070		closed	platform	OOM compressing JS with certain regexp