Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042471Retail ModulesWeb POSpublic2019-12-04 08:542019-12-12 11:21
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042471: API change: ability to set payment type column to empty
DescriptionAPI change generated because of issue:

https://issues.openbravo.com/view.php?id=42382 [^]

New type of Payment Providers previously required the "payment type" column to be always set. This column was used to specify the payment method (so, for example "Visa", or "Mastercard") that was used to pay.

However, as we now intend to remove old Payment Providers and replace them by the new type, we need to have the ability to set this column to null as in some cases, Payment Providers do not work as a group, as the device cannot specify which payment method was used. This forces us to change the existing check constraint, which is detected as an API change.
Steps To Reproduce.
Proposed Solution
Additional Information
TagsApproved
Relationships
related to defect 0042382 closed ranjith_qualiantech_com 'Payment Method Type' field should be able to set as empty when selecting a Payment Group 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-12-04 08:54marvintmNew Issue
2019-12-04 08:54marvintmAssigned To => Retail
2019-12-04 08:54marvintmTriggers an Emergency Pack => No
2019-12-04 08:56marvintmDescription Updatedbug_revision_view_page.php?rev_id=19853#r19853
2019-12-04 08:56marvintmRelationship addedrelated to 0042382
2019-12-04 08:57marvintmDescription Updatedbug_revision_view_page.php?rev_id=19854#r19854
2019-12-04 16:31dmitry_mezentsevTag Attached: Approved
2019-12-05 12:43ranjith_qualiantech_comStatusnew => scheduled
2019-12-05 12:43ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-12-05 12:51hgbotCheckin
2019-12-05 12:51hgbotNote Added: 0116106
2019-12-05 12:51hgbotStatusscheduled => resolved
2019-12-05 12:51hgbotResolutionopen => fixed
2019-12-05 12:51hgbotFixed in SCM revision => http://code.openbravo.com/retail/api-checks-retail/rev/685b75b0f97cd88ead0ae7e113a7b089f8fcd95a [^]
2019-12-05 15:31marvintmReview Assigned To => marvintm
2019-12-05 15:31marvintmStatusresolved => closed
2019-12-05 15:31marvintmFixed in Version => RR20Q1
2019-12-08 13:33hgbotCheckin
2019-12-08 13:33hgbotNote Added: 0116138
2019-12-12 11:21hgbotCheckin
2019-12-12 11:21hgbotNote Added: 0116207

Notes
(0116106)
hgbot   
2019-12-05 12:51   
Repository: retail/api-checks-retail
Changeset: 685b75b0f97cd88ead0ae7e113a7b089f8fcd95a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 05 17:21:14 2019 +0530
URL: http://code.openbravo.com/retail/api-checks-retail/rev/685b75b0f97cd88ead0ae7e113a7b089f8fcd95a [^]

Fixed issue 42471 : Removed Check Constraint for Payment Provider and Payment Method Type

* Payment Method Type allow null values with Payment Provider

---
M java/reference/java.japi.gz
---
(0116138)
hgbot   
2019-12-08 13:33   
Repository: retail/api-checks-retail
Changeset: c2eeaebe37678f86cf7db1f28e01e3f09db14bde
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Sun Dec 08 13:32:53 2019 +0100
URL: http://code.openbravo.com/retail/api-checks-retail/rev/c2eeaebe37678f86cf7db1f28e01e3f09db14bde [^]

Related to issue 42471. Removed corresponding ad_message also

---
M model/modules/org.openbravo.retail.posterminal/src-db/database/sourcedata/AD_MESSAGE.xml
---
(0116207)
hgbot   
2019-12-12 11:21   
Repository: retail/api-checks-retail
Changeset: 639e6350884ab4451f4ee93b6038fbb35531c393
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 12 15:51:12 2019 +0530
URL: http://code.openbravo.com/retail/api-checks-retail/rev/639e6350884ab4451f4ee93b6038fbb35531c393 [^]

Related to issue 42471 : Removed Check Constraint for Payment Provider and Payment Method Type

* Pushing api changes again due to loss of changes in MP release

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.retail.posterminal/src-db/database/sourcedata/AD_MESSAGE.xml
---