Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042421ModulesOrder Confirmationpublic2019-11-27 14:512019-12-02 10:16
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0042421: Exception in Run Order Confirmation process
DescriptionThe Run Order Confirmation process throw an exception when the Business Partner does not belongs to the same Order organization
Steps To ReproduceAs White Valley Group Admin Role
Go to OMS Rule window and create a new record
  Organization: Magento
  Name: LowestShipment
  Create a new record in Criteria tab:
    OMS Algorithm: Lowest number of shipment
  In OMS Rule window and create a new record
    Organization: Magento
    Name: OrderComplete
    Create a new record in Criteria tab:
      OMS Algorithm: Order complete
  In OMS Rule window and create a new record
    Organization: Magento
    Name: Warehouses
    Create a new record in Criteria tab:
      OMS Algorithm: Warehouses by priority"
Go to OMS Configuration window and create a new record:
  Organization: Magento
  Create a new record in Rules tab:
    Rule: LowestShipment
    Partial Allocation Allowed: True
  Create a new record in Rules tab:
    Rule: OrderComplete
    Partial Allocation Allowed: True
  Create a new record in Rules tab:
    Rule: Warehouses
    Partial Allocation Allowed: True
Go to Sales Order and create a new record:
  Organization: Vall Boi
  Business Partner: VB Customer
  Pos Terminal: Magento
  Update the order throug database with the following query:
    update c_order set c_bpartner_id = '8FF8D0A81C644F7A9A74BE01459482BB', c_bpartner_location_id = '84F713E4EB68424B8040DCCB6B423A38' where c_order_id = <orderId>;
  Check order Business Partner is Magento Customer
  Create a new record in Lines tab:
    Product: Snowboard
    Ordered quantity: 5
  Through database update the previous order created to Not Confirmed status (docstatus = 'NC')
  Reject the order with the Reject action button in sales order window
  Execute the Run Order Confirmation button and check an exception is throw

When the fix of previous error is done
Book the replacement Order created in Run Order Confirmation
Check the Create Shipment from Orders and Create Invoices from Orders process if throw an exception
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0042295RR20Q1 closed aferraz Retail Modules Order Confirmation project 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-11-27 14:51collazoandy4New Issue
2019-11-27 14:51collazoandy4Assigned To => collazoandy4
2019-11-27 14:51collazoandy4OBNetwork customer => No
2019-11-27 22:17collazoandy4Steps to Reproduce Updatedbug_revision_view_page.php?rev_id=19802#r19802
2019-11-27 22:17collazoandy4Statusnew => scheduled
2019-11-27 22:18collazoandy4Note Added: 0115915
2019-11-28 11:55aferrazRelationship addedrelated to 0042295
2019-12-02 10:15hgbotCheckin
2019-12-02 10:15hgbotNote Added: 0116015
2019-12-02 10:15hgbotStatusscheduled => resolved
2019-12-02 10:15hgbotResolutionopen => fixed
2019-12-02 10:15hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2861c11135ddc84a042b01091aa03d55f8cf0591 [^]
2019-12-02 10:16aferrazReview Assigned To => aferraz
2019-12-02 10:16aferrazNote Added: 0116016
2019-12-02 10:16aferrazStatusresolved => closed

Notes
(0115915)
collazoandy4   
2019-11-27 22:18   
Test Plan
  As White Valley Group Admin Role
  Go to OMS Rule window and create a new record
    Organization: Magento
    Name: LowestShipment
    Create a new record in Criteria tab:
      OMS Algorithm: Lowest number of shipment
    In OMS Rule window and create a new record
      Organization: Magento
      Name: OrderComplete
      Create a new record in Criteria tab:
        OMS Algorithm: Order complete
    In OMS Rule window and create a new record
      Organization: Magento
      Name: Warehouses
      Create a new record in Criteria tab:
        OMS Algorithm: Warehouses by priority"
  Go to OMS Configuration window and create a new record:
    Organization: Magento
    Create a new record in Rules tab:
      Rule: LowestShipment
      Partial Allocation Allowed: True
    Create a new record in Rules tab:
      Rule: OrderComplete
      Partial Allocation Allowed: True
    Create a new record in Rules tab:
      Rule: Warehouses
      Partial Allocation Allowed: True
  Go to Sales Order and create a new record:
    Organization: Vall Boi
    Business Partner: VB Customer
    Pos Terminal: Magento
    Update the order throug database with the following query:
      update c_order set c_bpartner_id = '8FF8D0A81C644F7A9A74BE01459482BB', c_bpartner_location_id = '84F713E4EB68424B8040DCCB6B423A38' where c_order_id = <orderId>;
    Check order Business Partner is Magento Customer
    Create a new record in Lines tab:
      Product: Snowboard
      Ordered quantity: 5
  Through database update the previous order created to Not Confirmed status (docstatus = 'NC')
  Reject the order with the Reject action button in sales order window
  Execute the Run Order Confirmation button and check the previous order is closed
  Go to Replacement Orders tab and navigate to the new order created and check:
    Organization: Orhi Store
    BP: Magento Customer
    Book the order
  Go to Create Invoices from Orders Process and select the replacement order created in Orhi store
  Clic on Process button and check a new Sales Invoice is created with:
    Organization: Orhi Store
    BP: Magento Customer
    Document status: Completed
  Go to Create Shipments from Orders and select the replacement order created in Orhi store
  Clic on Process button and check a new Goods Shipment is created with:
    Organization: Orhi Store
    BP: Magento Customer
    Document status: Completed

Test Plan II
 Repeat the previous test plan but create the invoice with Generate Invoices process
(0116015)
hgbot   
2019-12-02 10:15   
Repository: erp/devel/pi
Changeset: 2861c11135ddc84a042b01091aa03d55f8cf0591
Author: Álvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Mon Dec 02 10:14:23 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/2861c11135ddc84a042b01091aa03d55f8cf0591 [^]

Fixes BUG-42421: Exception in Run Order Confirmation process

The Run Order Confirmation process throw an exception when the Business Partner
does not belongs to the same Order organization

The check was updated to take into account the transaction organization.

---
M src-db/database/model/functions/C_INVOICE_POST.xml
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0116016)
aferraz   
2019-12-02 10:16   
Code review OK