0042309: [19Q4] Gift discount amount is duplicated when splitting a multiple quantity gift item into lines

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042309

Retail Modules

Discounts and Promotions

public

2019-10-31 17:26

2019-11-28 17:24

Reporter

inaki_garcia

Assigned To

ranjith_qualiantech_com

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

RR19Q4

Fixed in Version

RR19Q4

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

main

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042309: [19Q4] Gift discount amount is duplicated when splitting a multiple quantity gift item into lines

Description

When creating a ticket with a product group eligible for a "Buy X and pay Y as gift", and splitting the gift product set to 2 or more units and splitting it into two or more lines with the "Split lines" feature, the description item with the discount that appears in the original is duplicated to the other line(s), and does affect the overall cost of the ticket (effectively duplicating the discount value for the gift product group). This is better described in the steps to reproduce and in the screenshot attachment below.

This is a regression introduced in the current version (19Q4), as it is not reproducible in 19Q3 and versions prior to it.

Steps To Reproduce

PRECONDITION: the "Discounts and Promotions" module must be installed

-- In the Backend (ERP)
0. Log in ERP as Group -Admin-The White Valley Group
1. Go to Discounts and Promotions window
2. Create new record
- Header tab
   * Discount type: Buy X and pay Y as gift
   * Name: Free Wax
   * Starting date: today's date
   * Included Products: Only those defined
  - Products subtab
    Record 1
   * Product: All mountain ski board
   * Quantity: 1
    Record 2
   * Product: Ski wax
   * Gift product: checked
   * Gift quantity: 2

-- In the Web POS
0. Log in the POS as user "vallblanca"
1. Add 1 unit of "All mountain ski board"
2. Add 2 units of "Ski wax"
NOTICE that the 2 units of Ski wax are correctly discounted, as shown in the attached picture, "gift-items-correctly-discounted.png"
3. Click on the newly created ticket line, and click on the "Split" option in the line description pane. Click "Apply" button in the "Split" popup that appears.
NOTICE the original line discount is duplicated in the second line, in spite of having decreased in one unit per line. There's no recalculation of the discounts, and the original discount amount is duplicated and reflected in the total amount of the ticket (check the attached picture: "gift-items-discount-duplicated.png")

Proposed Solution

Additional Information