0042291: Incorrect price is discounted when combining rules which gift full units

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042291

Retail Modules

Web POS

public

2019-11-15 11:59

2020-02-22 19:57

Reporter

marvintm

Assigned To

marvintm

Priority

normal

Severity

major

Reproducibility

have not tried

Status

scheduled

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042291: Incorrect price is discounted when combining rules which gift full units

Description

There is currently a limitation in the discounts engine when applying several rules which gift full units in the same line.

An example is the issue https://issues.openbravo.com/view.php?id=41789 [^] which applied to the basic Buy X gift Y rule, but other rules like Free Products per Total Amount, or Buy X pay Y of same or different products, have also a similar problem.

Ideally the solution should be in the infrastructure or superclass, not in the specific rule. So we should provide a general fix, and then use it in the corresponding rules, and then revert the fix that was done for 41789.

Steps To Reproduce

The steps to reproduce in issue 41789 can be used, although the same example could be done for Free Products by Total Amount rule.

Proposed Solution

Additional Information