Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042285Openbravo ERPA. Platformpublic2019-11-14 15:102019-12-16 12:37
Reportercberner 
Assigned Tocberner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042285: Apply new HQL style to interface AccessTypeInjector and remove StringBuilder
DescriptionUse String instead of StringBuilder in AccessTypeInjector to prevent HQL Injection and comply with the new HQL formatting.

Remove this in both AccessTypeInjector interface and the classes it extends, this will also require a small API change.
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0041287 acknowledged Triage Platform Base Tracking issue: Convert HQL to apply new style 
causes defect 0042432 closed cberner API Change: Changed StringBuffer parameter to String in method clause 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-11-14 15:10cbernerNew Issue
2019-11-14 15:10cbernerAssigned To => cberner
2019-11-14 15:10cbernerModules => Core
2019-11-14 15:10cbernerTriggers an Emergency Pack => No
2019-11-14 15:12cbernerRelationship addedrelated to 0041287
2019-11-14 15:13cbernerStatusnew => scheduled
2019-11-14 15:13cbernerDescription Updatedbug_revision_view_page.php?rev_id=19703#r19703
2019-11-28 11:01cbernerRelationship addedcauses 0042432
2019-11-28 18:04hgbotCheckin
2019-11-28 18:04hgbotNote Added: 0115959
2019-11-28 18:04hgbotStatusscheduled => resolved
2019-11-28 18:04hgbotResolutionopen => fixed
2019-11-28 18:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5a438a7a4de329d0f9c5d1eb25ca333d52089ac9 [^]
2019-11-29 09:57alostaleReview Assigned To => AugustoMauch
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116294
2019-12-16 12:37AugustoMauchNote Added: 0116340
2019-12-16 12:37AugustoMauchStatusresolved => closed
2019-12-16 12:37AugustoMauchFixed in Version => 3.0PR20Q1

Notes
(0115959)
hgbot   
2019-11-28 18:04   
Repository: erp/devel/pi
Changeset: 5a438a7a4de329d0f9c5d1eb25ca333d52089ac9
Author: Cristian Berner <cristian.berner <at> openbravo.com>
Date: Thu Nov 14 15:47:30 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5a438a7a4de329d0f9c5d1eb25ca333d52089ac9 [^]

Fixes issue 42285: Apply new HQL Style to AccessTypeInjector and implementors

---
M src/org/openbravo/role/inheritance/access/AccessTypeInjector.java
M src/org/openbravo/role/inheritance/access/AlertRecipientAccessInjector.java
M src/org/openbravo/role/inheritance/access/PreferenceAccessInjector.java
---
(0116294)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test
(0116340)
AugustoMauch   
2019-12-16 12:37   
Code reviewed and verified