Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042249Openbravo ERPA. Platformpublic2019-11-12 13:132019-12-12 23:01
Reporterjarmendariz 
Assigned Tomigueldejuana 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned Tojarmendariz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042249: Add ESLint rules configuration to support Airbnb javascript guidelines
DescriptionThe goal is to enforce Airbnb's javascript guidelines for all new code from
now on. This requires to add the eslint-airbnb-base and then extend it in a eslintrc.json in the folder where you want to support these rules.
Steps To ReproduceSee above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0039983 closed jarmendariz Upgrade javascript linter and formatter 
causes defect 0042274 new Triage Platform Base Formatting check in hg hooks may be redundant 
Attached Filesdiff root.diff (55,793) 2019-11-12 13:17
https://issues.openbravo.com/file_download.php?file_id=13519&type=bug
diff eslintrcExample.diff (286) 2019-11-12 13:18
https://issues.openbravo.com/file_download.php?file_id=13520&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-11-12 13:13jarmendarizNew Issue
2019-11-12 13:13jarmendarizAssigned To => migueldejuana
2019-11-12 13:13jarmendarizModules => Core
2019-11-12 13:13jarmendarizTriggers an Emergency Pack => No
2019-11-12 13:13jarmendarizRelationship addedrelated to 0039983
2019-11-12 13:17migueldejuanaFile Added: root.diff
2019-11-12 13:18migueldejuanaFile Added: eslintrcExample.diff
2019-11-13 09:56jarmendarizReview Assigned To => jarmendariz
2019-11-13 09:56jarmendarizStatusnew => scheduled
2019-11-13 09:58hgbotCheckin
2019-11-13 09:58hgbotNote Added: 0115571
2019-11-13 09:58hgbotStatusscheduled => resolved
2019-11-13 09:58hgbotResolutionopen => fixed
2019-11-13 09:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/354df066b4d200bb550efc8ca0dba3ca453cb964 [^]
2019-11-13 09:59jarmendarizNote Added: 0115572
2019-11-13 09:59jarmendarizStatusresolved => closed
2019-11-13 09:59jarmendarizFixed in Version => 3.0PR20Q1
2019-11-13 13:28hgbotCheckin
2019-11-13 13:28hgbotNote Added: 0115578
2019-11-14 09:52jarmendarizRelationship addedcauses 0042274
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116279
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116282

Notes
(0115571)
hgbot   
2019-11-13 09:58   
Repository: erp/devel/pi
Changeset: 354df066b4d200bb550efc8ca0dba3ca453cb964
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Nov 12 18:43:06 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/354df066b4d200bb550efc8ca0dba3ca453cb964 [^]

Fixed issue 42249: Add Airbnb js guidelines to js

Added airbnb-base package in order to be able to use this guideline
on new code. This configuration will be added to every module in the
web/<module.package>/app/ folder, where new js code will be placed.

---
M .eslintrc.json
M package-lock.json
M package.json
A modules/org.openbravo.client.kernel/eslint-airbnb/copy-config
A modules/org.openbravo.client.kernel/eslint-airbnb/eslintrc-airbnb.template
---
(0115572)
jarmendariz   
2019-11-13 09:59   
Reviewed + tested
(0115578)
hgbot   
2019-11-13 13:28   
Repository: erp/devel/pi
Changeset: 1ab6738db5ee37a5cce6daabb2c4a9dcaebbfe97
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Wed Nov 13 13:28:07 2019 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1ab6738db5ee37a5cce6daabb2c4a9dcaebbfe97 [^]

Related to issue 42249: Missing copyright notice added to file

---
M modules/org.openbravo.client.kernel/eslint-airbnb/copy-config
---
(0116279)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test
(0116282)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test