0042237: Discount value is not recalculated when opening a layaway with a price modification and editing it (not standard)

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042237

Retail Modules

Web POS

public

2019-11-08 13:29

2019-11-28 19:00

Reporter

ngarcia

Assigned To

rqueralta

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR20Q1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042237: Discount value is not recalculated when opening a layaway with a price modification and editing it (not standard)

Description

Discount value is not recalculated when opening a layaway with a price modification and editing it (not standard).

The discountPercentage is recalculated in adjustPrices function if the following condition is fulfilled:

          (line.get('product').get('standardPrice') &&
            line.get('product').get('standardPrice') !== price) ||
          (_.isNumber(line.get('discountedLinePrice')) &&
            line.get('discountedLinePrice') !==
              line.get('product').get('standardPrice'))
        )

When loading an editable layaway (customization), the standardPrice and the price are equals and discountLinePrice is undefined, so discountPercentage is not recalculated.

discountLinePrice is not calculated when loading an editable layaway

Steps To Reproduce

In the POS:
   Create a receipt
   Layaway this receipt
   Add a Adhesive body warmers product
   Reduce its price to 2
   Layaway

In the backoffice:
   Check the Gross Unit Price and Gross List price are different and the Discount is different from 0 (44.44%). This is correct

   Open Receipt
   Select previously created layaway

Note: layaways cannot be edited so we should force it to be editable. Moreover, the discountLinePrice is calculated only for not editable receipts when they are loaded, so we should force it was editable before loading

Open Developers' tools and do the following instruction

OB.MobileApp.model.receipt.turnEditable()
OB.MobileApp.model.receipt.attributes.lines.models[0].attributes.discountedLinePrice = undefined

In the POS:
   Change the price of the line to the original one (3.60)
   Pay it

In the backoffice:
   Check the Gross Unit Price and Gross List are equal and the Discount didn't change. It should have been recalculated

Proposed Solution

Additional Information