Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042191Retail ModulesTax Exemptpublic2019-11-04 19:072019-11-29 12:48
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042191: Remove use of hook OBPOS_FindTaxRate
DescriptionHook OBPOS_FindTaxRate will be removed in taxes engine, so the functionality around field obtaxexIstaxexempt must be moved an other location.
Steps To ReproduceN/A
Proposed SolutionImport attached part in module org.openbravo.retail.taxexempt. Take into account that breaks current tests that must be fixed because there is no longer possible to modify the taxes engine from outside as this module was doing modifying the SQL sentence for taxes.

Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue42191.patch (3,271) 2019-11-06 08:34
https://issues.openbravo.com/file_download.php?file_id=13482&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-11-04 19:07adrianromeroNew Issue
2019-11-04 19:07adrianromeroAssigned To => adrianromero
2019-11-04 19:07adrianromeroTriggers an Emergency Pack => No
2019-11-06 08:34adrianromeroFile Added: issue42191.patch
2019-11-06 08:36adrianromeroProposed Solution updated
2019-11-18 11:07hgbotCheckin
2019-11-18 11:07hgbotNote Added: 0115643
2019-11-18 11:07hgbotStatusnew => resolved
2019-11-18 11:07hgbotResolutionopen => fixed
2019-11-18 11:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/70dbf02e64a6df481647181d092380426f1b8ab2 [^]
2019-11-18 17:57hgbotCheckin
2019-11-18 17:57hgbotNote Added: 0115668
2019-11-29 12:48migueldejuanaStatusresolved => new
2019-11-29 12:48migueldejuanaResolutionfixed => open

Notes
(0115643)
hgbot   
2019-11-18 11:07   
Repository: erp/pmods/org.openbravo.retail.taxexempt
Changeset: 70dbf02e64a6df481647181d092380426f1b8ab2
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Nov 04 19:09:29 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/70dbf02e64a6df481647181d092380426f1b8ab2 [^]

Fixes issue 0042191: Remove use of hook OBPOS_FindTaxRate

---
M src/org/openbravo/retail/taxexempt/TaxExemptComponentProvider.java
M web/org.openbravo.retail.taxexempt/js/hookRenderOrderLine.js
R web/org.openbravo.retail.taxexempt/js/hookFindTaxRate.js
---
(0115668)
hgbot   
2019-11-18 17:57   
Repository: erp/pmods/org.openbravo.retail.taxexempt
Changeset: 1f4001a48a30873967f172b701fbb36e926777a1
Author: Javier Rodriguez <javier.rodriguez <at> openbravo.com>
Date: Mon Nov 18 17:49:16 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.taxexempt/rev/1f4001a48a30873967f172b701fbb36e926777a1 [^]

Related issue 42191: Backed out due to some failing test in try-retail

---
M src/org/openbravo/retail/taxexempt/TaxExemptComponentProvider.java
M web/org.openbravo.retail.taxexempt/js/hookRenderOrderLine.js
A web/org.openbravo.retail.taxexempt/js/hookFindTaxRate.js
---