Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042110ModulesInvoices Register Bookpublic2019-10-24 10:352020-11-03 07:10
Reportermaite 
Assigned ToMery Anelo 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0042110: "C_Tax Parent is NULL" validation not met by "C_Tax_Id_Vat" column, in Invoice Register Book Lines table
DescriptionWhen a Tax Rate is composed of an IVA tax and an Equivalent Charge tax, only one line in Invoice Register Book is created, containing information from both taxes.

In those cases, "VAT Tax" field is not correctly set as parent tax rate should be set to meet validation defined for this column
Steps To Reproduce0. Install the latest version of the following modules:
  - Taxes for Spain
  - Invoices Register Book
  - Configuracion Libros de Facturas
1. Apply datasets and ensure that "Entregas IVA+RE 21+5.2% (+5.2%)" rate has been configured as Equivalent Charge=YES
2. Register Sales Invoice for "F&B España - Región Norte" organization, any BP, today's date
3. Add an invoice line for any product and qty. Set tax "Entregas IVA+RE 21+5.2% "
4. Process and Post invoice
5. Create a new record in "Invoice Register Book" window for
  - "F&B España, S.A" organization
  - Invoice REgister book = Libro de Facturas Emitidas 2016
  - Year = 2019
  - Period from = oct 19
  - Period to = oct 19
6. Run "Create" process and realize that line related with your invoice has been added. Open line in form view and check that VAT Tax has been set to "**Entregas IVA+RE 21+5.2% (+21%)" and it is shown with **
Proposed SolutionParent tax "Entregas IVA+RE 21+5.2%" should be set, so we ensure that validation is met
Additional Information
TagsNo tags attached.
Relationships
Attached Filesjpg issue_42110.jpg (72,916) 2019-11-08 14:43
https://issues.openbravo.com/file_download.php?file_id=13506&type=bug
jpg
Issue History
Date ModifiedUsernameFieldChange
2019-10-24 10:35maiteNew Issue
2019-10-24 10:35maiteAssigned To => Triage Finance
2019-10-24 10:35maiteResolution time => 1573686000
2019-10-24 10:35maiteIssue Monitored: networkb
2019-10-24 12:58SandrahuguetAssigned ToTriage Finance => psanjuan
2019-11-07 10:22psanjuanAssigned Topsanjuan => Jorge Bravo
2019-11-07 12:46Jorge BravoAssigned ToJorge Bravo => Mery Anelo
2019-11-08 14:43psanjuanNote Added: 0115481
2019-11-08 14:43psanjuanFile Added: issue_42110.jpg
2020-08-05 01:56Mery AneloNote Added: 0121816
2020-08-05 01:56Mery AneloStatusnew => scheduled
2020-08-21 12:55hgbotNote Added: 0122240
2020-08-21 13:06hgbotResolutionopen => fixed
2020-08-21 13:06hgbotStatusscheduled => closed
2020-08-21 13:06hgbotNote Added: 0122241
2020-08-21 13:06hgbotNote Added: 0122242
2020-08-21 13:18vmromanosNote Added: 0122246
2020-08-21 13:18vmromanosStatusclosed => new
2020-08-21 13:18vmromanosResolutionfixed => open
2020-08-21 13:38hgbotNote Added: 0122247
2020-09-22 14:16psanjuanNote Added: 0123289
2020-10-05 16:52hgbotNote Added: 0123554
2020-10-26 14:04Mery AneloStatusnew => scheduled
2020-11-03 07:05hgbotNote Added: 0124102
2020-11-03 07:06hgbotNote Added: 0124103
2020-11-03 07:06hgbotResolutionopen => fixed
2020-11-03 07:06hgbotStatusscheduled => closed
2020-11-03 07:06hgbotNote Added: 0124104
2020-11-03 07:10hgbotNote Added: 0124105
2020-11-03 07:10hgbotNote Added: 0124106

Notes
(0115481)
psanjuan   
2019-11-08 14:43   
see image
(0121816)
Mery Anelo   
2020-08-05 01:56   
Test Plan:

-. Install the latest version of the following modules:
  - Taxes for Spain
  - Invoices Register Book
  - Configuracion Libros de Facturas
-. Apply datasets and ensure that "Entregas IVA+RE 21+5.2% (+5.2%)" rate has been configured as Equivalent Charge=YES
-. Register Sales Invoice for "F&B España - Región Norte" organization, any BP, today's date
-. Add an invoice line for any product and qty. Set tax "Entregas IVA+RE 21+5.2% "
-. Process and Post invoice
-. Create a new record in "Invoice Register Book" window for
  - "F&B España, S.A" organization
  - Invoice REgister book = Libro de Facturas Emitidas 2016
  - Year = 2019
  - Period from = oct 19
  - Period to = oct 19
-. Run "Create" process and realize that line related with your invoice has been added. Open line in form view and check that VAT Tax has been set correct, without "**"
(0122240)
hgbot   
2020-08-21 12:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/1 [^]
(0122241)
hgbot   
2020-08-21 13:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^]
Changeset: e7a98ef3926d3406c538963b9abc90516abcb1cb
Author: Mery Anelo <mery.anelo@smfconsulting.es>
Date: 2020-08-21T12:43:07+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/e7a98ef3926d3406c538963b9abc90516abcb1cb [^]

Fixed bug 42110: Invoice Register Book Lines with Parent Tax.

Set the parent VAT in case the line has a compound tax.

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
---
(0122242)
hgbot   
2020-08-21 13:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/1 [^]
(0122246)
vmromanos   
2020-08-21 13:18   
Missing cash vat module fix
(0122247)
hgbot   
2020-08-21 13:38   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^]
Changeset: b97e2aff7537f38e2a2588782d26437ec01e886d
Author: Víctor Martínez Romanos <victor.martinez@openbravo.com>
Date: 2020-08-21T13:34:45+02:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/b97e2aff7537f38e2a2588782d26437ec01e886d [^]

Related to ISSUE-42110: backout previous changeset e7a98ef

The change might be risky as this field is used by the 340 report.
Temporary backout this change till we ensure the fix doesn't create a
conflict with child lease/real estate taxes

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
---
(0123289)
psanjuan   
2020-09-22 14:16   
There is not need to support 340 tax form in Spain any longer.
(0123554)
hgbot   
2020-10-05 16:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/merge_requests/2 [^]
(0124102)
hgbot   
2020-11-03 07:05   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/3 [^]
(0124103)
hgbot   
2020-11-03 07:06   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/merge_requests/3 [^]
(0124104)
hgbot   
2020-11-03 07:06   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook [^]
Changeset: 8dd2c33b29973521e4f0251f7173f9fe751c1a5c
Author: Mery Anelo <mery.anelo@smfconsulting.es>
Date: 2020-11-03T07:02:26+01:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook/-/commit/8dd2c33b29973521e4f0251f7173f9fe751c1a5c [^]

Fixed bug 42110: Invoice Register Book Lines with Parent Tax.

Set the parent VAT in case the line has a compound tax.

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
---
(0124105)
hgbot   
2020-11-03 07:10   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat [^]
Changeset: cd1b220b4e64ed5e6e6cd2d9d1d993cad68881c2
Author: Mery Anelo <mery.anelo@smfconsulting.es>
Date: 2020-11-03T06:09:17+00:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/commit/cd1b220b4e64ed5e6e6cd2d9d1d993cad68881c2 [^]

Fixed bug 42110: Invoice Register Book Lines with Parent Tax.

Set the parent VAT in case the line has a compound tax.

---
M src/org/openbravo/module/invoicesregisterbook/obirb_actionButton/CreateBookLines.java
---
(0124106)
hgbot   
2020-11-03 07:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.module.invoicesregisterbook-cashvat/-/merge_requests/2 [^]