Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042108Retail ModulesWeb POSpublic2019-10-23 17:282019-11-14 18:22
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042108: Amount to keep can be higher than total counted for a payment method in cash up
DescriptionAmount to keep can be higher than total counted for a payment method in cash up.

In the following piece of code the payment.get('foreignCounted') is undefined so the payment.get('foreignCounted') < paymentMethod.amount) condition is false:

if (paymentMethod.keepfixedamount) {
   if (_.isNumber(payment.get('foreignCounted')) && payment.get('foreignCounted') < paymentMethod.amount) {
      payment.set('qtyToKeep', payment.get('foreignCounted'));
   } else {
      payment.set('qtyToKeep', paymentMethod.amount);
}
Steps To ReproduceIn the backoffice:
   Configure the Payment Methods of 'VBS POS Terminal Type' Channel - Touchpoint Type as:
      Keep Fixed Amount: Y
      Amount to Keep: 200
      Allow Variable Amount: N
      Allow Not to Move: N
      Allow Move Everything: N

In the POS:
   Do the cash up
   In 'Step 1 of 3: Count Cash' do not count any amount, leave Counted as 0.00
   In 'Step 2 of 3: Count Cash', select all the payment methods in order to leave Counted = Expected
   Due to previous configuration the next step is 'Step 3 of 3: Post, print and close'
   Post, Print & Close

In the backoffice:
   Go to 'Channel - Touchpoint' window, 'Cash Up History' tab and 'Payment Method Statu Cashup' subtab
   Check for Cash that the Amount to Keep is 200 and the Total Counted is 0
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0043914 closed ranjith_qualiantech_com Wrong 'Amount to keep' in cash up when Allow Not to Move = N 
causes defect 0044410 closed ranjith_qualiantech_com Incorrect cash-up values: "Total to Keep" and "Total to Deposit". 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-23 17:28ngarciaNew Issue
2019-10-23 17:28ngarciaAssigned To => Retail
2019-10-23 17:28ngarciaResolution time => 1573599600
2019-10-23 17:28ngarciaTriggers an Emergency Pack => No
2019-10-23 17:29ngarciaIssue Monitored: networkb
2019-10-23 17:33rafarodaIssue Monitored: rafaroda
2019-10-24 16:26ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-10-25 07:54ranjith_qualiantech_comStatusnew => scheduled
2019-11-06 08:29hgbotCheckin
2019-11-06 08:29hgbotNote Added: 0115422
2019-11-06 08:29hgbotStatusscheduled => resolved
2019-11-06 08:29hgbotResolutionopen => fixed
2019-11-06 08:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4369b93ea8521399ca95e53ce68e2187ea037a03 [^]
2019-11-14 18:22guilleaerReview Assigned To => guilleaer
2019-11-14 18:22guilleaerStatusresolved => closed
2019-11-14 18:22guilleaerFixed in Version => RR20Q1
2020-05-07 07:41ranjith_qualiantech_comRelationship addedcauses 0043914
2020-07-03 11:00ranjith_qualiantech_comRelationship addedcauses 0044410

Notes
(0115422)
hgbot   
2019-11-06 08:29   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4369b93ea8521399ca95e53ce68e2187ea037a03
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 06 12:58:56 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4369b93ea8521399ca95e53ce68e2187ea037a03 [^]

Fixed issue 42108 : Updated Amount to Keep when changing Counted Amount in Cashup

* Amount to Keep should be exceed the Counted amount

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---