0042108: Amount to keep can be higher than total counted for a payment method in cash up

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0042108

Retail Modules

Web POS

public

2019-10-23 17:28

2019-11-14 18:22

Reporter

ngarcia

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR20Q1

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Gold

Support ticket

12280

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0042108: Amount to keep can be higher than total counted for a payment method in cash up

Description

Amount to keep can be higher than total counted for a payment method in cash up.

In the following piece of code the payment.get('foreignCounted') is undefined so the payment.get('foreignCounted') < paymentMethod.amount) condition is false:

if (paymentMethod.keepfixedamount) {
   if (_.isNumber(payment.get('foreignCounted')) && payment.get('foreignCounted') < paymentMethod.amount) {
      payment.set('qtyToKeep', payment.get('foreignCounted'));
   } else {
      payment.set('qtyToKeep', paymentMethod.amount);
}

Steps To Reproduce

In the backoffice:
   Configure the Payment Methods of 'VBS POS Terminal Type' Channel - Touchpoint Type as:
      Keep Fixed Amount: Y
      Amount to Keep: 200
      Allow Variable Amount: N
      Allow Not to Move: N
      Allow Move Everything: N

In the POS:
   Do the cash up
   In 'Step 1 of 3: Count Cash' do not count any amount, leave Counted as 0.00
   In 'Step 2 of 3: Count Cash', select all the payment methods in order to leave Counted = Expected
   Due to previous configuration the next step is 'Step 3 of 3: Post, print and close'
   Post, Print & Close

In the backoffice:
   Go to 'Channel - Touchpoint' window, 'Cash Up History' tab and 'Payment Method Statu Cashup' subtab
   Check for Cash that the Amount to Keep is 200 and the Total Counted is 0

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

causes	defect	0043914		closed	ranjith_qualiantech_com	Wrong 'Amount to keep' in cash up when Allow Not to Move = N
causes	defect	0044410		closed	ranjith_qualiantech_com	Incorrect cash-up values: "Total to Keep" and "Total to Deposit".