Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042082Retail ModulesWeb POSpublic2019-10-22 10:342019-10-23 13:08
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042082: Upgrade barcode scanner js syntax to ES6
DescriptionWhen the barcode scanner module were implemented, ESLint was not introduced yet. For this reason no ES6 features such as the use of let/const or arrow functions were introduced.
Steps To ReproduceSee above
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on feature request 0040551 closed jarmendariz Use the device camera as barcode scanner 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-22 10:34jarmendarizNew Issue
2019-10-22 10:34jarmendarizAssigned To => Retail
2019-10-22 10:34jarmendarizTriggers an Emergency Pack => No
2019-10-22 10:34jarmendarizRelationship addeddepends on 0040551
2019-10-22 10:35jarmendarizStatusnew => scheduled
2019-10-22 10:54jarmendarizReview Assigned To => migueldejuana
2019-10-22 12:52hgbotCheckin
2019-10-22 12:52hgbotNote Added: 0115211
2019-10-22 12:52hgbotStatusscheduled => resolved
2019-10-22 12:52hgbotResolutionopen => fixed
2019-10-22 12:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.camerabarcodescanner/rev/bfddd4a571b58a3b7f2ca4895e123279b32cea2a [^]
2019-10-22 19:20marvintmAssigned ToRetail => jarmendariz
2019-10-23 13:08migueldejuanaNote Added: 0115252
2019-10-23 13:08migueldejuanaStatusresolved => closed

Notes
(0115211)
hgbot   
2019-10-22 12:52   
Repository: erp/pmods/org.openbravo.retail.camerabarcodescanner
Changeset: bfddd4a571b58a3b7f2ca4895e123279b32cea2a
Author: Javier Armendáriz <javier.armendariz <at> openbravo.com>
Date: Tue Oct 22 12:50:40 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.camerabarcodescanner/rev/bfddd4a571b58a3b7f2ca4895e123279b32cea2a [^]

Fixed issue 42082: Updated js syntax to ES6

Adding the following ES6 features:
- Arrow functions
- Catch function in promises
- Use of let and const instead of var

---
M web/org.openbravo.retail.camerabarcodescanner/js/barcode-scanner-popup.js
M web/org.openbravo.retail.camerabarcodescanner/js/scan-from-camera-button.js
M web/org.openbravo.retail.camerabarcodescanner/js/zxing-scanner.js
---
(0115252)
migueldejuana   
2019-10-23 13:08   
Reviewed