Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042065Retail ModulesWeb POSpublic2019-10-18 11:532019-11-14 17:30
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042065: Deprecate legacy Payment Provider and Refund Provider
DescriptionThese two fields for integrating 3rd party payment providers are deprecated in favor of the Payment Methods grouping by Provider functionality http://wiki.openbravo.com/wiki/Retail:Payment_Methods_grouping_by_Provider_User_Guide [^]

A new "Legacy provider" should be created using the new definitions to cover the legacy Payment Provider and Refund Provider.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042136 closed adrianromero API change: Constraint change in OBPOS_APP_PAYMENT_TYPE 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-18 11:53adrianromeroNew Issue
2019-10-18 11:53adrianromeroAssigned To => adrianromero
2019-10-18 11:53adrianromeroTriggers an Emergency Pack => No
2019-10-28 10:44hgbotCheckin
2019-10-28 10:44hgbotNote Added: 0115291
2019-10-28 10:44hgbotStatusnew => resolved
2019-10-28 10:44hgbotResolutionopen => fixed
2019-10-28 10:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fe182879665c6ba97f045570a98a8cbc19561ae8 [^]
2019-10-28 10:44hgbotCheckin
2019-10-28 10:44hgbotNote Added: 0115292
2019-10-28 10:44hgbotCheckin
2019-10-28 10:44hgbotNote Added: 0115294
2019-10-28 10:46adrianromeroNote Added: 0115295
2019-10-28 10:48adrianromeroReview Assigned To => marvintm
2019-10-28 18:07hgbotCheckin
2019-10-28 18:07hgbotNote Added: 0115306
2019-10-29 10:59adrianromeroRelationship addedrelated to 0042136
2019-10-29 23:45hgbotCheckin
2019-10-29 23:45hgbotNote Added: 0115329
2019-11-06 16:33hgbotCheckin
2019-11-06 16:33hgbotNote Added: 0115433
2019-11-06 16:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fe182879665c6ba97f045570a98a8cbc19561ae8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/01350d9a2998af1d11183cdef478fe022a8f2a29 [^]
2019-11-14 17:30marvintmStatusresolved => closed
2019-11-14 17:30marvintmFixed in Version => RR20Q1

Notes
(0115291)
hgbot   
2019-10-28 10:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fe182879665c6ba97f045570a98a8cbc19561ae8
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Oct 18 13:12:36 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fe182879665c6ba97f045570a98a8cbc19561ae8 [^]

Fixes issue 42065: Deprecate legacy Payment Provider and Refund Provider

---
M src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/model/triggers/OBPOS_APP_PAYMENT_PROVIDER.xml
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/AD_TABLE.xml
M src-db/database/sourcedata/OBPOS_PAYMENTMETHOD_TYPE.xml
M src/org/openbravo/retail/posterminal/term/Payments.java
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
A build/classes/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.class
A src-db/database/sourcedata/OBPOS_PAYMENTGROUP.xml
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.java
---
(0115292)
hgbot   
2019-10-28 10:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2e6acd6715c951a2618a65782a1671b5a714924a
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Oct 21 11:18:55 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2e6acd6715c951a2618a65782a1671b5a714924a [^]

Related to issue 42065: Use module script to create and deprecate payment group and payment records

---
M build/classes/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.class
M src-db/database/sourcedata/AD_DATASET_TABLE.xml
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.java
---
(0115294)
hgbot   
2019-10-28 10:44   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 520220822ebaff64637d5a95b5451974f06015d7
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Oct 28 10:37:57 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/520220822ebaff64637d5a95b5451974f06015d7 [^]

Related issue 0042065: Deprecate legacy Payment Provider and Refund Provider
* Format js code

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0115295)
adrianromero   
2019-10-28 10:46   
Includes also the following changesets:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/740f32655874 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/996cf95f6880 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eddb00814d04 [^]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/20921c6833ec [^]
(0115306)
hgbot   
2019-10-28 18:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 331c5cce6d30f616ebd9dbaf52fb20ceb24c66da
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Oct 28 18:06:33 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/331c5cce6d30f616ebd9dbaf52fb20ceb24c66da [^]

Related issue 0042065: Deprecate legacy Payment Provider and Refund Provider
* Fixes SQL sentence in module script DeprecateLegacyProvider.

---
M build/classes/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.java
---
(0115329)
hgbot   
2019-10-29 23:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 84bae99031d72bf6bc05ba4a7b4caa28c6b738da
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Tue Oct 29 23:44:38 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/84bae99031d72bf6bc05ba4a7b4caa28c6b738da [^]

Related issue 0042065: Deprecate legacy Payment Provider and Refund Provider
* Fixes SQL sentence in module script DeprecateLegacyProvider.

---
M build/classes/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.java
---
(0115433)
hgbot   
2019-11-06 16:33   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 01350d9a2998af1d11183cdef478fe022a8f2a29
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Mon Nov 04 17:40:22 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/01350d9a2998af1d11183cdef478fe022a8f2a29 [^]

Fixes issue 0042065: Deprecate legacy Payment Provider and Refund Provider
* Improves logic in modulescript

---
M build/classes/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.class
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/DeprecateLegacyProvider.java
---