Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042062Retail ModulesDiscounts and Promotionspublic2019-10-18 10:082019-12-23 14:11
Reportergorkaion 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042062: Different applied and shown percentage on previous discount engine.
DescriptionWhen using the previous discount engine. If a variable discount percentage is set and later the user switches to another discount and comes back to the original variable discount. In the combo it is shown the percentage set by the user but if the discount is applied the original percentage is used.

A similar misbehavior is found with transaction level discounts with variable percentage.
Steps To Reproduce1. Set preference "Web POS action Advanced Discounts" with value N to enable previous discount engine.
2. Login in POS
3. Add a product to the ticket.
4. Open discounts and select "disc_5_ var_perc - 5%"
5. Change percentage to 50%
6. Notice the value in the combo is changed to "disc_5_ var_perc - 50%"
7. Select a different discount type.
8. Select again "disc_5_ var_perc - 50%"
9. Notice it still says 50%
10. Apply the discount note that the percentage applied is 5% instead of 50%

Proposed Solutionensure that when changing the discount type the set percentages are maintained or completely reset.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042630 closed rqueralta Variable Percentage Discount per Total Amount uses hidden percentage discount as default percentage 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-18 10:08gorkaionNew Issue
2019-10-18 10:08gorkaionAssigned To => Retail
2019-10-18 10:08gorkaionResolution time => 1573167600
2019-10-18 10:08gorkaionTriggers an Emergency Pack => No
2019-10-21 20:08rqueraltaAssigned ToRetail => rqueralta
2019-10-21 20:08rqueraltaStatusnew => scheduled
2019-11-11 13:26hgbotCheckin
2019-11-11 13:26hgbotNote Added: 0115509
2019-11-11 13:26hgbotStatusscheduled => resolved
2019-11-11 13:26hgbotResolutionopen => fixed
2019-11-11 13:26hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e0fa9cd607a51a1df313a2161370c9f986d8b0f [^]
2019-11-11 15:06hgbotCheckin
2019-11-11 15:06hgbotNote Added: 0115523
2019-11-14 18:59marvintmReview Assigned To => marvintm
2019-11-14 18:59marvintmStatusresolved => closed
2019-11-14 18:59marvintmFixed in Version => RR20Q1
2019-12-23 14:11gorkaionIssue cloned0042630
2019-12-23 14:11gorkaionRelationship addedrelated to 0042630

Notes
(0115509)
hgbot   
2019-11-11 13:26   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9e0fa9cd607a51a1df313a2161370c9f986d8b0f
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Nov 04 15:43:04 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9e0fa9cd607a51a1df313a2161370c9f986d8b0f [^]

Fixed issue 42062: Different applied and shown percentage on previous discount
engine.

- In discount type the set percentages was completely reset.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---
(0115523)
hgbot   
2019-11-11 15:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 11637cada222544a8385c8cc97fca0eba0273605
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Nov 11 09:03:39 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/11637cada222544a8385c8cc97fca0eba0273605 [^]

Related to issue 42062: Different applied and shown percentage on previous discount
engine.

- In discount type the set percentages was completely reset.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js
---