Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042057Openbravo ERP04. Warehouse managementpublic2019-10-17 14:142019-12-12 23:01
Reportermaite 
Assigned Tomarkmm82 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket12318
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042057: It is not possible to unpost an Internal Comsumption
DescriptionWhen trying to unpost an Internal Consumption document, error PeriodClosedForUnPosting is raised, although user was able to post the document (and period is open in reality)

Real problem is that Internal Consumption documents have not Document Type defined (which is mandatory when unposting a document and also when background accounting process post a document)
Steps To Reproduce0. Access Instance Activation window and set valid key, as this is necessary to see Internal Consumption window
1. Access Internal Consumption window and create new document
2. Add line and process document
3. Post document and realize that proper accounting entry is generated
4. Unpost the document and error will be raised
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0015757 closed Triage Omni OMS Be able to post Internal Consumptions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-17 14:14maiteNew Issue
2019-10-17 14:14maiteAssigned To => Triage Finance
2019-10-17 14:14maiteOBNetwork customer => OBPS
2019-10-17 14:14maiteModules => Core
2019-10-17 14:14maiteSupport ticket => 12318
2019-10-17 14:14maiteResolution time => 1573081200
2019-10-17 14:14maiteTriggers an Emergency Pack => No
2019-10-17 14:15maiteRelationship addedrelated to 0015757
2019-10-17 14:18maiteIssue Monitored: networkb
2019-10-17 16:32SandrahuguetAssigned ToTriage Finance => markmm82
2019-10-21 04:23markmm82Statusnew => scheduled
2019-10-21 15:24markmm82Note Added: 0115185
2019-10-31 08:39hgbotCheckin
2019-10-31 08:39hgbotNote Added: 0115366
2019-10-31 08:39hgbotStatusscheduled => resolved
2019-10-31 08:39hgbotResolutionopen => fixed
2019-10-31 08:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ae87c02f3f800fe5fac5b1fc5b54ffe0d347e534 [^]
2019-10-31 08:40SandrahuguetReview Assigned To => Sandrahuguet
2019-10-31 08:40SandrahuguetNote Added: 0115367
2019-10-31 08:40SandrahuguetStatusresolved => closed
2019-10-31 08:40SandrahuguetFixed in Version => 3.0PR20Q1
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116270

Notes
(0115185)
markmm82   
2019-10-21 15:24   
Test Plan:
0. Access Instance Activation window and set valid key, as this is necessary to see Internal Consumption window
1. Access Internal Consumption window and create new document
2. Add line and process document
3. Post document and realize that proper accounting entry is generated
4. Unpost the document with deleting records option selected and notice an error will be raised:
"Error
 There is not document type defined for table: M_Internal_Consumption"
  Accounting entries still there.
5. Go to Document Type window and create a new one for Internal Consumption:
   Document Category: Material Internal Consumption
   Table: M_Internal_Consumption
6. This time try to unpost the document with deleting records option selected again.
  Notice the process ends successfully without any error.
  Accounting entries were removed.
(0115366)
hgbot   
2019-10-31 08:39   
Repository: erp/devel/pi
Changeset: ae87c02f3f800fe5fac5b1fc5b54ffe0d347e534
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Mon Oct 21 10:15:53 2019 -0300
URL: http://code.openbravo.com/erp/devel/pi/rev/ae87c02f3f800fe5fac5b1fc5b54ffe0d347e534 [^]

Fixes issue 42057: It is not possible to unpost an Internal Comsumption

If the Internal Consumption documents have not Document Type defined which is mandatory
when unposting a document an exception will be thrown to the user.

Also was included a minor change in the Posted class to set the success message title
after we are sure any exception was thrown to avoid to have an error message with a success
title and cause confusions.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/erpCommon/ad_actionButton/Posted.java
M src/org/openbravo/financial/ResetAccounting.java
---
(0115367)
Sandrahuguet   
2019-10-31 08:40   
code review + testing ok
(0116270)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test