Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042052Retail ModulesWeb POSpublic2019-10-17 11:442019-10-25 12:45
Reporteradrianromero 
Assigned Toadrianromero 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042052: Use different components in Providers depending the process is payment or a refund
DescriptionNew architecture in provider for payments uses the same component for payments and refunds, and a different component for void.

For example if the reference key for a provider is 'OBPOS_MockProvider', the application will create a new instance of the component 'OBPOS_MockProvider' for payments and refunds and the component 'OBPOS_MockProviderVoid' for processing void.

To allow better isolation of functionality between components it is good to have different components for processing payments and refunds. For example 'OBPOS_MockProvider' for payments and 'OBPOS_MockProviderRefund' for refunds.

This behaviour should be done backward compatible, in case 'OBPOS_MockProviderRefund' does not exist continue using 'OBPOS_MockProvider' for refunds too.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-17 11:44adrianromeroNew Issue
2019-10-17 11:44adrianromeroAssigned To => Retail
2019-10-17 11:44adrianromeroOBNetwork customer => No
2019-10-17 11:44adrianromeroTriggers an Emergency Pack => No
2019-10-17 11:45adrianromeroAssigned ToRetail => adrianromero
2019-10-17 11:45adrianromeroSummaryUse different components in Provider for Payments depending is a payment or a refund => Use different components in Providers depending the process is payment or a refund
2019-10-17 12:17hgbotCheckin
2019-10-17 12:17hgbotNote Added: 0115141
2019-10-17 12:17hgbotStatusnew => resolved
2019-10-17 12:17hgbotResolutionopen => fixed
2019-10-17 12:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e93b9bbafe31e14b003691d3a89b45db6bdfec66 [^]
2019-10-17 12:19adrianromeroReview Assigned To => marvintm
2019-10-25 12:45marvintmStatusresolved => closed
2019-10-25 12:45marvintmFixed in Version => RR20Q1

Notes
(0115141)
hgbot   
2019-10-17 12:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e93b9bbafe31e14b003691d3a89b45db6bdfec66
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Oct 17 12:17:20 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e93b9bbafe31e14b003691d3a89b45db6bdfec66 [^]

Fixes issue 0042052: Use different components in Providers depending the process is payment or a refund
* In case of refunds it adds *Refund* to the name of the component to create and fallbacks to the regular name for backward compatibility

---
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
---