Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042047Retail ModulesWeb POSpublic2019-10-16 18:182019-11-07 18:54
Reportermalsasua 
Assigned Torqueralta 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042047: wrong discount amount using "User Defined Amount" discount
Descriptionusing the old discount engine, there are rounding problems applying "User Defined Amount" discount
Steps To Reproduce[BO]
. Preferences -> Web POS Use advanced discounts engine -> N
. Product -> p1 -> price: 4.90
. Discount and Promotions:
 -> name: d1
 -> type: User Defined amount
 -> allow multiple instances per line: true
(see screenshot)

[POS]
. add new line: p1-> qty=4
. apply discount d1-> amount 4.90
current status -> total ticket 14.7 -> OK
. apply discount d1-> amount 4.90
current status -> total ticket 9.8 -> OK
. apply discount d1-> amount 4.90
current status -> total ticket 4.9 -> OK
. apply discount d1-> amount 4.90
current status -> total ticket 0.02 -> KO
(see screenshot)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng discountConfig.png (160,450) 2019-10-16 18:19
https://issues.openbravo.com/file_download.php?file_id=13413&type=bug
png

png pos.png (160,426) 2019-10-16 18:20
https://issues.openbravo.com/file_download.php?file_id=13414&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-10-16 18:18malsasuaNew Issue
2019-10-16 18:18malsasuaAssigned To => Retail
2019-10-16 18:18malsasuaResolution time => 1573081200
2019-10-16 18:18malsasuaTriggers an Emergency Pack => No
2019-10-16 18:19malsasuaNote Added: 0115128
2019-10-16 18:19malsasuaFile Added: discountConfig.png
2019-10-16 18:20malsasuaFile Added: pos.png
2019-10-17 14:47rqueraltaAssigned ToRetail => rqueralta
2019-11-04 21:07hgbotCheckin
2019-11-04 21:07hgbotNote Added: 0115394
2019-11-04 21:07hgbotStatusnew => resolved
2019-11-04 21:07hgbotResolutionopen => fixed
2019-11-04 21:07hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/83314167f747bc8ad5ea64d1d5ef3bc79aa5752b [^]
2019-11-04 21:08hgbotCheckin
2019-11-04 21:08hgbotNote Added: 0115395
2019-11-07 18:54marvintmReview Assigned To => marvintm
2019-11-07 18:54marvintmStatusresolved => closed
2019-11-07 18:54marvintmFixed in Version => RR20Q1

Notes
(0115128)
malsasua   
2019-10-16 18:19   
it is not reproducible using the new discount engine
(0115394)
hgbot   
2019-11-04 21:07   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 83314167f747bc8ad5ea64d1d5ef3bc79aa5752b
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sat Oct 26 08:02:25 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/83314167f747bc8ad5ea64d1d5ef3bc79aa5752b [^]

Fixed issue 42047: wrong discount amount using "User Defined Amount" discount

- Changed the rounding method to obtain the correct currentDiscountedLinePrice
value

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0115395)
hgbot   
2019-11-04 21:08   
Repository: tools/automation/pi-mobile
Changeset: 20f875167e91f904a5733202a4a10b5d89b2e0cc
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Mon Oct 28 17:13:48 2019 -0400
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/20f875167e91f904a5733202a4a10b5d89b2e0cc [^]

Related to issue 42047: Changed I32674_VerifyDiscountOnReloadTicket and
I32699_VerifyFirmQuotationIssue test case

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I32674_VerifyDiscountOnReloadTicket.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32699_VerifyFirmQuotationIssue.java
---