Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042044Openbravo ERPA. Platformpublic2019-10-16 17:592019-12-12 23:01
Reportercaristu 
Assigned Tocaristu 
PrioritylowSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0042044: Duplicated code in ScheduleProcess and RescheduleProcess
DescriptionScheduleProcess and RescheduleProcess contain almost the same code. It would be nice to remove this duplication.
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0042041 closed caristu The error message when rescheduling a process fails is not translatable 
related to design defect 0028406 closed aferraz RescheduleProcess class should be able to get requestId from request parameters 
related to defect 0042049 new Triage Platform Base RescheduleProcess should be removed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-16 17:59caristuNew Issue
2019-10-16 17:59caristuAssigned To => caristu
2019-10-16 17:59caristuModules => Core
2019-10-16 17:59caristuTriggers an Emergency Pack => No
2019-10-16 17:59caristuIssue generated from0042041
2019-10-16 17:59caristuRelationship addedrelated to 0042041
2019-10-16 17:59caristuRelationship addedrelated to 0028406
2019-10-17 09:07caristuIssue cloned0042049
2019-10-17 09:07caristuRelationship addedrelated to 0042049
2019-10-17 09:25hgbotCheckin
2019-10-17 09:25hgbotNote Added: 0115134
2019-10-17 09:25hgbotStatusnew => resolved
2019-10-17 09:25hgbotResolutionopen => fixed
2019-10-17 09:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e14fc97efb5631de3e489fe7591695e771a6600d [^]
2019-10-17 09:26caristuReview Assigned To => alostale
2019-10-18 07:36alostaleNote Added: 0115153
2019-10-18 07:36alostaleStatusresolved => closed
2019-10-18 07:36alostaleFixed in Version => 3.0PR20Q1
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116254

Notes
(0115134)
hgbot   
2019-10-17 09:25   
Repository: erp/devel/pi
Changeset: e14fc97efb5631de3e489fe7591695e771a6600d
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Wed Oct 16 18:46:22 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e14fc97efb5631de3e489fe7591695e771a6600d [^]

fixes issue 42044: Duplicated code in ScheduleProcess and RescheduleProcess

  - RescheduleProcess now extends ScheduleProcess as their
implementation was almost the same.

  - Added additional minor code improvement in ScheduleProcess.

---
M src/org/openbravo/erpCommon/ad_process/RescheduleProcess.java
M src/org/openbravo/erpCommon/ad_process/ScheduleProcess.java
---
(0115153)
alostale   
2019-10-18 07:36   
reviewed
(0116254)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test