Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0042023Openbravo ERP09. Financial managementpublic2019-10-15 13:562019-12-12 23:01
ReporterAtulOpenbravo 
Assigned Toinigo_lerga 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2019-07-04
Regression introduced in releasemain
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/ff5106481e824ee169ac43f2f5b2d42fdf93104a [^]
Triggers an Emergency PackNo
Summary0042023: In End Year Close window Accounting Tab FinancialMgmtPeriod.getfinancialMgmtPeriodControlList is needed
DescriptionIn End Year Close window Accounting Tab FinancialMgmtPeriod.getfinancialMgmtPeriodControlList is needed but As part of this issue [1], some one-to-many child methods were removed, assuming that they were not in use.

[1] https://issues.openbravo.com/view.php?id=40906 [^] [^]
Steps To ReproduceIn livebuilds
- Navigate to End Year Close window
- Select any record
- Realize that error is shown in Accounting Tab message box and no records are shown. See attached screenshot.
Proposed SolutionProposed solution is attached. It sets C_PeriodControl table's C_Period_ID column's is_child_property_in_parent flag = Yes, so that child property i.e financialMgmtPeriodControlList is included in its parent i.e FinancialMgmtPeriod
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00420283.0PR19Q4 closed inigo_lerga In End Year Close window Accounting Tab FinancialMgmtPeriod.getfinancialMgmtPeriodControlList is needed 
caused by feature request 00412283.0PR19Q4 closed vmromanos One-to-many clean up of existing columns (Functional) 
Attached Filespng IsChildPropertyInParentEntity_Affected.png (166,053) 2019-10-15 13:56
https://issues.openbravo.com/file_download.php?file_id=13401&type=bug
png

diff Raw_0042023_proposal.diff (662) 2019-10-15 13:58
https://issues.openbravo.com/file_download.php?file_id=13402&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-10-15 13:56AtulOpenbravoNew Issue
2019-10-15 13:56AtulOpenbravoAssigned To => platform
2019-10-15 13:56AtulOpenbravoFile Added: IsChildPropertyInParentEntity_Affected.png
2019-10-15 13:56AtulOpenbravoOBNetwork customer => No
2019-10-15 13:56AtulOpenbravoModules => Core
2019-10-15 13:56AtulOpenbravoRegression level => Production - QA Approved
2019-10-15 13:56AtulOpenbravoRegression date => 2019-05-21
2019-10-15 13:56AtulOpenbravoRegression introduced in release => 3.0PR19Q3
2019-10-15 13:56AtulOpenbravoRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/4dc58edab48f2f9e20cfce74f557827e43919803 [^]
2019-10-15 13:56AtulOpenbravoTriggers an Emergency Pack => No
2019-10-15 13:58AtulOpenbravoFile Added: Raw_0042023_proposal.diff
2019-10-15 15:21SandrahuguetAssigned Toplatform => inigo_lerga
2019-10-15 15:22SandrahuguetStatusnew => scheduled
2019-10-15 15:31SandrahuguetRegression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/4dc58edab48f2f9e20cfce74f557827e43919803 [^] => https://code.openbravo.com/erp/devel/pi/rev/ff5106481e824ee169ac43f2f5b2d42fdf93104a [^]
2019-10-15 15:33SandrahuguetRelationship addedcaused by 0041228
2019-10-16 13:01inigo_lergaRegression levelProduction - QA Approved => Packaging and release
2019-10-16 13:01inigo_lergaRegression date2019-05-21 => 2019-07-04
2019-10-16 13:01inigo_lergaRegression introduced in release3.0PR19Q3 => main
2019-10-17 09:48inigo_lergaNote Added: 0115135
2019-10-22 09:01hgbotCheckin
2019-10-22 09:01hgbotNote Added: 0115198
2019-10-22 09:01hgbotStatusscheduled => resolved
2019-10-22 09:01hgbotResolutionopen => fixed
2019-10-22 09:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f6687b97b12c26c8e7cfecccb91bd87440a888f4 [^]
2019-10-22 09:03SandrahuguetReview Assigned To => Sandrahuguet
2019-10-22 09:03SandrahuguetNote Added: 0115200
2019-10-22 09:03SandrahuguetStatusresolved => closed
2019-10-22 09:03SandrahuguetFixed in Version => 3.0PR20Q1
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116257

Notes
(0115135)
inigo_lerga   
2019-10-17 09:48   
Test Plan:
As group admin role:
   Go to End Year Close window and select any record.

   Realize that error is shown in Accounting Tab message box and no records are
   shown.
(0115198)
hgbot   
2019-10-22 09:01   
Repository: erp/devel/pi
Changeset: f6687b97b12c26c8e7cfecccb91bd87440a888f4
Author: Iñigo Lerga <inigo.lerga <at> openbravo.com>
Date: Wed Oct 16 14:05:16 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f6687b97b12c26c8e7cfecccb91bd87440a888f4 [^]

Fixes issue 42023: C_PeriodControl table's C_Period_ID column's is_child_property_in_parent flag set to Yes

It sets C_PeriodControl table's C_Period_ID column's is_child_property_in_parent flag = Yes, so that child property i.e financialMgmtPeriodControlList is included in its parent i.e FinancialMgmtPeriod

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0115200)
Sandrahuguet   
2019-10-22 09:03   
code review + testing ok
(0116257)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test