Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041978Openbravo ERPA. Platformpublic2019-10-10 10:422019-12-12 23:01
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q1 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041978: Import Entry data types without sequence should be sumbitted in last place
DescriptionWhen Import Entry Manager submits new entries to be processed they are grouped by their type of data, these types of data are sorted among them based on their reference list's sequence number.

When they don't have any sequence number defined, 50 is arbitrarily taken.

As there are types with a sequence bigger than 50, they are place in between.

Note there are types defined in standard retail pack without sequence number:

          value          | seqno 
-------------------------+-------
 BusinessPartner         |    10
 BusinessPartnerLocation |    20
 Order                   |    30
 FIN_Finacc_Transaction  |    40
 OBPOS_App_Cashup        |    60
 OBMOBC_ServerMessage    |    70
 OBPOS_RejectQuotation   |    80
 OBPOS_VoidLayaway       |    90
 OBPOS_IsOrderCancelled  |      
 OBPOS_CancelLayaway     |      
 OBMOBC_TerminalLog      |      
 VariantChDescUpdate     |      
 OBMOBC_SynchronizedData |      
 OBPOS_ExternalOrder     |      
(14 rows)
Steps To Reproduce-
Proposed SolutionThose types without any sequence should be placed after the rest.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0040747 closed alostale Unnecessary wait in Import Entry Manager is causing lag in the processing of import entries even if resources are available 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-10 10:42alostaleNew Issue
2019-10-10 10:42alostaleAssigned To => platform
2019-10-10 10:42alostaleOBNetwork customer => No
2019-10-10 10:42alostaleModules => Core
2019-10-10 10:42alostaleTriggers an Emergency Pack => No
2019-10-10 10:42alostaleAssigned Toplatform => alostale
2019-10-10 10:43alostaleRelationship addedrelated to 0040747
2019-10-10 10:53alostaleDescription Updatedbug_revision_view_page.php?rev_id=19460#r19460
2019-10-10 16:59alostaleReview Assigned To => AugustoMauch
2019-10-15 15:40hgbotCheckin
2019-10-15 15:40hgbotNote Added: 0115091
2019-10-15 15:40hgbotCheckin
2019-10-15 15:40hgbotNote Added: 0115092
2019-10-15 15:40hgbotCheckin
2019-10-15 15:40hgbotNote Added: 0115093
2019-10-15 15:40hgbotStatusnew => resolved
2019-10-15 15:40hgbotResolutionopen => fixed
2019-10-15 15:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a3921129c596453af53ed072005e0da5faeadb61 [^]
2019-10-18 14:37AugustoMauchNote Added: 0115170
2019-10-18 14:37AugustoMauchStatusresolved => closed
2019-10-18 14:37AugustoMauchFixed in Version => 3.0PR20Q1
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116245
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116246
2019-12-12 23:01hudsonbotCheckin
2019-12-12 23:01hudsonbotNote Added: 0116247

Notes
(0115091)
hgbot   
2019-10-15 15:40   
Repository: erp/devel/pi
Changeset: 8d1010cc889212d36fb75ccd35d5e411f9e89ca7
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 10 14:26:44 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/8d1010cc889212d36fb75ccd35d5e411f9e89ca7 [^]

related to issue 41978: code clean up

  Using stream and lambdas to make simpler list sorting with comparator.

---
M src/org/openbravo/service/importprocess/ImportProcessUtils.java
---
(0115092)
hgbot   
2019-10-15 15:40   
Repository: erp/devel/pi
Changeset: 392289cba2acf4858ddbc515adee9daaf341f1ef
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 10 16:38:38 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/392289cba2acf4858ddbc515adee9daaf341f1ef [^]

related to issue 41978: keep stable order

  For elements with same sequence order also by id so that a stable
  order is maintained.

---
M src/org/openbravo/service/importprocess/ImportProcessUtils.java
---
(0115093)
hgbot   
2019-10-15 15:40   
Repository: erp/devel/pi
Changeset: a3921129c596453af53ed072005e0da5faeadb61
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 10 16:41:13 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a3921129c596453af53ed072005e0da5faeadb61 [^]

fixed issue 41978: Import Entry types without sequence sumbitted in last place

  Data types that do not have a sequnece number are now submitted to be
  processed after all the rest.

---
M src/org/openbravo/service/importprocess/ImportProcessUtils.java
---
(0115170)
AugustoMauch   
2019-10-18 14:37   
Code reviewed and verified
(0116245)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test
(0116246)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test
(0116247)
hudsonbot   
2019-12-12 23:01   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/954d2b7a66fb [^]
Maturity status: Test