Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041960Retail ModulesWeb POSpublic2019-10-09 12:052019-10-23 12:29
Reportersamuel_nicuesa 
Assigned Torqueralta 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerGold
Support ticket121777
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041960: Delete discount button is not working if the discount is over 1000
DescriptionDelete discount button is not working if the discount is over 1000.
Steps To Reproduce[POS]
Add a product to the ticket
Change the price to 90000because the discount will be > 1000.
Add the discount 29000
Select the product line and try to delete the discount
You will see the following error (see the attached image)

Proposed SolutionApply the parseFloat to this line:

line.$.price.content
"-29,000.00"
line.$.price.content = parseFloat(line.$.price.content);
-29
See the attached image
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng DeleteDiscount.png (244,465) 2019-10-09 12:05
https://issues.openbravo.com/file_download.php?file_id=13357&type=bug
png

png Solution.png (91,820) 2019-10-09 12:06
https://issues.openbravo.com/file_download.php?file_id=13358&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-10-09 12:05samuel_nicuesaNew Issue
2019-10-09 12:05samuel_nicuesaAssigned To => Retail
2019-10-09 12:05samuel_nicuesaFile Added: DeleteDiscount.png
2019-10-09 12:05samuel_nicuesaOBNetwork customer => Gold
2019-10-09 12:05samuel_nicuesaSupport ticket => 121777
2019-10-09 12:05samuel_nicuesaResolution time => 1572390000
2019-10-09 12:05samuel_nicuesaTriggers an Emergency Pack => No
2019-10-09 12:06samuel_nicuesaFile Added: Solution.png
2019-10-09 17:17rqueraltaAssigned ToRetail => rqueralta
2019-10-09 17:18rqueraltaStatusnew => scheduled
2019-10-21 04:53hgbotCheckin
2019-10-21 04:53hgbotNote Added: 0115173
2019-10-21 04:53hgbotStatusscheduled => resolved
2019-10-21 04:53hgbotResolutionopen => fixed
2019-10-21 04:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64e9b6d49bfa679374b45c61149f475108ee8966 [^]
2019-10-23 12:29marvintmReview Assigned To => marvintm
2019-10-23 12:29marvintmStatusresolved => closed
2019-10-23 12:29marvintmFixed in Version => RR20Q1

Notes
(0115173)
hgbot   
2019-10-21 04:53   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 64e9b6d49bfa679374b45c61149f475108ee8966
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Oct 11 18:31:17 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64e9b6d49bfa679374b45c61149f475108ee8966 [^]

Fixed issue 41960: Delete discount button is not working if the discount is over
1000

- Applied parseFloat to price value to avoid a javascript error when this value is
converted to number

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalDeleteDiscounts.js
---