Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041946Openbravo ERP07. Sales managementpublic2019-10-08 12:132020-03-20 17:54
Reporterfrancisco 
Assigned Tomarkmm82 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR20Q2 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket12022
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041946: The filter in product with characteristics shows characteristics that doesn't belongs to the product
DescriptionWhen you go to Manage Variants in the product window, for product that have characteristics, the pop up to filter shows characteristics that doesn't belong to the product
Steps To ReproduceTested in retail_pi_pgsql:

Go to product window
Choose a product with characteristics (Dry fit Run)
Click on manage variant
The pop up filter show you characteristics that the product doesn't has

If you have many characteristics it is complicated to filter
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_811.png (103,938) 2019-10-08 12:13
https://issues.openbravo.com/file_download.php?file_id=13351&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2019-10-08 12:13franciscoNew Issue
2019-10-08 12:13franciscoAssigned To => Triage Finance
2019-10-08 12:13franciscoFile Added: Selection_811.png
2019-10-08 12:13franciscoOBNetwork customer => OBPS
2019-10-08 12:13franciscoModules => Core
2019-10-08 12:13franciscoSupport ticket => 12022
2019-10-08 12:13franciscoResolution time => 1572303600
2019-10-08 12:13franciscoTriggers an Emergency Pack => No
2019-10-08 12:15PracticsIssue Monitored: Practics
2019-10-08 15:55SandrahuguetAssigned ToTriage Finance => markmm82
2019-10-08 15:55SandrahuguetSeveritymajor => minor
2019-10-09 02:38markmm82Statusnew => scheduled
2019-10-10 15:36markmm82Note Added: 0115004
2019-10-23 08:36SandrahuguetResolution time1572303600 =>
2020-01-08 16:46hgbotCheckin
2020-01-08 16:46hgbotNote Added: 0116702
2020-01-08 16:46hgbotStatusscheduled => resolved
2020-01-08 16:46hgbotResolutionopen => fixed
2020-01-08 16:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/38b22cf9b346219ec536cb5cce16215086949054 [^]
2020-01-08 16:53dmiguelezReview Assigned To => dmiguelez
2020-01-08 16:53dmiguelezNote Added: 0116704
2020-01-08 16:53dmiguelezStatusresolved => closed
2020-01-08 16:53dmiguelezFixed in Version => 3.0PR20Q2
2020-03-20 17:54hudsonbotCheckin
2020-03-20 17:54hudsonbotNote Added: 0118723

Notes
(0115004)
markmm82   
2019-10-10 15:36   
Test Plan:
Tested in retail_pi_pgsql:

As White Valley Group Admin
  Go to product window
  Choose Dry fit Run (product with characteristics)
  Click on manage variant
  Click on Characteristic Description filter
  Notice the popup filter show only characteristics that belong to the product (Size: L, M, S)
(0116702)
hgbot   
2020-01-08 16:46   
Repository: erp/devel/pi
Changeset: 38b22cf9b346219ec536cb5cce16215086949054
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Thu Oct 10 10:22:45 2019 -0300
URL: http://code.openbravo.com/erp/devel/pi/rev/38b22cf9b346219ec536cb5cce16215086949054 [^]

Fixes issue 41946: Filter only by characteristics that belong to the product

The filter in product with characteristics was showing characteristics that didn't
belong to the product. Was fixed the query to take into account just the characteristic
subset (if exists) of the product characteristic and not all the existing ones.

---
M src/org/openbravo/materialmgmt/ManageVariantsCustomProductCharacteristicWhereClause.java
---
(0116704)
dmiguelez   
2020-01-08 16:53   
Code Review + Testing Ok
(0118723)
hudsonbot   
2020-03-20 17:54   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b31620115262 [^]
Maturity status: Test