Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041938Openbravo ERP07. Sales managementpublic2019-10-04 22:332019-10-11 09:14
Reporterlbressan 
Assigned Tomarkmm82 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR19Q2.4Fixed in Version3.0PR19Q2.4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression levelPre packaging ( pi )
Regression date2019-09-05
Regression introduced in releasemain
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041938: Modify Payment Plan shows invalid amount when changing payment methods.
DescriptionIn some cases, using the Modify Payment Plan feature will show that the Outstanding Amount is invalid when is not the case.
For example, when having several Payment Plan records, and only one remaining to be paid, the Payment Method cannot be changed (even without altering Outstanding Amount) using the Modify Payment Plan.
This happens after commit from issue: https://issues.openbravo.com/view.php?id=41732 [^]

The problem happens because the total invoice amount is considered when validating the Outstanding Amount. But since the other payment plans are paid (and not shown in the pop up grid), the amounts will never match, giving the error to the user.
Steps To Reproduce1. Create and complete a sales invoice with total amount 1500.
2. Use Modify Payment Plan to create two more payment plans and divide the amount between the three.
3. Remaining Payment Plans should be as following:
Payment Plan 1: 500
Payment Plan 2: 500
Payment Plan 3: 500
4. Pay any two payment plans fully.
5. Pay partially the las payment plan.
6. Use Modify Payment Plan again to change that same payment plan's payment method.
7. Outstanding Amount will be colored Red with a message saying that the value is incorrect. Even though it was not changed.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041935 closed markmm82 Modify Payment Plan shows invalid amount when changing payment methods. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-07 08:55SandrahuguetTypedefect => backport
2019-10-07 08:56SandrahuguetTarget Version => 3.0PR19Q2.4
2019-10-11 09:12hgbotCheckin
2019-10-11 09:12hgbotNote Added: 0115024
2019-10-11 09:12hgbotStatusscheduled => resolved
2019-10-11 09:12hgbotResolutionopen => fixed
2019-10-11 09:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.4/rev/d849f42388f95e11a0aa3050223690b14cf9892d [^]
2019-10-11 09:14SandrahuguetReview Assigned To => Sandrahuguet
2019-10-11 09:14SandrahuguetNote Added: 0115030
2019-10-11 09:14SandrahuguetStatusresolved => closed
2019-10-11 09:14SandrahuguetFixed in Version => 3.0PR19Q2.4

Notes
(0115024)
hgbot   
2019-10-11 09:12   
Repository: erp/backports/3.0PR19Q2.4
Changeset: d849f42388f95e11a0aa3050223690b14cf9892d
Author: Mark Molina <mark.molina <at> doceleguas.com>
Date: Mon Oct 07 20:35:07 2019 -0300
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.4/rev/d849f42388f95e11a0aa3050223690b14cf9892d [^]

Fixes issue 41938: Take into account total paid when calculating the outstanding
amount of lines when using the Modify Payment Plan feature.

In some cases, using the Modify Payment Plan feature was shoing that the Outstanding Amount
was invalid because the total invoice amount was considered when validating the Outstanding Amount
but wasn't taking into account the other payment plans already paid.
The issue on this situation was to to get the received amount from records shown in
the grid, as those lines already paid are not shown in the pop up grid, the amount
don'tr match and an error is shown to the user.

To fix this issue is validated that the total Outstanding amount is exactly the difference
between the invoice grand total and the total invoice amount already paid

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0115030)
Sandrahuguet   
2019-10-11 09:14   
code review + testing ok