Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041931Retail ModulesWeb POSpublic2019-09-13 09:202019-10-24 17:03
Reportermigueldejuana 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR19Q4Fixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041931: Polling could be not launched due to asynchrony
DescriptionIn polling we have messages to poll in a "notStarted" collection. At some point we move messages from there to messagesByModel in dataSyncModels to be used in polling process. To launch polling process we check "noStarted" collection but we do not check messagesByModel, so if we move messages from noStarted to messagesByModel and then we check if we have to launch polling, it won't be launched.
Steps To Reproducen/a
Proposed SolutionCheck both notStarted and messagesByModel
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041811 closed gorka_gil Polling could be not launched due to asynchrony 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-04 10:28gorka_gilTypedefect => backport
2019-10-04 10:28gorka_gilTarget Version => RR19Q4
2019-10-04 12:51hgbotCheckin
2019-10-04 12:51hgbotNote Added: 0114922
2019-10-04 12:51hgbotStatusscheduled => resolved
2019-10-04 12:51hgbotResolutionopen => fixed
2019-10-04 12:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1919148245f7d65b02f6b88afb46399f7eb32536 [^] => http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/c30e24e38ea642b41c4a03c2064cb0f3316b52b3 [^]
2019-10-04 12:51hgbotCheckin
2019-10-04 12:51hgbotNote Added: 0114923
2019-10-04 12:51hgbotCheckin
2019-10-04 12:51hgbotNote Added: 0114924
2019-10-04 12:52gorka_gilNote Added: 0114925
2019-10-04 12:52gorka_gilNote Edited: 0114925bug_revision_view_page.php?bugnote_id=0114925#r19425
2019-10-08 10:57gorka_gilNote Added: 0114947
2019-10-08 10:57gorka_gilStatusresolved => new
2019-10-08 10:57gorka_gilResolutionfixed => open
2019-10-08 11:00hgbotCheckin
2019-10-08 11:00hgbotNote Added: 0114948
2019-10-08 11:00hgbotCheckin
2019-10-08 11:00hgbotNote Added: 0114949
2019-10-08 11:00gorka_gilStatusnew => scheduled
2019-10-08 11:01gorka_gilStatusscheduled => resolved
2019-10-08 11:01gorka_gilResolutionopen => fixed
2019-10-24 17:03marvintmReview Assigned To => marvintm
2019-10-24 17:03marvintmStatusresolved => closed
2019-10-24 17:03marvintmFixed in Version => RR19Q4

Notes
(0114922)
hgbot   
2019-10-04 12:51   
Repository: retail/backports/3.0RR19Q4/org.openbravo.mobile.core
Changeset: c30e24e38ea642b41c4a03c2064cb0f3316b52b3
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Sep 27 13:44:12 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/c30e24e38ea642b41c4a03c2064cb0f3316b52b3 [^]

Fixed issue 41931: Polling could be not launched due to asynchrony

- Check also messagesByModel because we could moved messages from noStarted to messagesByModel due to asynchrony

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---
(0114923)
hgbot   
2019-10-04 12:51   
Repository: retail/backports/3.0RR19Q4/org.openbravo.mobile.core
Changeset: e03bbacf7072f62ab7e28b2ff0c1193c9c489056
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Sep 27 14:31:23 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/e03bbacf7072f62ab7e28b2ff0c1193c9c489056 [^]

Related to issue 41931: change the way to check if there is pending models to start the polling

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0114924)
hgbot   
2019-10-04 12:51   
Repository: retail/backports/3.0RR19Q4/org.openbravo.mobile.core
Changeset: e199b75af9c365d7af13e10024b8f8db884eff04
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Oct 02 17:30:30 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/e199b75af9c365d7af13e10024b8f8db884eff04 [^]

Related to issue 41931: when retry a polling it start a new process, but if is already running this new process should be terminated

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---
(0114925)
gorka_gil   
2019-10-04 12:52   
Repository: retail/backports/3.0RR19Q4/pi-mobile
Changeset: 7d1026a1402b1c816da8e3d9066642c4f27563b2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Oct 02 14:14:32 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/pi-mobile/rev/7d1026a1402b1c816da8e3d9066642c4f27563b2 [^]

Related to issue 41811: Fix loyalty tests in oracle

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesLoyaltyTerminalHelper.java
---
(0114947)
gorka_gil   
2019-10-08 10:57   
reopen because breaks awo
(0114948)
hgbot   
2019-10-08 11:00   
Repository: retail/backports/3.0RR19Q4/org.openbravo.mobile.core
Changeset: 728560a398a42ff746aa1d56e42d0b6b72f5f12a
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 07 13:14:23 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/728560a398a42ff746aa1d56e42d0b6b72f5f12a [^]

Related to issue 41931: Backed out changeset e03bbacf7072f62ab7e28b2ff0c1193c9c489056

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0114949)
hgbot   
2019-10-08 11:00   
Repository: retail/backports/3.0RR19Q4/org.openbravo.mobile.core
Changeset: 8785d9b749f264673e12ef29334242969c7c5874
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Oct 07 14:46:54 2019 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR19Q4/org.openbravo.mobile.core/rev/8785d9b749f264673e12ef29334242969c7c5874 [^]

Related to issue 41931: split the code of get the models to sync from the code to move the models from pending list to ongoing list

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---