Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041910Retail ModulesWeb POSpublic2019-10-01 17:432019-12-18 16:38
Reporterkchoperena 
Assigned Torqueralta 
PriorityhighSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041910: The 'Assign Customer' button of 'View Details' window is launching a BPLocation query without id
DescriptionPREFERENCE: Enable Remote for Customer=Y

In the customers selector, in the context menu, if we open the 'View Details' window and click on 'Assign Customer' the Web POS is executing 4 times the BPLocation query:
1.- BPLocation -> Without id location value
2.- BPLocation -> Without id location value
3.- BPLocation -> With expected id location value
4.- BPLocation -> With expected id location value

NOTE: In BUT, as the query is executing without id, postgresql creates temporal files to manage the result data
Steps To Reproduce1.- Log into the WebPOS
2.- Do an empty search in the customer selector
3.- Using the context menu, click on 'View Details' button
4.- Click on 'Assign Customer' button

EXPECTED RESULT:
Check in the developer tools executed BPLocation queries, will be 4.

NOTE: If you execute again the flow using the same customer, you should only have 2 queries that are correct.

Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0042599RR19Q4.1 closed rqueralta The 'Assign Customer' button of 'View Details' window is launching a BPLocation query without id 
depends on backport 0042600RR19Q3.2 closed rqueralta The 'Assign Customer' button of 'View Details' window is launching a BPLocation query without id 
related to defect 0042386 closed ranjith_qualiantech_com BP location is not being changed in the ticket even though we have two different addresses for a BP in POS 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-10-01 17:43kchoperenaNew Issue
2019-10-01 17:43kchoperenaAssigned To => Retail
2019-10-01 17:43kchoperenaResolution time => 1571004000
2019-10-01 17:43kchoperenaTriggers an Emergency Pack => No
2019-10-01 17:50kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=19421#r19421
2019-10-01 18:04ALopeteguiIssue Monitored: ALopetegui
2019-10-01 19:50rqueraltaAssigned ToRetail => rqueralta
2019-10-01 23:28rqueraltaStatusnew => scheduled
2019-10-10 15:13hgbotCheckin
2019-10-10 15:13hgbotNote Added: 0115002
2019-10-10 15:14hgbotStatusscheduled => resolved
2019-10-10 15:14hgbotResolutionopen => fixed
2019-10-10 15:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5d33385adfb1bc9c62397936c2c16216c43bd629 [^]
2019-10-14 15:31hgbotCheckin
2019-10-14 15:31hgbotNote Added: 0115072
2019-10-18 12:36marvintmStatusresolved => new
2019-10-18 12:36marvintmResolutionfixed => open
2019-10-21 04:51hgbotCheckin
2019-10-21 04:51hgbotNote Added: 0115172
2019-10-21 04:51hgbotStatusnew => resolved
2019-10-21 04:51hgbotResolutionopen => fixed
2019-10-21 04:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5d33385adfb1bc9c62397936c2c16216c43bd629 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e05daa1f380293e80c3fd810097572f53ebd7b42 [^]
2019-10-23 15:45marvintmReview Assigned To => marvintm
2019-10-23 15:45marvintmStatusresolved => closed
2019-10-23 15:45marvintmFixed in Version => RR20Q1
2019-11-26 13:29guilleaerRelationship addedrelated to 0042386
2019-11-26 13:40guilleaerNote Added: 0115835
2019-12-18 16:37marvintmSeveritymajor => critical
2019-12-18 16:37marvintmStatusclosed => new
2019-12-18 16:37marvintmResolutionfixed => open
2019-12-18 16:37marvintmFixed in VersionRR20Q1 =>
2019-12-18 16:38marvintmStatusnew => scheduled
2019-12-18 16:38marvintmStatusscheduled => resolved
2019-12-18 16:38marvintmFixed in Version => RR20Q1
2019-12-18 16:38marvintmResolutionopen => fixed
2019-12-18 16:38marvintmStatusresolved => closed

Notes
(0115002)
hgbot   
2019-10-10 15:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5d33385adfb1bc9c62397936c2c16216c43bd629
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Oct 04 18:16:24 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5d33385adfb1bc9c62397936c2c16216c43bd629 [^]

Fixed issue 41910: The 'Assign Customer' button of 'View Details' window is
launching a BPLocation query without id

- Seted locations id for BLocation query when remote customer preference was
enabled

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0115072)
hgbot   
2019-10-14 15:31   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9466f1277dff0125957f87d9dde5b1d35d6017ee
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 14 15:25:08 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9466f1277dff0125957f87d9dde5b1d35d6017ee [^]

Related to issue 41910: Backed out changeset 5d33385adfb1

Some tests are failing

I37600_VerifyNewCustomerReceipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0115172)
hgbot   
2019-10-21 04:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e05daa1f380293e80c3fd810097572f53ebd7b42
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Fri Oct 18 22:41:22 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e05daa1f380293e80c3fd810097572f53ebd7b42 [^]

Fixed issue 41910: The 'Assign Customer' button of 'View Details' window is
launching a BPLocation query without id

- Seted locations id for BLocation query when remote customer preference was
enabled

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0115835)
guilleaer   
2019-11-26 13:40   
A new fix for this issue has been created

http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b08eea5a0378790b5f17d27e2e1dbf629609c638 [^]

This fix reverts changeset [http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e05daa1f380293e80c3fd810097572f53ebd7b42 [^]] and add required code to fix this issue