0041880: Error on window Match Statements for operations with different currencies.

Openbravo Issue Tracking System - Openbravo ERP
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0041880	Openbravo ERP	09. Financial management	public	2019-09-25 02:43	2019-12-31 10:51

Reporter	agonzalez
Assigned To	markmm82
Priority	normal	Severity	major	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform		OS	5	OS Version
Product Version	3.0PR17Q2.4
Target Version		Fixed in Version	3.0PR20Q1
Merge Request Status
Review Assigned To	aferraz
OBNetwork customer	OBPS
Web browser	Google Chrome
Modules	Core
Support ticket	11832
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0041880: Error on window Match Statements for operations with different currencies.
Description	When using different currencies and adding a payment to a transaction inside a Match using the "Match Statements" functionality inside Financial Account window, the "Actual Payment" field does not changes when inserting another currency. The "Actual Payment" field should change depending on the currency selected, but it's only showing the amount converted to the bank account currency. This cause the "Converted Amount" showing incorrect values when using another currency and making impossible to create a payment in other currency that the one configured on the bank. Livebuild reproduction: https://drive.google.com/file/d/1Hs71_itP0eDg3obXqqBvDBaGsYkeuxsl/view [^]
Steps To Reproduce	Note: The payment method used has to have enabled the "Receive payments in multiple currencies" and the "Make payments in multiple currencies" checks. 1. Go to Financial Account window 2. Select a Financial Account with type "Bank" that contains more than one bank statement lines 3. Click on "Match Statements" button to open the pop-up 4. Select a match (The price will be displayed on the bank account currency) 5. Click on "Add transaction" button 6. Add a new payment through the "Plus" button on the "Payment" field. 7. Select a payment method with multiple currencies payment capabilities. At this point, it will be displayed by default the currency configured at the bank account. 8. Select another currency 9. The currency will not be converted on the field "Actual Payment" method, showing the currency assigned by default (the currency of the bank) making unable to create a payment for another currency and setting up an incorrect value on "Converted Amount".
Proposed Solution	Update the "Actual Payment" field when the currency changes.
Additional Information
Tags	No tags attached.
Relationships
Attached Files

Issue History
Date Modified	Username	Field	Change
2019-09-25 02:43	agonzalez	New Issue
2019-09-25 02:43	agonzalez	Assigned To	=> Triage Finance
2019-09-25 02:43	agonzalez	Web browser	=> Google Chrome
2019-09-25 02:43	agonzalez	Modules	=> Core
2019-09-25 02:43	agonzalez	Triggers an Emergency Pack	=> No
2019-09-25 03:17	mgonzalezh	Issue Monitored: mgonzalezh
2019-10-21 17:12	lbressan	OBNetwork customer	=> OBPS
2019-10-21 17:12	lbressan	Web browser	Google Chrome => Google Chrome
2019-10-21 17:12	lbressan	Support ticket	=> 11832
2019-10-21 17:12	lbressan	Resolution time	=> 1572822000
2019-10-21 17:36	Sandrahuguet	Assigned To	Triage Finance => markmm82
2019-10-22 03:11	markmm82	Status	new => scheduled
2019-10-23 05:57	markmm82	Note Added: 0115238
2019-10-23 22:06	markmm82	Note Edited: 0115238	bug_revision_view_page.php?bugnote_id=0115238#r19556
2019-10-29 12:46	Sandrahuguet	Web browser	Google Chrome => Google Chrome
2019-10-29 12:46	Sandrahuguet	Resolution time	1572822000 => 1573426800
2019-11-13 12:46	hgbot	Checkin
2019-11-13 12:46	hgbot	Note Added: 0115574
2019-11-13 12:46	hgbot	Status	scheduled => resolved
2019-11-13 12:46	hgbot	Resolution	open => fixed
2019-11-13 12:46	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/e1420ea3bd437e19c1e28cfeac92de55be882974 [^]
2019-11-13 12:46	hgbot	Checkin
2019-11-13 12:46	hgbot	Note Added: 0115575
2019-11-13 12:46	aferraz	Review Assigned To	=> aferraz
2019-11-13 12:46	aferraz	Note Added: 0115576
2019-11-13 12:46	aferraz	Status	resolved => closed
2019-11-13 12:46	aferraz	Fixed in Version	=> 3.0PR20Q1
2019-11-18 22:38	markmm82	Note Added: 0115675
2019-11-19 09:20	aferraz	Note Edited: 0115675	bug_revision_view_page.php?bugnote_id=0115675#r19724
2019-11-19 09:25	aferraz	Note Edited: 0115675	bug_revision_view_page.php?bugnote_id=0115675#r19725
2019-12-12 23:01	hudsonbot	Checkin
2019-12-12 23:01	hudsonbot	Note Added: 0116280
2019-12-12 23:01	hudsonbot	Checkin
2019-12-12 23:01	hudsonbot	Note Added: 0116281
2019-12-31 10:51	hgbot	Checkin
2019-12-31 10:51	hgbot	Note Added: 0116586

Notes

Test PLan:

Go to Price List window and create a new Purchase price list header:
  Organization = F&B US, Inc.
  Name = Be Soft Drinker Price List EUR
  Currency = EUR
Add a new Price List Version to it.
Add a Product Price to Cherry Cola:
  Product = Cherry Cola
  Unit Price = List Price = 0.50

Go to Purchase Invoice window and create a new header.
  Organization = F&B US, Inc.
  Business Partner = Be Soft Drinker, Inc.
  Payment Method = Wire Transfer
  Price List = Be Soft Drinker Price List EUR

Add a line to it:
  Product = Cherry Cola
  Quantity = 100
  Unit Price = 0.50

Complete the Invoice.
  Notice we have a Total Amount of 50 EUR (equivalent to 57 USD with a conversion rate of 1.14)

Go to Financial Account window and select Bank - Account 2.
Set Matching Algorithm = Standard.

Go to Payment Method Tab and select Wire Transfer.
Configure to accept/make payments in multi currencies.
  Receive Payments in Multiple Currencies = Yes
  Make Payments in Multiple Currencies.

Go to Imported Bank Statements tab and create a new one.
Go to Bank Statement Lines and create a new one to be matched with the previously created invoice:
  Business Partner = Be Soft Drinker, Inc.
  Amount OUT = 57 USD (It is the equivalent to 50 EUR if we convert it using a conversion rate of 1.14)
Process the Bank Statement.

Click on "Match Statements" button to open the pop-up
Select a match (The price will be displayed on the bank account currency)
Click on "Add transaction" button
Go to add a new payment through the "Plus" button on the "Payment" field.

At this point, it will be displayed by default the currency configured at the bank account in this case it shows 57 USD as Actual Payment.

Select another currency, for example EUR.
Notice Actual Payment was updated to 50 EUR.
The conversion rate from EUR to USD can vary according date, in our case it is having a conversion rate of 1.17 so the converted amount is 58.50.

Change the currency to USD.
Notice Actual Payment was updated to 57 USD.

Change the currency to EUR.
Notice Actual Payment was updated to 50 EUR.

As we want to match the invoice amount and the bank statement with the same rate, we are going to change the conversion rate to 1.14.
Notice the converted amount was updated to 57.00 USD.
Press Done.

Press Done again and notice the Match was successfully and the statement dissapears from pending to be matched.