0041862: Order Selector no longer verifies if an order is in error status (import entry error/error while importing)

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0041862

Retail Modules

Web POS

public

2019-09-18 12:56

2019-09-27 09:41

Reporter

aaroncalero

Assigned To

ranjith_qualiantech_com

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR19Q3.1

Fixed in Version

RR19Q3.1

Merge Request Status

Review Assigned To

jorge-garcia

OBNetwork customer

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2017-11-24

Regression introduced in release

RR18Q1

Regression introduced by commit

http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a43d2a1ce34121b644a806d761857b224f27a184 [^]

Triggers an Emergency Pack

Summary

0041862: Order Selector no longer verifies if an order is in error status (import entry error/error while importing)

Description

In 17Q4, the fix for issue 0035058 added a check when loading an order, to prevent loading it in web pos if the order was present in an Error While Importing or in an error Import Entry.
In 18Q1 the Paid Receipts selector was refactored and a new selector was created (issue 0036936).
The new selector missed the logic to check if the receipt being opened was present in the errors table.

Steps To Reproduce

Login in Web POS
Create a new layaway, add a product and complete it by clicking on Layaway.
Load the same layaway in two different terminals. Pay it partially on both terminals.
When completing the second payment, a new record will be generated in Errors While Importing POS Data window due to an Outdated Change exception.
Verify that after that it is still possible to load the receipt in WebPOS

Proposed Solution

The check for records in import entry that currently exists for verified returns should be added to the code in charge of loading receipts on the standard selector:
This code:
                if (data[0].recordInImportEntry) {
                  OB.UTIL.showLoading(false);
                  OB.UTIL.showConfirmation.display(
                    OB.I18N.getLabel('OBMOBC_Error'),
                    OB.I18N.getLabel('OBPOS_ReceiptNotSynced', [
                      data[0].documentNo
                    ])
                  );
                }

Should be added to orderLoaded function in orderSelectorUtils.js

Additional Information