Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041811Retail ModulesWeb POSpublic2019-09-13 09:202019-10-24 17:03
Reportermigueldejuana 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041811: Polling could be not launched due to asynchrony
DescriptionIn polling we have messages to poll in a "notStarted" collection. At some point we move messages from there to messagesByModel in dataSyncModels to be used in polling process. To launch polling process we check "noStarted" collection but we do not check messagesByModel, so if we move messages from noStarted to messagesByModel and then we check if we have to launch polling, it won't be launched.
Steps To Reproducen/a
Proposed SolutionCheck both notStarted and messagesByModel
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0041931RR19Q4 closed gorka_gil Polling could be not launched due to asynchrony 
blocks defect 0042102 closed Retail [LoyaltyPrograms] Error updating subscription number in WebPOS 
causes defect 0041686 closed markmm82 Polling when creating a subscription with card number does not always return data from the server 
Attached Files? mobileCore4118.commit (1,283) 2019-09-13 09:36
https://issues.openbravo.com/file_download.php?file_id=13303&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-09-13 09:20migueldejuanaNew Issue
2019-09-13 09:20migueldejuanaAssigned To => migueldejuana
2019-09-13 09:20migueldejuanaTriggers an Emergency Pack => No
2019-09-13 09:36migueldejuanaFile Added: mobileCore4118.commit
2019-09-16 23:28hgbotCheckin
2019-09-16 23:28hgbotNote Added: 0114591
2019-09-16 23:28hgbotStatusnew => resolved
2019-09-16 23:28hgbotResolutionopen => fixed
2019-09-16 23:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1919148245f7d65b02f6b88afb46399f7eb32536 [^]
2019-09-18 04:06markmm82Relationship addedcauses 0041686
2019-09-27 13:39gorka_gilAssigned Tomigueldejuana => gorka_gil
2019-09-27 13:39gorka_gilNote Added: 0114845
2019-09-27 13:39gorka_gilStatusresolved => new
2019-09-27 13:39gorka_gilResolutionfixed => open
2019-09-27 13:39gorka_gilStatusnew => scheduled
2019-10-04 10:27gorka_gilStatusscheduled => acknowledged
2019-10-04 10:28gorka_gilStatusacknowledged => scheduled
2019-10-04 10:54hgbotCheckin
2019-10-04 10:54hgbotNote Added: 0114913
2019-10-04 10:54hgbotCheckin
2019-10-04 10:54hgbotNote Added: 0114914
2019-10-04 10:54hgbotStatusscheduled => resolved
2019-10-04 10:54hgbotResolutionopen => fixed
2019-10-04 10:54hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1919148245f7d65b02f6b88afb46399f7eb32536 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b8d22c79d1fe2388fa9ddae64b8f09561f6e92c2 [^]
2019-10-04 10:54hgbotCheckin
2019-10-04 10:54hgbotNote Added: 0114915
2019-10-04 10:54hgbotCheckin
2019-10-04 10:54hgbotNote Added: 0114916
2019-10-04 12:47hgbotCheckin
2019-10-04 12:47hgbotNote Added: 0114921
2019-10-04 12:52gorka_gilNote Deleted: 0114921
2019-10-07 13:15hgbotCheckin
2019-10-07 13:15hgbotNote Added: 0114933
2019-10-08 10:07gorka_gilNote Added: 0114945
2019-10-08 10:07gorka_gilStatusresolved => new
2019-10-08 10:07gorka_gilResolutionfixed => open
2019-10-08 10:55hgbotCheckin
2019-10-08 10:55hgbotNote Added: 0114946
2019-10-08 10:56gorka_gilStatusnew => scheduled
2019-10-08 10:56gorka_gilStatusscheduled => resolved
2019-10-08 10:56gorka_gilResolutionopen => fixed
2019-10-24 08:03SandrahuguetRelationship addedblocks 0042102
2019-10-24 17:03marvintmReview Assigned To => marvintm
2019-10-24 17:03marvintmStatusresolved => closed
2019-10-24 17:03marvintmFixed in Version => RR20Q1

Notes
(0114591)
hgbot   
2019-09-16 23:28   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1919148245f7d65b02f6b88afb46399f7eb32536
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Sep 13 09:34:33 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1919148245f7d65b02f6b88afb46399f7eb32536 [^]

Fixed issue 0041811: Polling could be not launched due to asynchrony

- Check also messagesByModel because we could moved messages from noStarted to messagesByModel due to asynchrony

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---
(0114845)
gorka_gil   
2019-09-27 13:39   
The commit was backed out in:
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/63cdf954e192 [^]
(0114913)
hgbot   
2019-10-04 10:54   
Repository: tools/automation/pi-mobile
Changeset: b9e89187703c909d952d287d03a70b263c173371
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Oct 02 14:14:32 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b9e89187703c909d952d287d03a70b263c173371 [^]

Related to issue 41811: Fix loyalty tests in oracle

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/terminals/WebPOSExtModulesLoyaltyTerminalHelper.java
---
(0114914)
hgbot   
2019-10-04 10:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b8d22c79d1fe2388fa9ddae64b8f09561f6e92c2
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Sep 27 13:44:12 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b8d22c79d1fe2388fa9ddae64b8f09561f6e92c2 [^]

Fixed issue 0041811: Polling could be not launched due to asynchrony

- Check also messagesByModel because we could moved messages from noStarted to messagesByModel due to asynchrony

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---
(0114915)
hgbot   
2019-10-04 10:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 7f9fa65d8ba74c153fe6baba845bbd8e11faf945
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Sep 27 14:31:23 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/7f9fa65d8ba74c153fe6baba845bbd8e11faf945 [^]

Related to issue 41811: change the way to check if there is pending models to start the polling

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0114916)
hgbot   
2019-10-04 10:54   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 995646759147e71d47c521e0e7aa5994e58e88de
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Oct 02 17:30:30 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/995646759147e71d47c521e0e7aa5994e58e88de [^]

Related to issue 41811: when retry a polling it start a new process, but if is already running this new process should be terminated

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---
(0114933)
hgbot   
2019-10-07 13:15   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: d8a434aa041f8a9c4c1f06dacd2ebc69f47615d3
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Mon Oct 07 13:14:23 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/d8a434aa041f8a9c4c1f06dacd2ebc69f47615d3 [^]

Related to issue 41811: Backed out changeset 7f9fa65d8ba7

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0114945)
gorka_gil   
2019-10-08 10:07   
Reopened because previous fixes breaks awo
(0114946)
hgbot   
2019-10-08 10:55   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 21712b998c4305c34fb4019d9a641665d12d4a99
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Mon Oct 07 14:46:54 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/21712b998c4305c34fb4019d9a641665d12d4a99 [^]

Related to issue 41811: split the code of get the models to sync from the code to move the models from pending list to ongoing list

---
M web/org.openbravo.mobile.core/source/model/ob-pollingrequesthandler.js
---