Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041805Localization Pack: SpainAEAT 340public2019-09-12 16:302019-09-13 12:28
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customer
Regression introduced in release
Summary0041805: Several warnings are shown in the console while compiling with JDK 11
Description[javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:112: warning: [deprecation] ROUND_HALF_UP in BigDecimal has been deprecated
    [javac] .divide(new BigDecimal("100"), 2, BigDecimal.ROUND_HALF_UP),
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:112: warning: [deprecation] divide(BigDecimal,int,int) in BigDecimal has been deprecated
    [javac] .divide(new BigDecimal("100"), 2, BigDecimal.ROUND_HALF_UP),
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:261: warning: [deprecation] ROUND_HALF_EVEN in BigDecimal has been deprecated
    [javac] BigDecimal.ROUND_HALF_EVEN);
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:260: warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
    [javac] BigDecimal taxableAmountN = taxableAmount.setScale(EURO.getStandardPrecision().intValue(),
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:270: warning: [deprecation] ROUND_HALF_EVEN in BigDecimal has been deprecated
    [javac] BigDecimal.ROUND_HALF_EVEN);
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:269: warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
    [javac] BigDecimal vatAmountN = vatAmount.setScale(EURO.getStandardPrecision().intValue(),
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:282: warning: [deprecation] ROUND_HALF_EVEN in BigDecimal has been deprecated
    [javac] BigDecimal.ROUND_HALF_EVEN)));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java:281: warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
    [javac] : ecTaxAmount.setScale(EURO.getStandardPrecision().intValue(),
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java:48: warning: [deprecation] Integer(int) in Integer has been deprecated
    [javac] setYear((new Integer(cal.get(Calendar.YEAR)).toString()));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java:284: warning: [deprecation] ROUND_UP in BigDecimal has been deprecated
    [javac] multiply.multiply(dp.getAmount()).divide(totalGenerated, 10, BigDecimal.ROUND_UP));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java:284: warning: [deprecation] divide(BigDecimal,int,int) in BigDecimal has been deprecated
    [javac] multiply.multiply(dp.getAmount()).divide(totalGenerated, 10, BigDecimal.ROUND_UP));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/comparator/OrderByYearAndBP.java:18: warning: [deprecation] Integer(String) in Integer has been deprecated
    [javac] final Integer year1 = new Integer(o1.getYear());
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/comparator/OrderByYearAndBP.java:19: warning: [deprecation] Integer(String) in Integer has been deprecated
    [javac] final Integer year2 = new Integer(o2.getYear());
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java:81: warning: [deprecation] ROUND_HALF_UP in BigDecimal has been deprecated
    [javac] final BigDecimal origAmt = amount.setScale(2, BigDecimal.ROUND_HALF_UP);
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat340.es/src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java:81: warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
    [javac] final BigDecimal origAmt = amount.setScale(2, BigDecimal.ROUND_HALF_UP);
    [javac] ^
    [javac] 15 warnings
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0038130 closed caristu Openbravo ERP support JDK 11 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-12 16:30collazoandy4New Issue
2019-09-12 16:30collazoandy4Assigned To => collazoandy4
2019-09-12 16:31collazoandy4Statusnew => scheduled
2019-09-13 12:13hgbotCheckin
2019-09-13 12:13hgbotNote Added: 0114564
2019-09-13 12:13hgbotCheckin
2019-09-13 12:13hgbotNote Added: 0114565
2019-09-13 12:13hgbotStatusscheduled => resolved
2019-09-13 12:13hgbotResolutionopen => fixed
2019-09-13 12:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/901ebbc309d11516f35e6d48a267f5b8e244f587 [^]
2019-09-13 12:13hgbotCheckin
2019-09-13 12:13hgbotNote Added: 0114566
2019-09-13 12:26hgbotCheckin
2019-09-13 12:26hgbotNote Added: 0114567
2019-09-13 12:26hgbotCheckin
2019-09-13 12:26hgbotNote Added: 0114568
2019-09-13 12:26hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/901ebbc309d11516f35e6d48a267f5b8e244f587 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/55ddcd858cf0c78333a2df058fe1566eaec9d5c3 [^]
2019-09-13 12:27hgbotCheckin
2019-09-13 12:27hgbotNote Added: 0114569
2019-09-13 12:28SandrahuguetReview Assigned To => Sandrahuguet
2019-09-13 12:28SandrahuguetNote Added: 0114573
2019-09-13 12:28SandrahuguetStatusresolved => closed
2019-09-13 12:38SandrahuguetRelationship addedrelated to 0038130

Notes
(0114564)
hgbot   
2019-09-13 12:13   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: b7589fd2fef79d35d0eec5f614180ff6a29792b4
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 10:28:59 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/b7589fd2fef79d35d0eec5f614180ff6a29792b4 [^]

Related to issue 41805: Set new eclipse build-int format

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114565)
hgbot   
2019-09-13 12:13   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 901ebbc309d11516f35e6d48a267f5b8e244f587
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 10:34:18 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/901ebbc309d11516f35e6d48a267f5b8e244f587 [^]

Fixes issue 41805:Several warnings are shown in the console while compiling with
JDK 11

Removed depreceated BigDecimal rounding constants
Replaced new Integer(1).toString with String.valueOf

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java
M src/org/openbravo/module/aeat340/es/comparator/OrderByYearAndBP.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114566)
hgbot   
2019-09-13 12:13   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 54c711a3fd6b64e8b529fd0f32d1a601c22026be
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Sep 13 12:12:50 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/54c711a3fd6b64e8b529fd0f32d1a601c22026be [^]

related to issue 41805 fix javadoc warnings

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114567)
hgbot   
2019-09-13 12:26   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 6dbadda3fb80b4544f4a5e2ecb720572511c2220
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 10:45:35 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/6dbadda3fb80b4544f4a5e2ecb720572511c2220 [^]

Related to issue 41805:Set new eclipse build-int format

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114568)
hgbot   
2019-09-13 12:26   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 55ddcd858cf0c78333a2df058fe1566eaec9d5c3
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 10:57:42 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/55ddcd858cf0c78333a2df058fe1566eaec9d5c3 [^]

Fixes issue 41805:Several warnings are shown in the console while compiling with
JDK 11

Removed depreceated BigDecimal rounding constants
Replaced new Long(1) with 1L

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012.java
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/bean/PaymentInfoFor340.java
M src/org/openbravo/module/aeat340/es/comparator/OrderByYearAndBP.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114569)
hgbot   
2019-09-13 12:27   
Repository: erp/pmods/org.openbravo.module.aeat340.es
Changeset: 0076f9baf71f07e2be27c8f531e9286bbe5ff23a
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Sep 13 12:26:14 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat340.es/rev/0076f9baf71f07e2be27c8f531e9286bbe5ff23a [^]

related to issue 41805 fix javadoc warnings cashvat

---
M src/org/openbravo/module/aeat340/es/api/year2012/AEAT340Report_2012NotAPRMDao.java
M src/org/openbravo/module/aeat340/es/util/AEAT340_Utility.java
---
(0114573)
Sandrahuguet   
2019-09-13 12:28   
code review + testing ok