Openbravo Issue Tracking System - Localization Pack: Spain
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041802Localization Pack: SpainAEAT 190public2019-09-12 15:422019-09-13 12:27
Reportercollazoandy4 
Assigned Tocollazoandy4 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned ToSandrahuguet
Support ticket
OBNetwork customerNo
Regression introduced in release
Summary0041802: Several warnings are shown in the console while compiling with JDK 11
Description[javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/bean/PaymentInfoFor190.java:40: warning: [deprecation] Integer(int) in Integer has been deprecated
    [javac] setYear((new Integer(cal.get(Calendar.YEAR)).toString()));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/comparator/OrderByYearAndBP.java:18: warning: [deprecation] Integer(String) in Integer has been deprecated
    [javac] final Integer year1 = new Integer(o1.getYear());
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/comparator/OrderByYearAndBP.java:19: warning: [deprecation] Integer(String) in Integer has been deprecated
    [javac] final Integer year2 = new Integer(o2.getYear());
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/report/AEAT190ReportDao.java:408: warning: [deprecation] ROUND_HALF_UP in BigDecimal has been deprecated
    [javac] .divide(invoice.getGrandTotalAmount(), 4, BigDecimal.ROUND_HALF_UP).abs();
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/report/AEAT190ReportDao.java:408: warning: [deprecation] divide(BigDecimal,int,int) in BigDecimal has been deprecated
    [javac] .divide(invoice.getGrandTotalAmount(), 4, BigDecimal.ROUND_HALF_UP).abs();
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/report/AEAT190ReportNotAPRMDao.java:313: warning: [deprecation] ROUND_UP in BigDecimal has been deprecated
    [javac] .divide(totalGenerated, 10, BigDecimal.ROUND_UP));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/report/AEAT190ReportNotAPRMDao.java:313: warning: [deprecation] divide(BigDecimal,int,int) in BigDecimal has been deprecated
    [javac] .divide(totalGenerated, 10, BigDecimal.ROUND_UP));
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/util/AEAT190_Utility.java:127: warning: [deprecation] ROUND_HALF_UP in BigDecimal has been deprecated
    [javac] final BigDecimal origAmt = amount.setScale(2, BigDecimal.ROUND_HALF_UP);
    [javac] ^
    [javac] /ob_spanish_pack/modules/org.openbravo.module.aeat190.es/src/org/openbravo/module/aeat190/es/util/AEAT190_Utility.java:127: warning: [deprecation] setScale(int,int) in BigDecimal has been deprecated
    [javac] final BigDecimal origAmt = amount.setScale(2, BigDecimal.ROUND_HALF_UP);
    [javac] ^
    [javac] 9 warnings
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0038130 closed caristu Openbravo ERP support JDK 11 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-12 15:42collazoandy4New Issue
2019-09-12 15:42collazoandy4Assigned To => collazoandy4
2019-09-12 15:42collazoandy4OBNetwork customer => No
2019-09-12 15:43collazoandy4Statusnew => scheduled
2019-09-13 09:23hgbotCheckin
2019-09-13 09:23hgbotNote Added: 0114553
2019-09-13 09:23hgbotCheckin
2019-09-13 09:23hgbotNote Added: 0114554
2019-09-13 09:23hgbotStatusscheduled => resolved
2019-09-13 09:23hgbotResolutionopen => fixed
2019-09-13 09:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/c03426d497a0ab6033ab15029f9e89c4a8fff61e [^]
2019-09-13 09:24hgbotCheckin
2019-09-13 09:24hgbotNote Added: 0114555
2019-09-13 12:27SandrahuguetReview Assigned To => Sandrahuguet
2019-09-13 12:27SandrahuguetNote Added: 0114570
2019-09-13 12:27SandrahuguetStatusresolved => closed
2019-09-13 12:38SandrahuguetRelationship addedrelated to 0038130

Notes
(0114553)
hgbot   
2019-09-13 09:23   
Repository: erp/pmods/org.openbravo.module.aeat190.es
Changeset: 2130262a8920f898f3913740ab105df94c3660a6
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 11:07:33 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/2130262a8920f898f3913740ab105df94c3660a6 [^]

Related to issue 41802: Set new eclipse build-int format

---
M src/org/openbravo/module/aeat190/es/report/AEAT190ReportDao.java
M src/org/openbravo/module/aeat190/es/report/AEAT190ReportNotAPRMDao.java
M src/org/openbravo/module/aeat190/es/util/AEAT190_Utility.java
---
(0114554)
hgbot   
2019-09-13 09:23   
Repository: erp/pmods/org.openbravo.module.aeat190.es
Changeset: c03426d497a0ab6033ab15029f9e89c4a8fff61e
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Thu Sep 12 11:08:58 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/c03426d497a0ab6033ab15029f9e89c4a8fff61e [^]

Fixes issue 41802:Several warnings are shown in the console while compiling with
JDK 11

Removed depreceated BigDecimal rounding constants
Replaced new Integer by Integer.parseInt

---
M src/org/openbravo/module/aeat190/es/bean/PaymentInfoFor190.java
M src/org/openbravo/module/aeat190/es/comparator/OrderByYearAndBP.java
M src/org/openbravo/module/aeat190/es/report/AEAT190ReportNotAPRMDao.java
M src/org/openbravo/module/aeat190/es/util/AEAT190_Utility.java
---
(0114555)
hgbot   
2019-09-13 09:24   
Repository: erp/pmods/org.openbravo.module.aeat190.es
Changeset: 5a63e1feade4b6477c87dae7a62581df005d6cf1
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Fri Sep 13 09:14:48 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat190.es/rev/5a63e1feade4b6477c87dae7a62581df005d6cf1 [^]

Related to issue 41802 fix javadoc warnings

---
M src/org/openbravo/module/aeat190/es/report/AEAT190ReportNotAPRMDao.java
---
(0114570)
Sandrahuguet   
2019-09-13 12:27   
code review + testing ok