Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041794Openbravo ERP04. Warehouse managementpublic2019-09-04 13:562019-09-11 17:53
gorkaion 
collazoandy4 
immediatecriticalalways
closedfixed 
5
 
3.0PR19Q2.33.0PR19Q2.3 
Sandrahuguet
Core
Production - Confirmed Stable
2016-10-11
3.0PR17Q1
https://code.openbravo.com/erp/devel/pi/rev/37c5b07cf5e7 [^]
No
0041794: Fix backdated transaction is not fixing all backdated transactions
When the fix backdated transaction process is executed in a costing rule to enable backdated corrections the process is not adjusting all existing backdated transactions.
*** NOTE: Currently in live builds there are many products with costing in an inconsistent status with overlapped ranges in the costings. To properly reproduce the issue search a product without this problem to avoid collateral issues related to this problem (for example Cola de Cereza) ***

1. Ensure that the costing rule is not fixing backdated transactions.
2. Create 3 new Purchase Orders with relevant changes in the price and enough quantity to ensure that the average is changed. All of them with different dates in the past.
2.1. For example using cola de cereza whose regular price is 0.55:
        del date qty price
 PO1 - 04-08-2018 - 50000ud - 0.02 EUR
 PO2 - 04-09-2018 - 70000ud - 5 EUR
 PO3 - 04-07-2018 - 30000ud - 10 EUR

3. Create 3 goods receipts using Pending Goods Receipt each one using the same date as de delivery date of the order and processed in the same order than the orders.
  GR01 - PO1 - 04-08-2018
  GR02 - PO2 - 04-09-2018
  GR03 - PO3 - 04-07-2018

4. Execute costing background process to ensure that all costs are calculated.
5. Go to Costing Rule for Spain org and execute the Fix Backdated Transactions with starting date 01-01-2018.
6. Go to Cost Adjustment window and check if there is any adjustment. It is expected to be a new cost adjustment for Backdated Transaction with at least 3 lines with the 3 goods receipts with the source flag as true and all the shipments from 04-07-2018 adjusted with the new average cost.
7. Go to Costing tab and sort by starting date. We expect that the costings related to the backdated receipt to be correctly ordered between other receipts by their date.
The method isNeededBackdatedCostAdjustment from CostAdjustmentUtils is not returning value when a old transaction already calculated is passed as parameter.
No tags attached.
blocks defect 0041749 closed collazoandy4 Fix backdated transaction is not fixing all backdated transactions 
Issue History
2019-09-10 16:52collazoandy4Typedefect => backport
2019-09-10 16:52collazoandy4Target Version => 3.0PR19Q2.3
2019-09-11 17:51hgbotCheckin
2019-09-11 17:51hgbotNote Added: 0114529
2019-09-11 17:51hgbotStatusscheduled => resolved
2019-09-11 17:51hgbotResolutionopen => fixed
2019-09-11 17:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/87ab01cc33539eacbc8e69c3e66e6547c5c2b23d [^]
2019-09-11 17:53SandrahuguetReview Assigned To => Sandrahuguet
2019-09-11 17:53SandrahuguetNote Added: 0114532
2019-09-11 17:53SandrahuguetStatusresolved => closed
2019-09-11 17:53SandrahuguetFixed in Version => 3.0PR19Q2.3

Notes
(0114529)
hgbot   
2019-09-11 17:51   
Repository: erp/backports/3.0PR19Q2.3
Changeset: 87ab01cc33539eacbc8e69c3e66e6547c5c2b23d
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Mon Sep 09 12:07:53 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q2.3/rev/87ab01cc33539eacbc8e69c3e66e6547c5c2b23d [^]

Fixes issue 41794:Fix backdated transaction is not fixing all backdated trx

When the fix backdated transaction process is executed in a costing rule to enable
backdated corrections the process is not adjusting all existing backdated transactions
because the method isNeededBackdatedCostAdjustment from CostAdjustmentUtils is
not returning value when an old transaction already calculated is passed as parameter if was
processed after last transaction and the old transaction movement date is before

Now the process create an ajustment if the transaction movement date is before previous
adjusted transaction movement date

---
M src/org/openbravo/costing/AverageCostAdjustment.java
M src/org/openbravo/costing/FixBackdatedTransactionsProcess.java
---
(0114532)
Sandrahuguet   
2019-09-11 17:53   
code review + testing ok