0041793: Fix backdated transaction is not fixing all backdated transactions

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0041793

Openbravo ERP

04. Warehouse management

public

2019-09-04 13:56

2019-09-11 17:52

Reporter

gorkaion

Assigned To

collazoandy4

Priority

immediate

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

3.0PR19Q3.1

Fixed in Version

3.0PR19Q3.1

Merge Request Status

Review Assigned To

Sandrahuguet

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

11618

Regression level

Production - Confirmed Stable

Regression date

2016-10-11

Regression introduced in release

3.0PR17Q1

Regression introduced by commit

https://code.openbravo.com/erp/devel/pi/rev/37c5b07cf5e7 [^]

Triggers an Emergency Pack

Summary

0041793: Fix backdated transaction is not fixing all backdated transactions

Description

When the fix backdated transaction process is executed in a costing rule to enable backdated corrections the process is not adjusting all existing backdated transactions.

Steps To Reproduce

*** NOTE: Currently in live builds there are many products with costing in an inconsistent status with overlapped ranges in the costings. To properly reproduce the issue search a product without this problem to avoid collateral issues related to this problem (for example Cola de Cereza) ***

1. Ensure that the costing rule is not fixing backdated transactions.
2. Create 3 new Purchase Orders with relevant changes in the price and enough quantity to ensure that the average is changed. All of them with different dates in the past.
2.1. For example using cola de cereza whose regular price is 0.55:
        del date qty price
PO1 - 04-08-2018 - 50000ud - 0.02 EUR
PO2 - 04-09-2018 - 70000ud - 5 EUR
PO3 - 04-07-2018 - 30000ud - 10 EUR

3. Create 3 goods receipts using Pending Goods Receipt each one using the same date as de delivery date of the order and processed in the same order than the orders.
  GR01 - PO1 - 04-08-2018
  GR02 - PO2 - 04-09-2018
  GR03 - PO3 - 04-07-2018

4. Execute costing background process to ensure that all costs are calculated.
5. Go to Costing Rule for Spain org and execute the Fix Backdated Transactions with starting date 01-01-2018.
6. Go to Cost Adjustment window and check if there is any adjustment. It is expected to be a new cost adjustment for Backdated Transaction with at least 3 lines with the 3 goods receipts with the source flag as true and all the shipments from 04-07-2018 adjusted with the new average cost.
7. Go to Costing tab and sort by starting date. We expect that the costings related to the backdated receipt to be correctly ordered between other receipts by their date.

Proposed Solution

The method isNeededBackdatedCostAdjustment from CostAdjustmentUtils is not returning value when a old transaction already calculated is passed as parameter.

Additional Information