Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0041777Openbravo ERPA. Platformpublic2019-09-06 14:212019-09-10 19:28
alostale 
alostale 
normaltrivialhave not tried
closedfixed 
5
 
3.0PR19Q4 
caristu
Core
No
0041777: add an annotation to link test cases with issues
Many test cases are written after an issue is reported, there is no a common convention on how to link the test to the reported issue, typically this is done through comments or, in some cases, by adding the issue number to the method name.
-
Create a new @Issue annotation that allows to annotate test cases so that they are linked to the issue.

Ie.

public class SomeRegressionTest {
  @Test @Issue("issueNumber")
  public void thingsShouldWork() {...}
}
No tags attached.
causes defect 0044768 closed alostale cannot compile DBSM tests from cli 
Issue History
2019-09-06 14:21alostaleNew Issue
2019-09-06 14:21alostaleAssigned To => platform
2019-09-06 14:21alostaleModules => Core
2019-09-06 14:21alostaleTriggers an Emergency Pack => No
2019-09-06 14:22alostaleAssigned Toplatform => alostale
2019-09-06 14:22alostaleReview Assigned To => caristu
2019-09-06 14:25hgbotCheckin
2019-09-06 14:25hgbotNote Added: 0114437
2019-09-06 14:25hgbotStatusnew => resolved
2019-09-06 14:25hgbotResolutionopen => fixed
2019-09-06 14:25hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/0b2a423a828648560052db9f83361a458dae8491 [^]
2019-09-06 15:03hgbotCheckin
2019-09-06 15:03hgbotNote Added: 0114438
2019-09-06 15:06hgbotCheckin
2019-09-06 15:06hgbotNote Added: 0114439
2019-09-06 19:27hudsonbotCheckin
2019-09-06 19:27hudsonbotNote Added: 0114443
2019-09-10 11:58caristuNote Added: 0114490
2019-09-10 11:58caristuStatusresolved => closed
2019-09-10 11:58caristuFixed in Version => 3.0PR19Q4
2019-09-10 19:28hudsonbotCheckin
2019-09-10 19:28hudsonbotNote Added: 0114514
2019-09-10 19:28hudsonbotCheckin
2019-09-10 19:28hudsonbotNote Added: 0114515
2020-08-07 07:10alostaleRelationship addedcauses 0044768

Notes
(0114437)
hgbot   
2019-09-06 14:25   
Repository: erp/devel/pi
Changeset: 0b2a423a828648560052db9f83361a458dae8491
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 06 14:24:52 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/0b2a423a828648560052db9f83361a458dae8491 [^]

fixes issue 41777: add an annotation to link test cases with issues

---
A src-test/src/org/openbravo/test/base/Issue.java
---
(0114438)
hgbot   
2019-09-06 15:03   
Repository: erp/devel/pi
Changeset: d29abdc3c42c51af577cd0bfd43ae458f32432cc
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 06 15:02:19 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d29abdc3c42c51af577cd0bfd43ae458f32432cc [^]

related to issue 41777: replaced comments with @Issue annotation

  The goal is to use a more consistent way to link test cases with issue tracker.

---
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/ADCSTest.java
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/event/PersistanceObserver.java
M src-test/src/org/openbravo/client/kernel/CSSMinifier.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
M src-test/src/org/openbravo/test/dal/ADCachedMultiThreadTest.java
M src-test/src/org/openbravo/test/dal/AdminContextTest.java
M src-test/src/org/openbravo/test/dal/DalConnectionProviderTest.java
M src-test/src/org/openbravo/test/dal/IssuesTest.java
M src-test/src/org/openbravo/test/dal/OBContextTest.java
M src-test/src/org/openbravo/test/dal/ViewTest.java
M src-test/src/org/openbravo/test/datasource/EmptyStringWhereAndFilterClauseParameter.java
M src-test/src/org/openbravo/test/datasource/FICTest.java
M src-test/src/org/openbravo/test/datasource/FKDropDownDatasource.java
M src-test/src/org/openbravo/test/datasource/FetchDSNoActiveEntityObjects.java
M src-test/src/org/openbravo/test/datasource/OrganizationSelectorDataSourceTest.java
M src-test/src/org/openbravo/test/datasource/TestAllowUnpagedDatasourcePreference.java
M src-test/src/org/openbravo/test/datasource/TestCSVEncoding.java
M src-test/src/org/openbravo/test/datasource/TestComboDatasource.java
M src-test/src/org/openbravo/test/db/model/functions/SqlCallableStatement.java
M src-test/src/org/openbravo/test/expression/EvaluationTest.java
M src-test/src/org/openbravo/test/model/RuntimeModelTest.java
M src-test/src/org/openbravo/test/reporting/JasperReportsCompilation.java
M src-test/src/org/openbravo/test/security/WritableReadableOrganizationClientTest.java
M src-test/src/org/openbravo/test/system/CryptoUtilities.java
M src-test/src/org/openbravo/test/system/Issue29934Test.java
M src-test/src/org/openbravo/test/webservice/JSONWebServices.java
M src-test/src/org/openbravo/test/webservice/WSAddRecordWithComputedColumns.java
M src-test/src/org/openbravo/test/webservice/WSUpdateTest.java
M src-test/src/org/openbravo/test/webservice/WSWithNoActiveDalObjects.java
M src-test/src/org/openbravo/test/xml/DatasetExportTest.java
M src-test/src/org/openbravo/test/xml/EntityXMLImportTestBusinessObject.java
---
(0114439)
hgbot   
2019-09-06 15:06   
Repository: erp/devel/pi
Changeset: 4f48c788a19a7a48ff69ee1b9406a88f09469cbe
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Sep 06 15:06:17 2019 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4f48c788a19a7a48ff69ee1b9406a88f09469cbe [^]

related to issue 41777: removed some wrong annotations

---
M src-test/src/org/openbravo/client/kernel/CSSMinifier.java
M src-test/src/org/openbravo/test/copyLinesFromOrders/CopyLinesFromOrdersTest.java
---
(0114443)
hudsonbot   
2019-09-06 19:27   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f144a223757b [^]
Maturity status: Test
(0114490)
caristu   
2019-09-10 11:58   
Reviewed
(0114514)
hudsonbot   
2019-09-10 19:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/34e5cbc290bf [^]
Maturity status: Test
(0114515)
hudsonbot   
2019-09-10 19:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/34e5cbc290bf [^]
Maturity status: Test