Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041767Retail ModulesWeb POSpublic2019-09-05 17:292019-09-18 08:40
Reportergorka_gil 
Assigned ToRetail 
PriorityhighSeveritymajorReproducibilityalways
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041767: Disabling some tests in the external modules that fail with the new discounts engine
DescriptionI41092_VerifyFreeProductPerTotalAmount
I41097_VerifyManualAndTotalDiscounts
I40812_VerifyMultiManualTotalDiscounts
I38813_VerifyDiscountWhenCanceledByAnother
I38813_VerifyDiscountWhenCanceledByAnother2
I41008_VerifyDiscountWithPriceAdjustment
Steps To Reproducehttps://ci.openbravo.com/view/try-retail/job/try-ret-init/16043/artifact/try-retail.html [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0041739 closed joniturralde93 Free Products per Total Mount discounts don't work when a filter is applied 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-05 17:29gorka_gilNew Issue
2019-09-05 17:29gorka_gilAssigned To => Retail
2019-09-05 17:29gorka_gilTriggers an Emergency Pack => No
2019-09-05 17:33hgbotCheckin
2019-09-05 17:33hgbotNote Added: 0114426
2019-09-06 08:55hgbotCheckin
2019-09-06 08:55hgbotNote Added: 0114431
2019-09-10 12:38hgbotCheckin
2019-09-10 12:38hgbotNote Added: 0114492
2019-09-10 12:40hgbotCheckin
2019-09-10 12:40hgbotNote Added: 0114493
2019-09-11 12:25hgbotCheckin
2019-09-11 12:25hgbotNote Added: 0114519
2019-09-11 12:51ranjith_qualiantech_comRelationship addedrelated to 0041739
2019-09-17 18:06hgbotCheckin
2019-09-17 18:06hgbotNote Added: 0114600
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114613
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114614
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114616
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114617
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114618
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114619

Notes
(0114426)
hgbot   
2019-09-05 17:33   
Repository: tools/automation/pi-mobile
Changeset: a9bec3952dd94c02a81ce81fd39439e5b041f99e
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Thu Sep 05 17:31:22 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9bec3952dd94c02a81ce81fd39439e5b041f99e [^]

Related to issue 41767: disable some tests of the external modules that fail after the new discounts engine

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I40812_VerifyMultiManualTotalDiscounts.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41092_VerifyFreeProductPerTotalAmount.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41097_VerifyManualAndTotalDiscounts.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I38813_VerifyDiscountWhenCanceledByAnother.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I38813_VerifyDiscountWhenCanceledByAnother2.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I41008_VerifyDiscountWithPriceAdjustment.java
---
(0114431)
hgbot   
2019-09-06 08:55   
Repository: tools/automation/pi-mobile
Changeset: 57b2bfe6c70b5993b13fe9a7f9faff1898c4b64d
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Fri Sep 06 08:55:01 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/57b2bfe6c70b5993b13fe9a7f9faff1898c4b64d [^]

Related to issue 41767: disable some tests of the external modules that fail after the new discounts engine - part2

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41397_VerifyNoNegativeTotalPriceWithManualDiscounts.java
---
(0114492)
hgbot   
2019-09-10 12:38   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 63c58563425cd2a223c268161a45654c01851b78
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Sep 10 12:37:26 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/63c58563425cd2a223c268161a45654c01851b78 [^]

Related to issue 41767: disable some tests

---
M src-test/org/openbravo/discounts/bytotal/test/unittests/DiscountByTotalFreeItemsTest.java
---
(0114493)
hgbot   
2019-09-10 12:40   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: 556688432a74578d3a775878de86a8f2f32f55ac
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Sep 10 12:39:29 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/556688432a74578d3a775878de86a8f2f32f55ac [^]

Related to issue 41767: disable some tests

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountPriceAdjusmentTest.java
---
(0114519)
hgbot   
2019-09-11 12:25   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 1f83cf10a494a89cf209bb704e6bb5cd3052778e
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Wed Sep 11 11:52:12 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/1f83cf10a494a89cf209bb704e6bb5cd3052778e [^]

Fixes issue 41759 , Related to issue 41767 : Free products should not participate in the total that needs to be reached

---
M src-test/org/openbravo/discounts/bytotal/test/unittests/DiscountByTotalFreeItemsTest.java
M web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-free-item-discount.js
---
(0114600)
hgbot   
2019-09-17 18:06   
Repository: tools/automation/pi-mobile
Changeset: fef3803feb5e3ef4ee383dbd970237d5960af45c
Author: Gorka Gil <gorka.gil <at> openbravo.com>
Date: Tue Sep 17 18:06:02 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fef3803feb5e3ef4ee383dbd970237d5960af45c [^]

Related to issue 41759, related to issue 41767: Set test I41092_VerifyFreeProductPerTotalAmoun to run only with old engine

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41092_VerifyFreeProductPerTotalAmount.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/suites/concurrent/job016/DiscountsByTotalSuiteOD.java
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/AllDiscountsByTotalTestsOD.java
---
(0114613)
hgbot   
2019-09-18 08:40   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 160e2705d4642cfc77549487b615cc8c1ac859e8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 17 10:56:16 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/160e2705d4642cfc77549487b615cc8c1ac859e8 [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests in the
external modules that fail with the new discounts engine.

By total promotions should avoid to generate negative lines when
discount amount per total amount is applied.

---
M web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-amount-discount.js
---
(0114614)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 2fa192b3eaa74001583ae8c7b923b629448c33b6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 16 16:56:17 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2fa192b3eaa74001583ae8c7b923b629448c33b6 [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests
in the external modules that fail with the new discounts engine

These rules and test scenarios are not correctly implemented and
should be executed only with the old discount engine:
  * I38813_VerifyDiscountWhenCanceledByAnother
  * I38813_VerifyDiscountWhenCanceledByAnother2

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I38813_VerifyDiscountWhenCanceledByAnother.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I38813_VerifyDiscountWhenCanceledByAnother2.java
---
(0114616)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 0d0494e803d4d1641e4747f1e94216ee3141f413
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 17 09:07:08 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0d0494e803d4d1641e4747f1e94216ee3141f413 [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests in the
external modules that fail with the new discounts engine.

The test discount amount are incorrectly calculated in old discount
engine. Enable different values for old and new discount engine.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I40812_VerifyMultiManualTotalDiscounts.java
---
(0114617)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 2317a7047729d763c89e7bedbd614e0cce39d79e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 17 10:04:16 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/2317a7047729d763c89e7bedbd614e0cce39d79e [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests in the
external modules that fail with the new discounts engine.

The test discount amount are incorrectly calculated in old discount
engine. Enable different values for old and new discount engine.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41097_VerifyManualAndTotalDiscounts.java
---
(0114618)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 1f1b47c1d99280642cc0e747a6c51e945f69e2ce
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 17 10:37:15 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1f1b47c1d99280642cc0e747a6c51e945f69e2ce [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests in the
external modules that fail with the new discounts engine.

The old engine add some hidden promotion when the price adjusment
discount amount is higher than the line total price.

This hidden promotion is nnot needed and is not added in new
discount engine.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41397_VerifyNoNegativeTotalPriceWithManualDiscounts.java
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_scaledprice/I41008_VerifyDiscountWithPriceAdjustment.java
---
(0114619)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 471db94d16ab1c0d608aa5967cf610875af35ac1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Sep 17 10:55:33 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/471db94d16ab1c0d608aa5967cf610875af35ac1 [^]

[NewDiscountEngine] Related to issue 41767: Disabling some tests in the
external modules that fail with the new discounts engine.

Reactivate test.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_bytotal/I41397_VerifyNoNegativeTotalPriceWithManualDiscounts.java
---