Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041762Retail ModulesWeb POSpublic2019-09-05 12:242019-12-20 15:04
Reporterasiermartirena 
Assigned Toasiermartirena 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041762: Before synchronizing a ticket, it is not checked if the ticket has been modified
DescriptionIt is possible, for a ticket that has been loaded from the backend, to have the situation in which another person has modified the ticket before the user that has loaded it has synchronized. This causes that the synchronizing ticket is trying to update a ticket without having all the changes done for that ticket.

This causes an error while importing. After that, a technical person must be involved in that error to try to fix the problem by some way, having some impossible situations in some cases.
Steps To ReproduceCreate a layaway in a terminal.
Load it in another terminal.
Load in the first terminal, pay and synchronize it.
Pay and synchronize the layaway loaded in the second terminal --> When synchronizing the ticket, Openbravo checks that the layaway has been modified since the terminal has loaded, so is trying to change it without checking the new changes. In consequence, an error while importing is created.
Proposed SolutionCheck if the ticket has been modified just before sending the ticket to synchronize to.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0048442 closed ranjith_qualiantech_com Request for doing a validation in the web pos to avoid a recurring Error While importing 
Attached Files? issue_41762.export (118,446) 2019-12-09 17:16
https://issues.openbravo.com/file_download.php?file_id=13646&type=bug
Issue History
Date ModifiedUsernameFieldChange
2019-09-05 12:24asiermartirenaNew Issue
2019-09-05 12:24asiermartirenaAssigned To => asiermartirena
2019-09-05 12:24asiermartirenaTriggers an Emergency Pack => No
2019-10-22 17:23asiermartirenaFile Added: issueOutdated.export
2019-11-10 14:18asiermartirenaFile Deleted: issueOutdated.export
2019-11-10 14:19asiermartirenaFile Added: issue_41762.export
2019-12-05 08:52asiermartirenaFile Deleted: issue_41762.export
2019-12-09 17:16asiermartirenaFile Added: issue_41762.export
2019-12-10 20:41hgbotCheckin
2019-12-10 20:41hgbotNote Added: 0116173
2019-12-10 20:41hgbotStatusnew => resolved
2019-12-10 20:41hgbotResolutionopen => fixed
2019-12-10 20:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3f4bb39931f73ac188014e8e338d3f94de2facc [^]
2019-12-11 16:20hgbotCheckin
2019-12-11 16:20hgbotNote Added: 0116189
2019-12-11 16:20hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3f4bb39931f73ac188014e8e338d3f94de2facc [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a958fd139cb37f7e6f1d77aecaaa76df05d9e8f8 [^]
2019-12-12 15:57hgbotCheckin
2019-12-12 15:57hgbotNote Added: 0116227
2019-12-12 16:00hgbotCheckin
2019-12-12 16:00hgbotNote Added: 0116228
2019-12-12 16:00hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a958fd139cb37f7e6f1d77aecaaa76df05d9e8f8 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63c248a2e26b2982f63eeb235863755eed724645 [^]
2019-12-20 15:04marvintmReview Assigned To => marvintm
2019-12-20 15:04marvintmStatusresolved => closed
2019-12-20 15:04marvintmFixed in Version => RR20Q1
2022-01-28 10:16ranjith_qualiantech_comRelationship addedrelated to 0048442

Notes
(0116173)
hgbot   
2019-12-10 20:41   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c3f4bb39931f73ac188014e8e338d3f94de2facc
Author: Asier Martirena <asier.martirena <at> openbravo.com>
Date: Mon Dec 02 13:48:14 2019 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c3f4bb39931f73ac188014e8e338d3f94de2facc [^]

Fixed issue 41762: Check the outdated of the synchronizing receipts directly in the Web POS

Instead of waiting to check the outdated status of a receipt directly in the backend process, now a check is done before the synchronization is done to be able to stop the process if the ticket has been modified after it was loaded in the Web POS.
This allows to avoid the most errors while importing data generated due to this cause.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
A src/org/openbravo/retail/posterminal/process/CheckUpdated.java
---
(0116189)
hgbot   
2019-12-11 16:20   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a958fd139cb37f7e6f1d77aecaaa76df05d9e8f8
Author: Leosbanis Fonseca <leosvany2010 <at> gmail.com>
Date: Wed Dec 11 09:57:12 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a958fd139cb37f7e6f1d77aecaaa76df05d9e8f8 [^]

Fixed issue 41762: Check the outdated of the synchronizing receipts directly in the Web POS

Instead of waiting to check the outdated status of a receipt directly in the backend process, now a check is done before the synchronization is done to be able to stop the process if the ticket has been modified after it was loaded in the Web POS.
This allows to avoid the most errors while importing data generated due to this cause.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
A src/org/openbravo/retail/posterminal/process/CheckUpdated.java
---
(0116227)
hgbot   
2019-12-12 15:57   
Repository: tools/automation/pi-mobile
Changeset: 224b1b3399af3746e5b0e6578564f41c5f0ea207
Author: Leosbanis Fonseca <leosvany2010 <at> gmail.com>
Date: Tue Dec 10 14:33:31 2019 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/224b1b3399af3746e5b0e6578564f41c5f0ea207 [^]

Related to Issue 41762: Changed ChangeBPOffline.java test

Check the outdated of the synchronizing receipts directly in the Web POS

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/offline/ChangeBPOffline.java
---
(0116228)
hgbot   
2019-12-12 16:00   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 63c248a2e26b2982f63eeb235863755eed724645
Author: Leosbanis Fonseca <leosvany2010 <at> gmail.com>
Date: Thu Dec 12 09:58:13 2019 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/63c248a2e26b2982f63eeb235863755eed724645 [^]

Fixed issue 41762: Check the outdated of the synchronizing receipts directly in the Web POS

Instead of waiting to check the outdated status of a receipt directly in the backend process, now a check is done before the synchronization is done to be able to stop the process if the ticket has been modified after it was loaded in the Web POS.
This allows to avoid the most errors while importing data generated due to this cause.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_PREFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-db/database/sourcedata/OBMOBC_SERVICES.xml
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
A src/org/openbravo/retail/posterminal/process/CheckUpdated.java
---