Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041760Retail ModulesWeb POSpublic2019-09-05 11:002019-09-18 08:40
Reportermarvintm 
Assigned Togorka_gil 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusnewResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041760: Manual discounts should be applicable even if there are no available units in the line
DescriptionManual discounts should be applicable even if there are no available units in the line.
Steps To Reproduce- Add 6 "Bottle 1L"
- Try to add a by total 23 EUR discount (defined with greater priority than the "3x2 bottle", meaning it will be applied later).

Verify that the discount is not applied.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-05 11:00marvintmNew Issue
2019-09-05 11:00marvintmAssigned To => gorka_gil
2019-09-05 11:00marvintmTriggers an Emergency Pack => No
2019-09-05 11:50hgbotCheckin
2019-09-05 11:50hgbotNote Added: 0114416
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114612
2019-09-18 08:40hgbotCheckin
2019-09-18 08:40hgbotNote Added: 0114615

Notes
(0114416)
hgbot   
2019-09-05 11:50   
Repository: tools/automation/pi-mobile
Changeset: 3928fd550365b4f31640751c40daf958289a399a
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Sep 05 11:02:10 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/3928fd550365b4f31640751c40daf958289a399a [^]

[NewDiscountEngine] Related to issue 41760. Manual promotions should not be affected by consumed units

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/I39858_VerifySplitLineWithManualAndAutoPromo.java
---
(0114612)
hgbot   
2019-09-18 08:40   
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: de094bdc7624f9270889cf9bf786340f026b7ccc
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 16 17:59:46 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/de094bdc7624f9270889cf9bf786340f026b7ccc [^]

[NewDiscountEngine] Related to issue 41760: Manual discounts should be applicable
even if there are no available units in the line

Manual by total promotions should not need available units to be applied
as they are manually added to the ticket.

---
M web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-amount-discount.js
M web/org.openbravo.retail.discounts.bytotal/js/discountsengine/common/rules/by-total-percentage-discount.js
---
(0114615)
hgbot   
2019-09-18 08:40   
Repository: tools/automation/pi-mobile
Changeset: 4ca67b91d32f81b1ce6de5eda10a653822d67af0
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 16 17:59:03 2019 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/4ca67b91d32f81b1ce6de5eda10a653822d67af0 [^]

[NewDiscountEngine] Related to issue 41760: Manual discounts should be applicable
even if there are no available units in the line

Fix some values in the test as in the old discount engine where calculated
different from new discount engine.

---
M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/splitline/I39858_VerifySplitLineWithManualAndAutoPromo.java
---