Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041744Retail ModulesContact Info for Productpublic2019-09-03 13:082019-10-23 13:52
Reporterasiermartirena 
Assigned Toranjith_qualiantech_com 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR20Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041744: It's not possible to use the contact info functionality in offline with remote bp
DescriptionIt's not possible to use the contact info functionality offline when having the remote property for business partners set.

The problem is that when we are offline and in remote, we are not able to search for bp, so is mandatory to create a new one. This is correct now. The problem is that after creating the bp, only the bp and bpAddrs ids are set to the contact info line, instead of setting the full information, so when finishing the contact info action is not possible to verify if all the flags are set for the business partner.
Steps To ReproduceLoad in the Web POS having the contact info module installed and the remote preference for bp set to true.
Go to offline.
Add a product to the ticket which requires contact info.
Realize that it is not possible to load business partners (correct).
Realize that is possible to create a new bp with the address, and assign it to the contact info.
Realize that is not possible to finish the contact info action, because is not possible to load the newly created bp to check it's properties.
Proposed SolutionWhen adding the contact info line to a ticket, instead of setting only the bp id and the bpAddrs id, set the full objects. In this way, the line will have later the full information to check if there are missing attributes. In addition, two queries will be avoided, the one to search the bp and the one to search the address.

Finally, it would be recommendable to set only the ids to the lines, to avoid to send really big json objects during the synchronization.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-03 13:08asiermartirenaNew Issue
2019-09-03 13:08asiermartirenaAssigned To => Retail
2019-09-03 13:08asiermartirenaRegression date => 2019-09-24
2019-09-03 13:08asiermartirenaTriggers an Emergency Pack => No
2019-09-23 15:23ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2019-09-25 13:15ranjith_qualiantech_comStatusnew => scheduled
2019-09-27 08:18marvintmResolution time => 1569967200
2019-09-27 08:18marvintmRegression date2019-09-24 =>
2019-10-08 09:17hgbotCheckin
2019-10-08 09:17hgbotNote Added: 0114943
2019-10-08 09:41hgbotCheckin
2019-10-08 09:41hgbotNote Added: 0114944
2019-10-09 08:57ranjith_qualiantech_comStatusscheduled => resolved
2019-10-09 08:57ranjith_qualiantech_comResolutionopen => fixed
2019-10-15 16:25nicolasurizIssue Monitored: nicolasuriz
2019-10-15 16:39adrianromeroReview Assigned To => adrianromero
2019-10-15 16:39adrianromeroNote Added: 0115094
2019-10-15 16:39adrianromeroStatusresolved => closed
2019-10-17 13:28kchoperenaNote Added: 0115145
2019-10-17 13:28kchoperenaStatusclosed => new
2019-10-17 13:28kchoperenaResolutionfixed => open
2019-10-21 07:49ranjith_qualiantech_comStatusnew => scheduled
2019-10-21 08:55kchoperenaNote Edited: 0115145bug_revision_view_page.php?bugnote_id=0115145#r19530
2019-10-21 15:38hgbotCheckin
2019-10-21 15:38hgbotNote Added: 0115189
2019-10-21 15:38hgbotStatusscheduled => resolved
2019-10-21 15:38hgbotResolutionopen => fixed
2019-10-21 15:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26770a6ef067031ec97e16b2363bd5bc532821c0 [^]
2019-10-23 13:52marvintmReview Assigned Toadrianromero => marvintm
2019-10-23 13:52marvintmStatusresolved => closed
2019-10-23 13:52marvintmFixed in Version => RR20Q1

Notes
(0114943)
hgbot   
2019-10-08 09:17   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 01f22f1d07867b74e4090a0d29befb75524f63ef
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Oct 08 12:47:18 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/01f22f1d07867b74e4090a0d29befb75524f63ef [^]

Related to issue 41744 : Added locationModel to BusinessPartner when updating Location

---
M web/org.openbravo.retail.posterminal/js/components/bplocation.js
---
(0114944)
hgbot   
2019-10-08 09:41   
Repository: erp/pmods/org.openbravo.retail.contactinfoforproduct
Changeset: 20c59cfe57e3cc44cefe20e8d4fba544643cd08e
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Oct 08 13:11:13 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.contactinfoforproduct/rev/20c59cfe57e3cc44cefe20e8d4fba544643cd08e [^]

Related to issue 41744 : Updated Customer assignment to Product Item Declaration

* With Remote Pref. enabled,
  When assigning Customer to ItemDeclaration, Instead of fetching Customer details from backoffice/local db,
  Updated Customer Model will be available when Selecting/creating cusomter in Customer Popup.
* Additionaly when applying ItemDeclaration, Customer and Location model is updated to Line Model
  along with Cusotmer and Location Id. (These models should be removed from line when Syncing receipt to backoffice)

---
M src/org/openbravo/retail/contactinfoforproduct/ContactInfoForProductComponentProvider.java
M web/org.openbravo.retail.contactinfoforproduct/js/hookPrePayment.js
M web/org.openbravo.retail.contactinfoforproduct/js/modalItemDeclaration.js
M web/org.openbravo.retail.contactinfoforproduct/js/receiptLineEdit.js
A web/org.openbravo.retail.contactinfoforproduct/js/hookPreSyncReceipt.js
---
(0115094)
adrianromero   
2019-10-15 16:39   
Functionality fixed, code verified.
(0115145)
kchoperena   
2019-10-17 13:28   
(edited on: 2019-10-21 08:55)
The fix is not working when the 'Enable Remote for Customer'=Y

Configuration:
- Product [Avalanche transceiver] -> Item Declaration = Y
- Preference -> Enable Remote for Customer = Y
Steps:
1.- Log into the WebPOS
2.- Assign a customer to the receipt. I.e: Arturo Montoro
3.- Click on F5
4.- Search the product 'Avalanche transceiver' and add to the receipt
    EXPECTED RESULT:

    JS error:
       66c777eddd3864e9b626d300abb0a0dc.js:154122 Uncaught TypeError: bpLoc.set is not a function
    at updateCallbackModel (66c777eddd3864e9b626d300abb0a0dc.js:154122)
    at Object.executeOnShow (66c777eddd3864e9b626d300abb0a0dc.js:154140)
    at Object.show (66c777eddd3864e9b626d300abb0a0dc.js:11658)
    at Object.showPopup (66c777eddd3864e9b626d300abb0a0dc.js:13547)
    at Object.showPopupHandler (66c777eddd3864e9b626d300abb0a0dc.js:13527)
    at Object.dispatch (enyo.js:628)
    at Object.dispatchEvent (enyo.js:612)
    at Object.enyo.kind.inherited (enyo.js:410)
    at Object.dispatchEvent (enyo.js:1338)
    at Object.dispatchBubble (enyo.js:616)
(0115189)
hgbot   
2019-10-21 15:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 26770a6ef067031ec97e16b2363bd5bc532821c0
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Oct 21 19:07:54 2019 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/26770a6ef067031ec97e16b2363bd5bc532821c0 [^]

Fixed issue 41744 : BP Properties should be restored with Model data when doing refresh

* BP locationBillModel json data should be converted to Model data when initializing receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---