Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041737Openbravo ERP07. Sales managementpublic2019-09-02 12:202019-09-05 12:19
Reporterjoniturralde93 
Assigned Tocollazoandy4 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0PR19Q3.1Fixed in Version3.0PR19Q3.1 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket11542
Regression levelProduction - Confirmed Stable
Regression date2018-03-18
Regression introduced in release3.0PR19Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/a121302dfba615e486bbfcd4fe8caaed6116e051 [^]
Triggers an Emergency PackNo
Summary0041737: Modify payment plan recalculation when deleting line
DescriptionWhen you do a Modify Payment plan when there two lines, prior to 19Q2 you could delete the first one and change the second one quantity to the total, and after pressing enter, Expected amount would be recalculated.

After 19Q2, this doesn't happen. You need to change the first line Outstanding to 0 and the second line to the total amount, and then after pressing enter, Expected amount is recalculated.
Steps To Reproduce1. Make "Modify Payment Plan" button in Sales invoice visible
2. Find or create an invoice with two lines of payment plan
3. Modify Payment plan
4a. Delete first line
5a. Change outstanding of second line to total and press enter
6a. Expected amount is not recalculated (in 19Q1 it is)

Workaround for 19Q2:
4b. Change first line outstanding to 0
5b. Change outstanding of second line to total and press enter
6b. Expected amount is recalculated
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0041732pi closed collazoandy4 Modify payment plan recalculation when deleting line 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-09-02 17:30SandrahuguetTypedefect => backport
2019-09-02 17:30SandrahuguetTarget Versionpi => 3.0PR19Q3.2
2019-09-04 09:55SandrahuguetTarget Version3.0PR19Q3.2 => 3.0PR19Q3.1
2019-09-05 12:17hgbotCheckin
2019-09-05 12:17hgbotNote Added: 0114420
2019-09-05 12:17hgbotStatusscheduled => resolved
2019-09-05 12:17hgbotResolutionopen => fixed
2019-09-05 12:17hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR19Q3.1/rev/db9908961a58cd730b71c7243981b2680f2ff75b [^]
2019-09-05 12:19SandrahuguetReview Assigned To => Sandrahuguet
2019-09-05 12:19SandrahuguetNote Added: 0114422
2019-09-05 12:19SandrahuguetStatusresolved => closed
2019-09-05 12:19SandrahuguetFixed in Version => 3.0PR19Q3.1

Notes
(0114420)
hgbot   
2019-09-05 12:17   
Repository: erp/backports/3.0PR19Q3.1
Changeset: db9908961a58cd730b71c7243981b2680f2ff75b
Author: Armaignac <collazoandy4 <at> gmail.com>
Date: Wed Sep 04 18:31:06 2019 -0400
URL: http://code.openbravo.com/erp/backports/3.0PR19Q3.1/rev/db9908961a58cd730b71c7243981b2680f2ff75b [^]

Fixes issue 41737: Modify payment plan recalculation when deleting line

A wrong outstanding amount was used to check if all payment plan lines are valid

Now if the total outstanding amount plus the total received are distinct from the
invoice grand total an error is shown indicating a wrong payment plan quantity

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0114422)
Sandrahuguet   
2019-09-05 12:19   
code review + testing ok