Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041731Retail ModulesCoupons OTFpublic2019-08-30 13:072019-09-26 16:25
Reporterngarcia 
Assigned Torqueralta 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041731: Changing the organization of a Discount a Promotions window is not transferred to Coupon tab
DescriptionChanging the organization of a Discount a Promotions window is not transferred to Coupon tab.

It should be decided if the change should be transferred to the children records or changing the organization should be disabled

It could cause the order to get stuck in Errors While Importing POS Data with the following error:

Entity ... (OrderLineOffer) with organization ... references an entity ... through its property OrderLineOffer.obdiscpCoupon but this referenced entity belongs to an organization ... which is not part of the natural tree of ...
Steps To Reproduce*
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-30 13:07ngarciaNew Issue
2019-08-30 13:07ngarciaAssigned To => Retail
2019-08-30 13:07ngarciaTriggers an Emergency Pack => No
2019-08-30 13:08ngarciaResolution time => 1568930400
2019-08-30 15:05ngarciaIssue Monitored: networkb
2019-09-09 15:13rqueraltaAssigned ToRetail => rqueralta
2019-09-09 15:15rqueraltaStatusnew => scheduled
2019-09-19 15:30hgbotCheckin
2019-09-19 15:30hgbotNote Added: 0114667
2019-09-19 15:30hgbotStatusscheduled => resolved
2019-09-19 15:30hgbotResolutionopen => fixed
2019-09-19 15:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/be78007ce376f475d3ff1e9ea78d71e309f06145 [^]
2019-09-19 20:45hgbotCheckin
2019-09-19 20:45hgbotNote Added: 0114678
2019-09-19 20:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/be78007ce376f475d3ff1e9ea78d71e309f06145 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/d3e0fa551af83cd86c97f2f5de8805b0669865a7 [^]
2019-09-20 08:42marvintmReview Assigned To => marvintm
2019-09-20 08:42marvintmStatusresolved => closed
2019-09-20 08:42marvintmFixed in Version => RR19Q4
2019-09-20 13:04marvintmNote Added: 0114693
2019-09-20 13:04marvintmStatusclosed => new
2019-09-20 13:04marvintmResolutionfixed => open
2019-09-20 13:04marvintmFixed in VersionRR19Q4 =>
2019-09-20 13:05hgbotCheckin
2019-09-20 13:05hgbotNote Added: 0114695
2019-09-20 13:06hgbotCheckin
2019-09-20 13:06hgbotNote Added: 0114696
2019-09-25 14:11hgbotCheckin
2019-09-25 14:11hgbotNote Added: 0114782
2019-09-25 14:11hgbotStatusnew => resolved
2019-09-25 14:11hgbotResolutionopen => fixed
2019-09-25 14:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/d3e0fa551af83cd86c97f2f5de8805b0669865a7 [^] => http://code.openbravo.com/erp/devel/pi/rev/97d599340105c42e7bbaeb894bfd0f12b700acdf [^]
2019-09-26 15:10hudsonbotCheckin
2019-09-26 15:10hudsonbotNote Added: 0114810
2019-09-26 16:25marvintmStatusresolved => closed
2019-09-26 16:25marvintmFixed in Version => RR19Q4

Notes
(0114667)
hgbot   
2019-09-19 15:30   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: be78007ce376f475d3ff1e9ea78d71e309f06145
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Sep 10 19:06:14 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/be78007ce376f475d3ff1e9ea78d71e309f06145 [^]

Fixed issue 41731: Changing the organization of a Discount a Promotions window
is not transferred to Coupon tab

- Added a new hook to extend the MOfferEventHandler logic in others modules

---
M src/org/openbravo/retail/discounts/event/MOfferEventHandler.java
A src/org/openbravo/retail/discounts/DiscountFieldsHook.java
A src/org/openbravo/retail/discounts/DiscountFieldsHookCaller.java
---
(0114678)
hgbot   
2019-09-19 20:45   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: d3e0fa551af83cd86c97f2f5de8805b0669865a7
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Sep 10 19:09:33 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/d3e0fa551af83cd86c97f2f5de8805b0669865a7 [^]

Fixed issue 41731: Changing the organization of a Discount a Promotions window
is not transferred to Coupon tab

- Implemented DiscountFieldsHook to transfer the new discount organization to the
coupons child

---
A src/org/openbravo/retail/discounts/coupons/DiscountsHookCoupons.java
---
(0114693)
marvintm   
2019-09-20 13:04   
Fix is causing problems in integration
(0114695)
hgbot   
2019-09-20 13:05   
Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: cdc795a71bc0281a82773dbf20886cb02fa3eb1b
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Fri Sep 20 13:05:41 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/cdc795a71bc0281a82773dbf20886cb02fa3eb1b [^]

Related to issue 41731. Backed out fix as it was causing problems in integration

---
M src/org/openbravo/retail/discounts/event/MOfferEventHandler.java
R src/org/openbravo/retail/discounts/DiscountFieldsHook.java
R src/org/openbravo/retail/discounts/DiscountFieldsHookCaller.java
---
(0114696)
hgbot   
2019-09-20 13:06   
Repository: erp/pmods/org.openbravo.retail.discounts.coupons
Changeset: 3abec80ac4b5a54f0b46fe979b0aaf51d6c1b8f6
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Fri Sep 20 13:06:12 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.coupons/rev/3abec80ac4b5a54f0b46fe979b0aaf51d6c1b8f6 [^]

Related to issue 41731. Backed out fix as it was causing problems in integration

---
R src/org/openbravo/retail/discounts/coupons/DiscountsHookCoupons.java
---
(0114782)
hgbot   
2019-09-25 14:11   
Repository: erp/devel/pi
Changeset: 97d599340105c42e7bbaeb894bfd0f12b700acdf
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Sep 24 16:01:19 2019 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/97d599340105c42e7bbaeb894bfd0f12b700acdf [^]

Fixed issue 41731: Changing the organization of a Discount a Promotions window
is not transferred to Coupon tab

- Was put as not updatable the organization column in m_offer table

---
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0114810)
hudsonbot   
2019-09-26 15:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/409f4217568a [^]
Maturity status: Test