Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0041728Retail ModulesWeb POSpublic2019-08-30 10:592019-09-30 12:18
Reporterxabiermerino 
Assigned Tojorge-garcia 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR19Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0041728: It is not possible reprint a PDF from webPOS
DescriptionIt is necessary to have a PDF format for, for example, invoices.
Steps To Reproduce1.- Log into webPOS
2.- Create a ticket with Invoice check, realize that the PDF invoice is printed
3.- Pay it
4.- Search it using Open Receipts
5.- Click Print this ticket
6.- Select the invoice related with the ticket and print
7.- JS Error:

Uncaught TypeError: Cannot read property 'receiptLines' of undefined
    at printInvoice (6435b23b9fcf3c32157d1e5fddfab65e.js:2674)
    at Object.callback (6435b23b9fcf3c32157d1e5fddfab65e.js:2675)
    at 6435b23b9fcf3c32157d1e5fddfab65e.js:2757
    at G.d.callbackExecutor (6435b23b9fcf3c32157d1e5fddfab65e.js:764)
    at 6435b23b9fcf3c32157d1e5fddfab65e.js:4422
    at G.d.callbackExecutor (6435b23b9fcf3c32157d1e5fddfab65e.js:764)
    at 6435b23b9fcf3c32157d1e5fddfab65e.js:4075
    at G.d.callbackExecutor (6435b23b9fcf3c32157d1e5fddfab65e.js:764)
    at G.d.executeHooks (6435b23b9fcf3c32157d1e5fddfab65e.js:764)
    at 6435b23b9fcf3c32157d1e5fddfab65e.js:2757
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2019-08-30 10:59xabiermerinoNew Issue
2019-08-30 10:59xabiermerinoAssigned To => Retail
2019-08-30 10:59xabiermerinoResolution time => 1568498400
2019-08-30 10:59xabiermerinoTriggers an Emergency Pack => No
2019-09-02 13:36rqueraltaAssigned ToRetail => rqueralta
2019-09-02 13:36rqueraltaStatusnew => scheduled
2019-09-09 03:36hgbotCheckin
2019-09-09 03:36hgbotNote Added: 0114446
2019-09-09 03:36hgbotStatusscheduled => resolved
2019-09-09 03:36hgbotResolutionopen => fixed
2019-09-09 03:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/15c2e97b27863a384eb70ac80dab2931554c45ff [^]
2019-09-12 15:46marvintmNote Added: 0114544
2019-09-12 15:46marvintmStatusresolved => new
2019-09-12 15:46marvintmResolutionfixed => open
2019-09-16 17:45hgbotCheckin
2019-09-16 17:45hgbotNote Added: 0114587
2019-09-16 17:45hgbotStatusnew => resolved
2019-09-16 17:45hgbotResolutionopen => fixed
2019-09-16 17:45hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/15c2e97b27863a384eb70ac80dab2931554c45ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf2d4fed6b5d586c0d69a85c135b49bd5c05c96 [^]
2019-09-23 05:28hgbotCheckin
2019-09-23 05:28hgbotNote Added: 0114711
2019-09-23 05:28hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf2d4fed6b5d586c0d69a85c135b49bd5c05c96 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e0a0b3c0ede6c63d8fe073b578efef22a6402923 [^]
2019-09-25 08:42jorge-garciaReview Assigned To => jorge-garcia
2019-09-25 17:04jorge-garciaNote Added: 0114783
2019-09-25 17:04jorge-garciaStatusresolved => new
2019-09-25 17:04jorge-garciaResolutionfixed => open
2019-09-30 09:06hgbotCheckin
2019-09-30 09:06hgbotNote Added: 0114854
2019-09-30 09:06hgbotStatusnew => resolved
2019-09-30 09:06hgbotResolutionopen => fixed
2019-09-30 09:06hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e0a0b3c0ede6c63d8fe073b578efef22a6402923 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88395ec379c80b72056f6b967646322cb69e5d2a [^]
2019-09-30 10:18marvintmAssigned Torqueralta => jorge-garcia
2019-09-30 10:44jorge-garciaReview Assigned Tojorge-garcia => marvintm
2019-09-30 12:18marvintmStatusresolved => closed
2019-09-30 12:18marvintmFixed in Version => RR19Q4

Notes
(0114446)
hgbot   
2019-09-09 03:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 15c2e97b27863a384eb70ac80dab2931554c45ff
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Sep 03 15:55:49 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/15c2e97b27863a384eb70ac80dab2931554c45ff [^]

Fixed issue 41728: It is not possible reprint a PDF from webPOS

- Checked if data object is undefined or not

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0114544)
marvintm   
2019-09-12 15:46   
Problem can still be reproduced after the fix
(0114587)
hgbot   
2019-09-16 17:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0cf2d4fed6b5d586c0d69a85c135b49bd5c05c96
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Sun Sep 15 22:29:05 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0cf2d4fed6b5d586c0d69a85c135b49bd5c05c96 [^]

Fixed issue 41728: It is not possible reprint a PDF from webPOS

- Checked data object length

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0114711)
hgbot   
2019-09-23 05:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e0a0b3c0ede6c63d8fe073b578efef22a6402923
Author: Rafael Queralta <rafaelcuba81 <at> gmail.com>
Date: Tue Sep 17 06:19:16 2019 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e0a0b3c0ede6c63d8fe073b578efef22a6402923 [^]

Fixed issue 41728: It is not possible reprint a PDF from webPOS

- Modified the recursive function parameter so as not to change its value when
you leave the call

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
---
(0114783)
jorge-garcia   
2019-09-25 17:04   
Problem is still reproducible in client's environment after fix is applied
(0114854)
hgbot   
2019-09-30 09:06   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 88395ec379c80b72056f6b967646322cb69e5d2a
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Sep 27 13:44:06 2019 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/88395ec379c80b72056f6b967646322cb69e5d2a [^]

Fixed issue 41728: It is not possible reprint a PDF from webPOS

Three changes included:
  * If data current index is greater or equal to data length, do nothing
  * When trying to print the ticket, if error has happended, try
    to print again the same ticket.
  * Return an object in print callback to indicate if it has failed.

---
M web/org.openbravo.retail.posterminal/js/components/modalinvoices.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
---